Skip to content

Conversation

@ashishpandey2600
Copy link
Contributor

Screenshot 2020-11-04 at 1 07 21 PM

small grammatical update to the torch tech docs.

@facebook-github-bot
Copy link
Contributor

Hi @ashishpandey2600!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@dr-ci
Copy link

dr-ci bot commented Nov 4, 2020

💊 CI failures summary and remediations

As of commit d2853c3 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 18 times.

@ejguan ejguan self-requested a review November 4, 2020 17:29
@ejguan
Copy link
Contributor

ejguan commented Nov 4, 2020

LGTM.
Can you please rebase this PR against viable/strict branch to make sure all CI green?

@ejguan ejguan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 4, 2020
@ashishpandey2600
Copy link
Contributor Author

can, please can anybody help me , i m new to this

@ashishpandey2600
Copy link
Contributor Author

it is showing merging is block

@ashishpandey2600
Copy link
Contributor Author

LGTM.
Can you please rebase this PR against viable/strict branch to make sure all CI green?

please, sir can u explain i have not understood.

@ejguan
Copy link
Contributor

ejguan commented Nov 10, 2020

it is showing merging is block

Thanks for the update, I think it looks great now. I will merge this PR.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #47345 (d2853c3) into master (57dcb04) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #47345      +/-   ##
==========================================
- Coverage   81.22%   81.08%   -0.15%     
==========================================
  Files        1836     1836              
  Lines      197680   197680              
==========================================
- Hits       160575   160295     -280     
- Misses      37105    37385     +280     

@facebook-github-bot
Copy link
Contributor

@ejguan merged this pull request in a843d48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants