-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Fix #42271 #50141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #42271 #50141
Conversation
|
Hi @TomHeaven! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
💊 CI failures summary and remediationsAs of commit 4d56f7c (more details on the Dr. CI page):
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
|
Need CLA |
|
|
||
| // Determine our output size | ||
| ptrdiff_t totalElements = THTensor_wrap(mask).sum().item<ptrdiff_t>(); | ||
| ptrdiff_t totalElements = THTensor_wrap(mask).sum().item<int64_t>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why return type should be ptrdiff_t rather than int64_t?
| ptrdiff_t totalElements = THTensor_wrap(mask).sum().item<int64_t>(); | |
| int64_t totalElements = THTensor_wrap(mask).sum().item<int64_t>(); |
|
|
||
| // Determine our output size | ||
| ptrdiff_t totalElements = THTensor_wrap(mask).sum().item<ptrdiff_t>(); | ||
| ptrdiff_t totalElements = THTensor_wrap(mask).sum().item<int64_t>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as below
| ptrdiff_t totalElements = THTensor_wrap(mask).sum().item<int64_t>(); | |
| int64_t totalElements = THTensor_wrap(mask).sum().item<int64_t>(); |
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary:
This pull fix #{42271} by manually specify template data type of `tensor<template>.item()` in `aten/src/THC/generic/THCTensorMasked.cu`.
Changes in submodules are not expected since I have pulled the latest submodules from the Pytorch master branch.
Pull Request resolved: pytorch#50141
Reviewed By: zou3519
Differential Revision: D25826104
Pulled By: ezyang
fbshipit-source-id: 80527a14786b36e4e520fdecc932e257d2520f89
This pull fix #42271 by manually specifying template data type of
tensor<template>.item()inaten/src/THC/generic/THCTensorMasked.cu.Changes in submodules are not expected since I have pulled the latest submodules from the Pytorch master branch.