Skip to content

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Apr 27, 2021

Stack from ghstack:

Summary:

To support shadows of custom functions, we need to allow user to
specify I/O type of the custom functions.

This PR is a cleanup in preparation for making the above happen.
We make the I/O dtype mappings be generated by a function instead
of a global variable. In the next PR, we will add a hook so user
can modify these mappings.

Test Plan:

python test/test_quantization.py TestFXNumericSuiteCoreAPIs

Differential Revision: D28030094

Summary:

To support shadows of custom functions, we need to allow user to
specify I/O type of the custom functions.

This PR is a cleanup in preparation for making the above happen.
We make the I/O dtype mappings be generated by a function instead
of a global variable. In the next PR, we will add a hook so user
can modify these mappings.

Test Plan:
```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs
```

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 27, 2021

💊 CI failures summary and remediations

As of commit 2f06fb4 (more details on the Dr. CI page):



❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Apr 27 17:01:21 RuntimeError: Process 0 terminated or timed out after 110.049307346344 seconds
Apr 27 17:01:21 ======================================================================
Apr 27 17:01:21 ERROR [110.073s]: test_nccl_high_priority_stream (__main__.TestDistBackendWithSpawn)
Apr 27 17:01:21 ----------------------------------------------------------------------
Apr 27 17:01:21 Traceback (most recent call last):
Apr 27 17:01:21   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 374, in wrapper
Apr 27 17:01:21     self._join_processes(fn)
Apr 27 17:01:21   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 566, in _join_processes
Apr 27 17:01:21     self._check_return_codes(elapsed_time)
Apr 27 17:01:21   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 614, in _check_return_codes
Apr 27 17:01:21     raise RuntimeError('Process {} terminated or timed out after {} seconds'.format(i, elapsed_time))
Apr 27 17:01:21 RuntimeError: Process 0 terminated or timed out after 110.049307346344 seconds
Apr 27 17:01:21 
Apr 27 17:01:21 ----------------------------------------------------------------------
Apr 27 17:01:21 Ran 196 tests in 715.617s
Apr 27 17:01:21 
Apr 27 17:01:21 FAILED (errors=4, skipped=117)
Apr 27 17:01:21 
Apr 27 17:01:21 Generating XML reports...
Apr 27 17:01:21 Generated XML report: test-reports/dist-nccl/distributed.test_distributed_spawn/TEST-TestDistBackendWithSpawn-20210427164925.xml
Apr 27 17:01:21 Traceback (most recent call last):
Apr 27 17:01:21   File "test/run_test.py", line 1156, in <module>

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

… of global"

Summary:

To support shadows of custom functions, we need to allow user to
specify I/O type of the custom functions.

This PR is a cleanup in preparation for making the above happen.
We make the I/O dtype mappings be generated by a function instead
of a global variable. In the next PR, we will add a hook so user
can modify these mappings.

Test Plan:
```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs
```

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@vkuzo merged this pull request in c4bec76.

@facebook-github-bot facebook-github-bot deleted the gh/vkuzo/318/head branch May 1, 2021 14:16
aocsa pushed a commit to Quansight/pytorch that referenced this pull request May 3, 2021
…ytorch#57021)

Summary:
Pull Request resolved: pytorch#57021

To support shadows of custom functions, we need to allow user to
specify I/O type of the custom functions.

This PR is a cleanup in preparation for making the above happen.
We make the I/O dtype mappings be generated by a function instead
of a global variable. In the next PR, we will add a hook so user
can modify these mappings.

Test Plan:
```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs
```

Reviewed By: jerryzh168

Differential Revision: D28030094

Pulled By: vkuzo

fbshipit-source-id: 3cbb617f034ef385c2875c4ec7fed13ca30bfc57
crcrpar pushed a commit to crcrpar/pytorch that referenced this pull request May 7, 2021
…ytorch#57021)

Summary:
Pull Request resolved: pytorch#57021

To support shadows of custom functions, we need to allow user to
specify I/O type of the custom functions.

This PR is a cleanup in preparation for making the above happen.
We make the I/O dtype mappings be generated by a function instead
of a global variable. In the next PR, we will add a hook so user
can modify these mappings.

Test Plan:
```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs
```

Reviewed By: jerryzh168

Differential Revision: D28030094

Pulled By: vkuzo

fbshipit-source-id: 3cbb617f034ef385c2875c4ec7fed13ca30bfc57
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
…ytorch#57021)

Summary:
Pull Request resolved: pytorch#57021

To support shadows of custom functions, we need to allow user to
specify I/O type of the custom functions.

This PR is a cleanup in preparation for making the above happen.
We make the I/O dtype mappings be generated by a function instead
of a global variable. In the next PR, we will add a hook so user
can modify these mappings.

Test Plan:
```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs
```

Reviewed By: jerryzh168

Differential Revision: D28030094

Pulled By: vkuzo

fbshipit-source-id: 3cbb617f034ef385c2875c4ec7fed13ca30bfc57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants