-
Notifications
You must be signed in to change notification settings - Fork 25.6k
ns for fx: support binary ops when adding unshadowed loggers for inputs #57025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adds the ability to log unshadowed inputs of binary ops such as `add` and `mul`, when indices 0, 1, or 0 and 1 are tensors. Note: making shadowing support this is saved for a future PR. Test Plan: ``` python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_add_mul_inputs_activations ``` [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 131c00c (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
This was referenced Apr 27, 2021
…rs for inputs" Summary: Adds the ability to log unshadowed inputs of binary ops such as `add` and `mul`, when indices 0, 1, or 0 and 1 are tensors. Note: making shadowing support this is saved for a future PR. Test Plan: ``` python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_add_mul_inputs_activations ``` [ghstack-poisoned]
jerryzh168
approved these changes
Apr 27, 2021
aocsa
pushed a commit
to Quansight/pytorch
that referenced
this pull request
May 3, 2021
…ts (pytorch#57025) Summary: Pull Request resolved: pytorch#57025 Adds the ability to log unshadowed inputs of binary ops such as `add` and `mul`, when indices 0, 1, or 0 and 1 are tensors. Note: making shadowing support this is saved for a future PR. Test Plan: ``` python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_add_mul_inputs_activations ``` Reviewed By: jerryzh168 Differential Revision: D28030098 Pulled By: vkuzo fbshipit-source-id: fd46760faac153975cd7688e70c44991ec1d5dff
crcrpar
pushed a commit
to crcrpar/pytorch
that referenced
this pull request
May 7, 2021
…ts (pytorch#57025) Summary: Pull Request resolved: pytorch#57025 Adds the ability to log unshadowed inputs of binary ops such as `add` and `mul`, when indices 0, 1, or 0 and 1 are tensors. Note: making shadowing support this is saved for a future PR. Test Plan: ``` python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_add_mul_inputs_activations ``` Reviewed By: jerryzh168 Differential Revision: D28030098 Pulled By: vkuzo fbshipit-source-id: fd46760faac153975cd7688e70c44991ec1d5dff
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
…ts (pytorch#57025) Summary: Pull Request resolved: pytorch#57025 Adds the ability to log unshadowed inputs of binary ops such as `add` and `mul`, when indices 0, 1, or 0 and 1 are tensors. Note: making shadowing support this is saved for a future PR. Test Plan: ``` python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_add_mul_inputs_activations ``` Reviewed By: jerryzh168 Differential Revision: D28030098 Pulled By: vkuzo fbshipit-source-id: fd46760faac153975cd7688e70c44991ec1d5dff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Adds the ability to log unshadowed inputs of binary ops such as
add
and
mul
, when indices 0, 1, or 0 and 1 are tensors.Note: making shadowing support this is saved for a future PR.
Test Plan:
Differential Revision: D28030098