Skip to content

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Apr 27, 2021

Stack from ghstack:

Summary:

Adds the ability to log unshadowed inputs of binary ops such as add
and mul, when indices 0, 1, or 0 and 1 are tensors.

Note: making shadowing support this is saved for a future PR.

Test Plan:

python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_add_mul_inputs_activations

Differential Revision: D28030098

Summary:

Adds the ability to log unshadowed inputs of binary ops such as `add`
and `mul`, when indices 0, 1, or 0 and 1 are tensors.

Note: making shadowing support this is saved for a future PR.

Test Plan:
```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_add_mul_inputs_activations
```

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 27, 2021

💊 CI failures summary and remediations

As of commit 131c00c (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Apr 27 16:57:12 RuntimeError: Process 0 terminated or timed out after 110.04590153694153 seconds
Apr 27 16:57:12 ======================================================================
Apr 27 16:57:12 ERROR [110.069s]: test_nccl_high_priority_stream (__main__.TestDistBackendWithSpawn)
Apr 27 16:57:12 ----------------------------------------------------------------------
Apr 27 16:57:12 Traceback (most recent call last):
Apr 27 16:57:12   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 374, in wrapper
Apr 27 16:57:12     self._join_processes(fn)
Apr 27 16:57:12   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 566, in _join_processes
Apr 27 16:57:12     self._check_return_codes(elapsed_time)
Apr 27 16:57:12   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 614, in _check_return_codes
Apr 27 16:57:12     raise RuntimeError('Process {} terminated or timed out after {} seconds'.format(i, elapsed_time))
Apr 27 16:57:12 RuntimeError: Process 0 terminated or timed out after 110.04590153694153 seconds
Apr 27 16:57:12 
Apr 27 16:57:12 ----------------------------------------------------------------------
Apr 27 16:57:12 Ran 196 tests in 658.033s
Apr 27 16:57:12 
Apr 27 16:57:12 FAILED (errors=4, skipped=117)
Apr 27 16:57:12 
Apr 27 16:57:12 Generating XML reports...
Apr 27 16:57:12 Generated XML report: test-reports/dist-nccl/distributed.test_distributed_spawn/TEST-TestDistBackendWithSpawn-20210427164614.xml
Apr 27 16:57:12 Traceback (most recent call last):
Apr 27 16:57:12   File "test/run_test.py", line 1156, in <module>

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

…rs for inputs"

Summary:

Adds the ability to log unshadowed inputs of binary ops such as `add`
and `mul`, when indices 0, 1, or 0 and 1 are tensors.

Note: making shadowing support this is saved for a future PR.

Test Plan:
```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_add_mul_inputs_activations
```

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@vkuzo merged this pull request in e8a5490.

@facebook-github-bot facebook-github-bot deleted the gh/vkuzo/322/head branch May 1, 2021 14:16
aocsa pushed a commit to Quansight/pytorch that referenced this pull request May 3, 2021
…ts (pytorch#57025)

Summary:
Pull Request resolved: pytorch#57025

Adds the ability to log unshadowed inputs of binary ops such as `add`
and `mul`, when indices 0, 1, or 0 and 1 are tensors.

Note: making shadowing support this is saved for a future PR.

Test Plan:
```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_add_mul_inputs_activations
```

Reviewed By: jerryzh168

Differential Revision: D28030098

Pulled By: vkuzo

fbshipit-source-id: fd46760faac153975cd7688e70c44991ec1d5dff
crcrpar pushed a commit to crcrpar/pytorch that referenced this pull request May 7, 2021
…ts (pytorch#57025)

Summary:
Pull Request resolved: pytorch#57025

Adds the ability to log unshadowed inputs of binary ops such as `add`
and `mul`, when indices 0, 1, or 0 and 1 are tensors.

Note: making shadowing support this is saved for a future PR.

Test Plan:
```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_add_mul_inputs_activations
```

Reviewed By: jerryzh168

Differential Revision: D28030098

Pulled By: vkuzo

fbshipit-source-id: fd46760faac153975cd7688e70c44991ec1d5dff
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
…ts (pytorch#57025)

Summary:
Pull Request resolved: pytorch#57025

Adds the ability to log unshadowed inputs of binary ops such as `add`
and `mul`, when indices 0, 1, or 0 and 1 are tensors.

Note: making shadowing support this is saved for a future PR.

Test Plan:
```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_add_mul_inputs_activations
```

Reviewed By: jerryzh168

Differential Revision: D28030098

Pulled By: vkuzo

fbshipit-source-id: fd46760faac153975cd7688e70c44991ec1d5dff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants