[quant] Input-Weight Equalization - Conv prepare support #61286
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Modifies the prepare step to support conv layers during input-weight equalization. Test Plan: `python test/test_quantization.py TestEqualizeFx.test_input_weight_equalization_prepare` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 46cce5a (more details on the Dr. CI page and at hud.pytorch.org/pr/61286):
Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Summary: Modifies the prepare step to support conv layers during input-weight equalization. Test Plan: `python test/test_quantization.py TestEqualizeFx.test_input_weight_equalization_prepare` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Modifies the prepare step to support conv layers during input-weight equalization and adds tests to make sure that the results are as expected.
Initial:
```
w
|
x -> conv -> y
```
After prepare:
```
w
|
weight_quant_obs
|
weight_eq_obs
|
x -> input_quant_obs -> input_eq_obs -> conv -> out_quant_obs -> y
```
Test Plan: `python test/test_quantization.py TestEqualizeFx.test_input_weight_equalization_prepare`
Initial:
```
ConvModel(
(conv): Conv2d(3, 5, kernel_size=(3, 3), stride=(1, 1), bias=False)
)
```
After prepare:
```
graph():
%x : [#users=1] = placeholder[target=x]
%x_activation_post_process_0 : [#users=1] = call_module[target=x_activation_post_process_0](args = (%x,), kwargs = {})
%x_activation_post_process_0_equalization_process_0 : [#users=1] = call_module[target=x_activation_post_process_0_equalization_process_0](args = (%x_activation_post_process_0,), kwargs = {})
%conv : [#users=1] = call_module[target=conv](args = (%x_activation_post_process_0_equalization_process_0,), kwargs = {})
%conv_activation_post_process_0 : [#users=1] = call_module[target=conv_activation_post_process_0](args = (%conv,), kwargs = {})
return conv_activation_post_process_0
```
Reviewers:
Subscribers:
Tasks:
Tags:
[ghstack-poisoned]
|
@angelayi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Modifies the prepare step to support conv layers during input-weight equalization and adds tests to make sure that the results are as expected.
Initial:
```
w
|
x -> conv -> y
```
After prepare:
```
w
|
weight_quant_obs
|
weight_eq_obs
|
x -> input_quant_obs -> input_eq_obs -> conv -> out_quant_obs -> y
```
Test Plan: `python test/test_quantization.py TestEqualizeFx.test_input_weight_equalization_prepare`
Initial:
```
ConvModel(
(conv): Conv2d(3, 5, kernel_size=(3, 3), stride=(1, 1), bias=False)
)
```
After prepare:
```
graph():
%x : [#users=1] = placeholder[target=x]
%x_activation_post_process_0 : [#users=1] = call_module[target=x_activation_post_process_0](args = (%x,), kwargs = {})
%x_activation_post_process_0_equalization_process_0 : [#users=1] = call_module[target=x_activation_post_process_0_equalization_process_0](args = (%x_activation_post_process_0,), kwargs = {})
%conv : [#users=1] = call_module[target=conv](args = (%x_activation_post_process_0_equalization_process_0,), kwargs = {})
%conv_activation_post_process_0 : [#users=1] = call_module[target=conv_activation_post_process_0](args = (%conv,), kwargs = {})
return conv_activation_post_process_0
```
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: [D29557051](https://our.internmc.facebook.com/intern/diff/D29557051)
[ghstack-poisoned]
angelayi
requested review from
jerryzh168,
supriyar and
vkuzo
and removed request for
vkuzo
Summary: Modifies the prepare step to support conv layers during input-weight equalization and adds tests to make sure that the results are as expected.
Initial:
```
w
|
x -> conv -> y
```
After prepare:
```
w
|
weight_quant_obs
|
weight_eq_obs
|
x -> input_quant_obs -> input_eq_obs -> conv -> out_quant_obs -> y
```
Test Plan: `python test/test_quantization.py TestEqualizeFx.test_input_weight_equalization_prepare`
Initial:
```
ConvModel(
(conv): Conv2d(3, 5, kernel_size=(3, 3), stride=(1, 1), bias=False)
)
```
After prepare:
```
graph():
%x : [#users=1] = placeholder[target=x]
%x_activation_post_process_0 : [#users=1] = call_module[target=x_activation_post_process_0](args = (%x,), kwargs = {})
%x_activation_post_process_0_equalization_process_0 : [#users=1] = call_module[target=x_activation_post_process_0_equalization_process_0](args = (%x_activation_post_process_0,), kwargs = {})
%conv : [#users=1] = call_module[target=conv](args = (%x_activation_post_process_0_equalization_process_0,), kwargs = {})
%conv_activation_post_process_0 : [#users=1] = call_module[target=conv_activation_post_process_0](args = (%conv,), kwargs = {})
return conv_activation_post_process_0
```
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: [D29557051](https://our.internmc.facebook.com/intern/diff/D29557051)
[ghstack-poisoned]
supriyar
approved these changes
Jul 7, 2021
Summary: Modifies the prepare step to support conv layers during input-weight equalization and adds tests to make sure that the results are as expected.
Initial:
```
w
|
x -> conv -> y
```
After prepare:
```
w
|
weight_quant_obs
|
weight_eq_obs
|
x -> input_quant_obs -> input_eq_obs -> conv -> out_quant_obs -> y
```
Test Plan: `python test/test_quantization.py TestEqualizeFx.test_input_weight_equalization_prepare`
Initial:
```
ConvModel(
(conv): Conv2d(3, 5, kernel_size=(3, 3), stride=(1, 1), bias=False)
)
```
After prepare:
```
graph():
%x : [#users=1] = placeholder[target=x]
%x_activation_post_process_0 : [#users=1] = call_module[target=x_activation_post_process_0](args = (%x,), kwargs = {})
%x_activation_post_process_0_equalization_process_0 : [#users=1] = call_module[target=x_activation_post_process_0_equalization_process_0](args = (%x_activation_post_process_0,), kwargs = {})
%conv : [#users=1] = call_module[target=conv](args = (%x_activation_post_process_0_equalization_process_0,), kwargs = {})
%conv_activation_post_process_0 : [#users=1] = call_module[target=conv_activation_post_process_0](args = (%conv,), kwargs = {})
return conv_activation_post_process_0
```
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: [D29557051](https://our.internmc.facebook.com/intern/diff/D29557051)
[ghstack-poisoned]
|
@angelayi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jerryzh168
reviewed
Jul 9, 2021
jerryzh168
reviewed
Jul 9, 2021
Summary: Modifies the prepare step to support conv layers during input-weight equalization and adds tests to make sure that the results are as expected.
Initial:
```
w
|
x -> conv -> y
```
After prepare:
```
w
|
weight_quant_obs
|
weight_eq_obs
|
x -> input_quant_obs -> input_eq_obs -> conv -> out_quant_obs -> y
```
Test Plan: `python test/test_quantization.py TestEqualizeFx.test_input_weight_equalization_prepare`
Initial:
```
ConvModel(
(conv): Conv2d(3, 5, kernel_size=(3, 3), stride=(1, 1), bias=False)
)
```
After prepare:
```
graph():
%x : [#users=1] = placeholder[target=x]
%x_activation_post_process_0 : [#users=1] = call_module[target=x_activation_post_process_0](args = (%x,), kwargs = {})
%x_activation_post_process_0_equalization_process_0 : [#users=1] = call_module[target=x_activation_post_process_0_equalization_process_0](args = (%x_activation_post_process_0,), kwargs = {})
%conv : [#users=1] = call_module[target=conv](args = (%x_activation_post_process_0_equalization_process_0,), kwargs = {})
%conv_activation_post_process_0 : [#users=1] = call_module[target=conv_activation_post_process_0](args = (%conv,), kwargs = {})
return conv_activation_post_process_0
```
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: [D29557051](https://our.internmc.facebook.com/intern/diff/D29557051)
[ghstack-poisoned]
Summary: Modifies the prepare step to support conv layers during input-weight equalization and adds tests to make sure that the results are as expected.
Initial:
```
w
|
x -> conv -> y
```
After prepare:
```
w
|
weight_quant_obs
|
weight_eq_obs
|
x -> input_quant_obs -> input_eq_obs -> conv -> out_quant_obs -> y
```
Test Plan: `python test/test_quantization.py TestEqualizeFx.test_input_weight_equalization_prepare`
Initial:
```
ConvModel(
(conv): Conv2d(3, 5, kernel_size=(3, 3), stride=(1, 1), bias=False)
)
```
After prepare:
```
graph():
%x : [#users=1] = placeholder[target=x]
%x_activation_post_process_0 : [#users=1] = call_module[target=x_activation_post_process_0](args = (%x,), kwargs = {})
%x_activation_post_process_0_equalization_process_0 : [#users=1] = call_module[target=x_activation_post_process_0_equalization_process_0](args = (%x_activation_post_process_0,), kwargs = {})
%conv : [#users=1] = call_module[target=conv](args = (%x_activation_post_process_0_equalization_process_0,), kwargs = {})
%conv_activation_post_process_0 : [#users=1] = call_module[target=conv_activation_post_process_0](args = (%conv,), kwargs = {})
return conv_activation_post_process_0
```
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: [D29557051](https://our.internmc.facebook.com/intern/diff/D29557051)
[ghstack-poisoned]
|
@angelayi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 77d36b6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary: Modifies the prepare step to support conv layers during input-weight equalization and adds tests to make sure that the results are as expected.
Initial:
After prepare:
Test Plan:
python test/test_quantization.py TestEqualizeFx.test_input_weight_equalization_prepareInitial:
After prepare:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D29557051