Skip to content

Conversation

@stas00
Copy link
Contributor

@stas00 stas00 commented Jul 15, 2021

fix invalid instruction

fix invalid instruction
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 15, 2021

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 4a7626b (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@anjali411 anjali411 requested a review from malfet July 16, 2021 17:38
@anjali411 anjali411 added module: docs Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jul 16, 2021
@facebook-github-bot
Copy link
Contributor

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@malfet merged this pull request in 4e1d84a.

@Gamrix
Copy link
Contributor

Gamrix commented Aug 19, 2021

The old precommit instructions worked for my mac and devserver, whereas the new one doesn't. Have you checked that your new instructions actually work?

@malfet
Copy link
Contributor

malfet commented Aug 19, 2021

Hmm, you are right, reverting...

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by f2bf0f2.

@stas00
Copy link
Contributor Author

stas00 commented Aug 20, 2021

You're correct, @Gamrix - my "fix" was erroneous. I'm not quite sure why it worked for me in the first place. My apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged module: docs Related to our documentation, both in docs/ and docblocks open source Reverted triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants