[jit] Implement one-argument AliasDb::mayContainAlias more efficiently #65177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to heap-allocate any vectors in this case. Differential Revision: [D30984194](https://our.internmc.facebook.com/intern/diff/D30984194/) [ghstack-poisoned]
facebook-github-bot
added
oncall: jit
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit dbf237c (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Sep 16, 2021
eellison
approved these changes
Sep 17, 2021
… efficiently" There is no need to heap-allocate any vectors in this case. Differential Revision: [D30984194](https://our.internmc.facebook.com/intern/diff/D30984194/) [ghstack-poisoned]
This was referenced Sep 20, 2021
… efficiently" There is no need to heap-allocate any vectors in this case. Differential Revision: [D30984194](https://our.internmc.facebook.com/intern/diff/D30984194/) [ghstack-poisoned]
… efficiently" There is no need to heap-allocate any vectors in this case. Differential Revision: [D30984194](https://our.internmc.facebook.com/intern/diff/D30984194/) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
… efficiently" There is no need to heap-allocate any vectors in this case. Differential Revision: [D30984194](https://our.internmc.facebook.com/intern/diff/D30984194/) [ghstack-poisoned]
… efficiently" There is no need to heap-allocate any vectors in this case. Differential Revision: [D30984194](https://our.internmc.facebook.com/intern/diff/D30984194/) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
There is no need to heap-allocate any vectors in this case.
Differential Revision: D30984194