[jit] Refcounting spot fixes in alias_analysis #66295
Closed
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidying up the top sources of reference count decrements seen during static runtime startup in alias_analysis.cpp specifically. Differential Revision: [D31490761](https://our.internmc.facebook.com/intern/diff/D31490761/) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c212c36 (more details on the Dr. CI page):
3 failures not recognized by patterns:
❄️ 2 failures tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
This was referenced Oct 7, 2021
swolchok
added a commit
that referenced
this pull request
Oct 7, 2021
Tidying up the top sources of reference count decrements seen during static runtime startup in alias_analysis.cpp specifically. Differential Revision: [D31490761](https://our.internmc.facebook.com/intern/diff/D31490761/) ghstack-source-id: 140052519 Pull Request resolved: #66295
Tidying up the top sources of reference count decrements seen during static runtime startup in alias_analysis.cpp specifically. Differential Revision: [D31490761](https://our.internmc.facebook.com/intern/diff/D31490761/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Oct 8, 2021
Pull Request resolved: #66295 Tidying up the top sources of reference count decrements seen during static runtime startup in alias_analysis.cpp specifically. ghstack-source-id: 140157939 Differential Revision: [D31490761](https://our.internmc.facebook.com/intern/diff/D31490761/)
Tidying up the top sources of reference count decrements seen during static runtime startup in alias_analysis.cpp specifically. Differential Revision: [D31490761](https://our.internmc.facebook.com/intern/diff/D31490761/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Oct 13, 2021
Pull Request resolved: #66295 Tidying up the top sources of reference count decrements seen during static runtime startup in alias_analysis.cpp specifically. ghstack-source-id: 140484160 Differential Revision: [D31490761](https://our.internmc.facebook.com/intern/diff/D31490761/)
suo
approved these changes
Oct 13, 2021
wconstab
pushed a commit
that referenced
this pull request
Oct 20, 2021
Summary: Pull Request resolved: #66295 Tidying up the top sources of reference count decrements seen during static runtime startup in alias_analysis.cpp specifically. ghstack-source-id: 140484160 Test Plan: CI perf now shows under 2% time spend in ~__shared_count instead of about 5%. Reviewed By: suo Differential Revision: D31490761 fbshipit-source-id: bbdcb7f9065c3aafa7fff7bfea9cea6dbc41f9d9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Tidying up the top sources of reference count decrements seen during static runtime startup in alias_analysis.cpp specifically.
Differential Revision: D31490761