[PyTorch][SR] Force liveness analysis to get aliasing right #67222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit acf0c3b (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
facebook-github-bot
added
the
oncall: jit
This was referenced Oct 25, 2021
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
This was referenced Nov 2, 2021
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
This was referenced Nov 10, 2021
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
This was referenced Nov 10, 2021
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear. Differential Revision: [D31873504](https://our.internmc.facebook.com/intern/diff/D31873504/) [ghstack-poisoned]
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This is a brute force solution to aliasing issues in our liveness analysis. The comment in the code should explain sufficiently, so I'm not re-explaining here; please request changes if it's unclear.
Differential Revision: D31873504