[EASY] Adding virtual to the isUnionType op #69554
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Dec 7, 2021
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 5d425b6 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
[ghstack-poisoned]
[ghstack-poisoned]
|
Basically this function returns the wrong result if is not virtual. |
Gamrix
changed the title
|
@Gamrix has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Differential Revision: [D33750966](https://our.internmc.facebook.com/intern/diff/D33750966) [ghstack-poisoned]
|
@Gamrix has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Differential Revision: [D33750966](https://our.internmc.facebook.com/intern/diff/D33750966) [ghstack-poisoned]
|
@Gamrix has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 29, 2022
Summary: Pull Request resolved: #69554 Test Plan: Imported from OSS Reviewed By: mikaylagawarecki Differential Revision: D33750966 Pulled By: Gamrix fbshipit-source-id: d2da8138c72709e6d1359df638ac29ca9d0f1556
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#69554 Test Plan: Imported from OSS Reviewed By: mikaylagawarecki Differential Revision: D33750966 Pulled By: Gamrix fbshipit-source-id: d2da8138c72709e6d1359df638ac29ca9d0f1556 (cherry picked from commit 00f434e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 3, 2022
Summary: Pull Request resolved: pytorch/pytorch#69554 Test Plan: Imported from OSS Reviewed By: mikaylagawarecki Differential Revision: D33750966 Pulled By: Gamrix fbshipit-source-id: d2da8138c72709e6d1359df638ac29ca9d0f1556 (cherry picked from commit 00f434e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#69554 Test Plan: Imported from OSS Reviewed By: mikaylagawarecki Differential Revision: D33750966 Pulled By: Gamrix fbshipit-source-id: d2da8138c72709e6d1359df638ac29ca9d0f1556 (cherry picked from commit 00f434e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Pull Request resolved: pytorch/pytorch#69554 Test Plan: Imported from OSS Reviewed By: mikaylagawarecki Differential Revision: D33750966 Pulled By: Gamrix fbshipit-source-id: d2da8138c72709e6d1359df638ac29ca9d0f1556 (cherry picked from commit 00f434e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D33750966