Skip to content

switch DimensionNode's base from TsNode to Node #75916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

switch DimensionNode's base from TsNode to Node #75916

wants to merge 1 commit into from

Conversation

@Krovatkin
Copy link
Contributor

Switching the base of DimensionNode to TsNode so it can be reused by XLA and other backends.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 15, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 6daa8c4 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

alanwaketan
alanwaketan approved these changes Apr 15, 2022
View reviewed changes
Copy link
Collaborator

@alanwaketan alanwaketan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@facebook-github-bot
Copy link
Contributor

@Krovatkin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge this

(Initiating merge automatically since Phabricator Diff has merged)

@github-actions
Copy link
Contributor

Hey @Krovatkin.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Apr 16, 2022
@Krovatkin @facebook-github-bot
switch DimensionNode's base from TsNode to Node (#75916)
8bb88f0 
Summary:
Switching the base of DimensionNode to TsNode so it can be reused by XLA and other backends.

Pull Request resolved: #75916

Reviewed By: alanwaketan

Differential Revision: D35687764

Pulled By: Krovatkin

fbshipit-source-id: 509a1298b13ec51d9208c0157846f2a6b0388f11
@miladm miladm self-requested a review April 18, 2022 20:26
malfet pushed a commit that referenced this pull request Apr 20, 2022
@Krovatkin @malfet
switch DimensionNode's base from TsNode to Node
70793b9 
Switching the base of DimensionNode to TsNode so it can be reused by XLA and other backends.
Pull Request resolved: #75916
Approved by: https://github.com/alanwaketan

(cherry picked from commit 977a66f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alanwaketan alanwaketan alanwaketan approved these changes

@desertfire desertfire Awaiting requested review from desertfire

@shunting314 shunting314 Awaiting requested review from shunting314

@miladm miladm Awaiting requested review from miladm

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Krovatkin @facebook-github-bot @alanwaketan