Skip to content

switch DimensionNode's base from TsNode to Node #75916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

switch DimensionNode's base from TsNode to Node #75916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion torch/csrc/lazy/core/dynamic_ir.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ namespace torch {
namespace lazy {

DimensionNode::DimensionNode(OpKind op, OpList operands, hash_t hash_seed):
TsNode(op, operands, /*num_outputs=*/1,
Node(op, operands, /*num_outputs=*/1,
/* node_hash */ HashCombine(op.hash(), hash_seed)){}

std::string DimensionNode::ToString() const {
Expand Down
9 changes: 1 addition & 8 deletions torch/csrc/lazy/core/dynamic_ir.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,9 @@ namespace lazy {
* burned into the Graph.
*/

class TORCH_API DimensionNode : public lazy::TsNode {
class TORCH_API DimensionNode : public lazy::Node {
public:
DimensionNode(OpKind op, OpList operands, hash_t hash_seed = kHashSeed);

// N.B. Node doesn't have sizes() so we don't need to override it to
// throw an error

// TODO: Fix this when John lands input shape API. Change
// DimensionNode's `isDynamic` to a virtual method and implement the
// actual `isDynamic` in all DimensionNode subclasses
bool isDynamic() {
return false;
}
Expand Down