Conversation
Update Release.md with latest details and PRs reference
🔗 Helpful links
❌ 1 New FailuresAs of commit fb0c662 (more details on the Dr. CI page): Expand to see more
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
RELEASE.md
Outdated
| * A release branches should also be created in [`pytorch/xla`](https://github.com/pytorch/xla) and [`pytorch/builder`](https://github.com/pytorch/builder) repos and pinned in `pytorch/pytorch` | ||
| * Example PR (CircleCI, to be removed): https://github.com/pytorch/pytorch/pull/65433 | ||
| * Example PR (GHA): https://github.com/pytorch/pytorch/pull/72739 | ||
| * Example PRs (GHA): https://github.com/pytorch/pytorch/pull/77986 and https://github.com/pytorch/pytorch/pull/77986 |
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
Please capitalize PyTorch and also avoid specifying any time constraints, as they could change later
| * Perform a fresh clone of pytorch repo using | ||
| ```bash | ||
| git clone git@github.com:pytorch/pytorch.git | ||
| ``` |
There was a problem hiding this comment.
This sounds like an optional step, isn't it? Also, why are you recommending using ssh rather than https access? Later is faster, isn't it?
| * Perform a fresh clone of pytorch repo using | |
| ```bash | |
| git clone git@github.com:pytorch/pytorch.git | |
| ``` | |
| * Perform a fresh clone of pytorch repo using | |
| ```bash | |
| git clone https://github.com:pytorch/pytorch.git |
There was a problem hiding this comment.
-
Basically this step is required if you want to execute next step which is convenience script, which should be executed from the pytorch clone. Executing the script from fork does not work. Hence fresh clone, which also makes sure no other accidental changes are picked up during release.
-
I don't mind putting https here if it works well for next step, so far I have been always using ssh with keys setup for proper access. Main point here is that it must be pytorch/pytorch repo and not a fork.
There was a problem hiding this comment.
Sorry, I don't think I follow. What do you mean by:
which should be executed from the pytorch clone
If script does not work from forks, then perhaps we need to add note about it here and also add a check for it in the script.
There was a problem hiding this comment.
Yes, makes sense we should probably change the script to work from forks properly. The way I usually work is as follows:
(.venv) [atalman@devvm214.ftw0 ~/local/pytorch] git remote -v
origin git@github.com:atalman/pytorch.git (fetch)
origin git@github.com:atalman/pytorch.git (push)
upstream git@github.com:pytorch/pytorch.git (fetch)
upstream git@github.com:pytorch/pytorch.git (push)
The script by default assumes: GIT_REMOTE=${GIT_REMOTE:-origin} hence if I execute it from fork it will push it to atalman/pytorch.
Perhaps we should just avoid using the script since it creates unnecessary confusion, all it does:
set -x
git checkout "${GIT_REMOTE}/${GIT_BRANCH_TO_CUT_FROM}"
git checkout -b "${branch}"
git push "${GIT_REMOTE}" "${branch}"
Maybe just executing these command against correct origin or upstream will be cleaner ?
RELEASE.md
Outdated
| ``` | ||
|
|
||
| ### Making release branch specific changes | ||
| ### Making release branch specific changes for pytorch |
Co-authored-by: Nikita Shulga <nshulga@fb.com>
Co-authored-by: Nikita Shulga <nshulga@fb.com>
Co-authored-by: Nikita Shulga <nshulga@fb.com>
Co-authored-by: Nikita Shulga <nshulga@fb.com>
|
@pytorchmergebot merge this please |
|
Merge failed due to Refusing to merge as mandatory check(s)linux-xenial-py3.7-gcc5.4-mobile-lightweight-dispatch-build / build failed for rule superuser |
|
@pytorchmergebot merge this please |
|
Hey @atalman. |
Summary: Update Release.md with latest details and PRs reference Pull Request resolved: #78285 Approved by: https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/46b0306c134ecace85c43aae855d8066dfaf3025 Reviewed By: mehtanirav Differential Revision: D36708196 Pulled By: atalman fbshipit-source-id: 7ea1f1f20575e4afd377f437976e5a94e22cc315
5 participants
Update Release.md with latest details and PRs reference