Skip to content

reorder checks to shave 1 us off no-op dispatch time #78316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

reorder checks to shave 1 us off no-op dispatch time #78316

wants to merge 1 commit into from

Conversation

@zdevito
Copy link
Contributor

@zdevito zdevito commented May 25, 2022 •
edited
Loading

Measuring a 1 element torch.dot time goes from 9us to 8us.

topic: not user facing
release notes: cpp

Stack from ghstack (oldest at bottom):

@zdevito zdevito requested review from albanD and soulitzer as code owners May 25, 2022 23:03
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 25, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (3 Pending)

As of commit 1e31e6a (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

zdevito added a commit that referenced this pull request May 25, 2022
@zdevito
reorder checks to shave 1 us off no-op dispatch time
22463ca 
ghstack-source-id: 49f5e20
Pull Request resolved: #78316
Chillee
Chillee approved these changes May 25, 2022
View reviewed changes
Copy link
Collaborator

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

ezyang
ezyang approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ay caramba

@zdevito
Copy link
Contributor Author

zdevito commented May 26, 2022

@pytorchbot merge this on green

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2022

Hey @zdevito.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@zdevito
Copy link
Contributor Author

zdevito commented May 26, 2022

@pytorchbot merge this on green

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented May 26, 2022

Can't merge closed PR #78316

facebook-github-bot pushed a commit that referenced this pull request May 27, 2022
@zdevito @facebook-github-bot
reorder checks to shave 1 us off no-op dispatch time (#78316)
dde9e18 
Summary:
Pull Request resolved: #78316

Approved by: https://github.com/Chillee, https://github.com/ezyang

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/b6920405da340bbd3397b80bf16d9c360b0c48d2

Reviewed By: mehtanirav

Differential Revision: D36708667

Pulled By: zdevito

fbshipit-source-id: 5c21edb61debc4c7c039d79abefe45bdaee1ac62
@facebook-github-bot facebook-github-bot deleted the gh/zdevito/185/head branch May 29, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@Chillee Chillee Chillee approved these changes

@albanD albanD Awaiting requested review from albanD

@soulitzer soulitzer Awaiting requested review from soulitzer

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zdevito @facebook-github-bot @pytorchmergebot @ezyang @Chillee