[5] move XNNPACK to shared BUCK build #80209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

linbinyu wants to merge 1 commit into pytorch:master from linbinyu:export-D37407609

Contributor

linbinyu commented Jun 24, 2022

Summary: Reland D36529332 (b8b46f9) with shared buck build structure.

Test Plan:
buck build //xplat/third-party/XNNPACK:XNNPACK
Sandcastle

Differential Revision: D37407609

facebook-github-bot added the cla signed label

Contributor

facebook-github-bot commented Jun 24, 2022 •

edited

Loading

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/80209
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit 42276c3 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Jun 24, 2022

This pull request was exported from Phabricator. Differential Revision: D37407609

1 similar comment

Contributor

facebook-github-bot commented Jun 24, 2022

This pull request was exported from Phabricator. Differential Revision: D37407609

linbinyu force-pushed the export-D37407609 branch from 55b9ff3 to 122a807 Compare

June 24, 2022 17:34

linbinyu force-pushed the export-D37407609 branch from 122a807 to 3ab9943 Compare

June 24, 2022 17:53

Contributor

facebook-github-bot commented Jun 24, 2022

This pull request was exported from Phabricator. Differential Revision: D37407609

1 similar comment

Contributor

facebook-github-bot commented Jun 24, 2022

This pull request was exported from Phabricator. Differential Revision: D37407609

linbinyu added a commit to linbinyu/pytorch that referenced this pull request


          [5] move XNNPACK to shared BUCK build (pytorch#80209)

b8afb52

Summary:
Pull Request resolved: pytorch#80209

Reland D36529332 (pytorch@b8b46f9) with shared buck build structure.

Test Plan:
buck build //xplat/third-party/XNNPACK:XNNPACK
Sandcastle
Github CI

Differential Revision: D37407609

fbshipit-source-id: 85ba2512f61eaa1f61b9e024baab80fd6bbd6d42

linbinyu force-pushed the export-D37407609 branch from 3ab9943 to b8afb52 Compare

June 24, 2022 18:53

linbinyu added the ciflow/periodic label


          [5] move XNNPACK to shared BUCK build (pytorch#80209)

42276c3

Summary:
Pull Request resolved: pytorch#80209

Reland D36529332 (pytorch@b8b46f9) with shared buck build structure. The internal BUCK targets are copied from https://www.internalfb.com/code/fbsource/[ffb2d18962ba681caf95244335412b1b8458d3e6]/xplat/third-party/XNNPACK/BUCK and they should work exactly the same as before.

= Files used by internal BUCK build (//xplat/third-party/XNNPACK:XNNPACK)
fbsource/xplat/third-party/XNNPACK/BUCK
fbsource/xplat/third-party/XNNPACK/XNNPACK/ (source files)
fbsource/xplat/third-party/XNNPACK/xnnpack_wrappers (wrappers)
fbsource/xplat/caffe2/third_party/xnnpack.buck.bzl
fbsource/xplat/caffe2/third_party/xnnpack_src_defs.bzl
fbsource/xplat/caffe2/third_party/xnnpack_wrapper_defs.bzl

= Files used by OSS BUCK build (//third_party:XNNPACK in OSS repo)
pytorch/third_party/BUCK.oss
pytorch/third_party/XNNPACK/ (source files as submodule)
pytorch/third_party/xnnpack_wrappers (wrappers, generated on the fly)
pytorch/third_party/xnnpack.buck.bzl
pytorch/third_party/xnnpack_src_defs.bzl
pytorch/third_party/xnnpack_wrapper_defs.bzl

Test Plan:
buck build //xplat/third-party/XNNPACK:XNNPACK
Sandcastle
Github CI

Reviewed By: kimishpatel

Differential Revision: D37407609

fbshipit-source-id: 988895b20e19b52ef32a52a604aaad80bc7b9f67

Contributor

facebook-github-bot commented Jun 27, 2022

This pull request was exported from Phabricator. Differential Revision: D37407609

linbinyu force-pushed the export-D37407609 branch from b8afb52 to 42276c3 Compare

June 27, 2022 19:15

linbinyu requested review from kimishpatel and malfet

June 27, 2022 21:58

kimishpatel approved these changes

View reviewed changes

Contributor

facebook-github-bot commented Jun 28, 2022

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

Collaborator

pytorchmergebot commented Jun 28, 2022

@pytorchbot successfully started a merge job. Check the current status here

Collaborator

pytorchmergebot commented Jun 28, 2022

@linbinyu your PR has been successfully merged.

pytorchmergebot added the Merged label

pytorchmergebot closed this in

8a45ef2

Contributor

github-actions bot commented Jun 28, 2022

Hey @linbinyu.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request


          [5] move XNNPACK to shared BUCK build (#80209)

Summary:
Pull Request resolved: #80209

Reland D36529332 (b8b46f9) with shared buck build structure. The internal BUCK targets are copied from https://www.internalfb.com/code/fbsource/[ffb2d18962ba681caf95244335412b1b8458d3e6]/xplat/third-party/XNNPACK/BUCK and they should work exactly the same as before.

= Files used by internal BUCK build (//xplat/third-party/XNNPACK:XNNPACK)
fbsource/xplat/third-party/XNNPACK/BUCK
fbsource/xplat/third-party/XNNPACK/XNNPACK/ (source files)
fbsource/xplat/third-party/XNNPACK/xnnpack_wrappers (wrappers)
fbsource/xplat/caffe2/third_party/xnnpack.buck.bzl
fbsource/xplat/caffe2/third_party/xnnpack_src_defs.bzl
fbsource/xplat/caffe2/third_party/xnnpack_wrapper_defs.bzl

= Files used by OSS BUCK build (//third_party:XNNPACK in OSS repo)
pytorch/third_party/BUCK.oss
pytorch/third_party/XNNPACK/ (source files as submodule)
pytorch/third_party/xnnpack_wrappers (wrappers, generated on the fly)
pytorch/third_party/xnnpack.buck.bzl
pytorch/third_party/xnnpack_src_defs.bzl
pytorch/third_party/xnnpack_wrapper_defs.bzl

Test Plan:
buck build //xplat/third-party/XNNPACK:XNNPACK
Sandcastle
Github CI

Reviewed By: kimishpatel

Differential Revision: D37407609

fbshipit-source-id: f491cd36dd382c7743a1f94b8bae67da5972572d

digantdesai mentioned this pull request

[XNNPACK] Generate new build and wrapper files #94230

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/periodic cla signed fb-exported Merged