[functorch] in-place jvp testing #83077
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing code is starting to trend toward entropy. Not sure if the in-place tests are actually "necessary" but better safe than sorry. Test Plan: - run tests [ghstack-poisoned]
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 896da47 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Testing code is starting to trend toward entropy. Not sure if the in-place tests are actually "necessary" but better safe than sorry. Test Plan: - run tests [ghstack-poisoned]
Testing code is starting to trend toward entropy. Not sure if the in-place tests are actually "necessary" but better safe than sorry. Test Plan: - run tests [ghstack-poisoned]
Testing code is starting to trend toward entropy. Not sure if the in-place tests are actually "necessary" but better safe than sorry. Test Plan: - run tests [ghstack-poisoned]
Testing code is starting to trend toward entropy. Not sure if the in-place tests are actually "necessary" but better safe than sorry. Test Plan: - run tests [ghstack-poisoned]
This was referenced Aug 9, 2022
Testing code is starting to trend toward entropy. Not sure if the in-place tests are actually "necessary" but better safe than sorry. Test Plan: - run tests [ghstack-poisoned]
Testing code is starting to trend toward entropy. Not sure if the in-place tests are actually "necessary" but better safe than sorry. Test Plan: - run tests [ghstack-poisoned]
This was referenced Aug 9, 2022
Chillee
approved these changes
Aug 11, 2022
facebook-github-bot
pushed a commit
to pytorch/functorch
that referenced
this pull request
Aug 11, 2022
Summary: Testing code is starting to trend toward entropy. Not sure if the in-place tests are actually "necessary" but better safe than sorry. X-link: pytorch/pytorch#83077 Approved by: https://github.com/Chillee Reviewed By: seemethere Differential Revision: D38624154 Pulled By: zou3519 fbshipit-source-id: 2a799e651b5462809384ae920d42d73a71fdd369
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
Summary: Testing code is starting to trend toward entropy. Not sure if the in-place tests are actually "necessary" but better safe than sorry. Pull Request resolved: #83077 Approved by: https://github.com/Chillee Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/3dc402fd1eae13839ac5a5aa22aab3017c3fc961 Test plan from GitHub: - run tests Reviewed By: seemethere Differential Revision: D38624154 Pulled By: zou3519 fbshipit-source-id: 2a799e651b5462809384ae920d42d73a71fdd369
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Testing code is starting to trend toward entropy.
Not sure if the in-place tests are actually "necessary" but better safe
than sorry.
Test Plan: