[functorch] Add some more view+inplace grad+vmap tests #83176
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyTorch autograd turns view+inplace into some sequence of as_strided and a special CopySlices node. This PR: - adds a test for that (`test_inplace_on_view`) - modifies some other testing that also tests this behavior (`test_inplace_view`, `test_inplace_manyview`) to also test non-contiguous inputs. Test Plan: - wait for tests [ghstack-poisoned]
This was referenced Aug 10, 2022
This was referenced Aug 10, 2022
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 0e233bc (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
zou3519
added a commit
that referenced
this pull request
Aug 10, 2022
PyTorch autograd turns view+inplace into some sequence of as_strided and a special CopySlices node. This PR: - adds a test for that (`test_inplace_on_view`) - modifies some other testing that also tests this behavior (`test_inplace_view`, `test_inplace_manyview`) to also test non-contiguous inputs. Test Plan: - wait for tests ghstack-source-id: 9fbc0c6 Pull Request resolved: #83176
Chillee
approved these changes
Aug 11, 2022
|
@pytorchbot merge -f "flaky failures in middle of stack" |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Hey @zou3519. |
facebook-github-bot
pushed a commit
to pytorch/functorch
that referenced
this pull request
Aug 11, 2022
Summary: PyTorch autograd turns view+inplace into some sequence of as_strided and a special CopySlices node. This PR: - adds a test for that (`test_inplace_on_view`) - modifies some other testing that also tests this behavior (`test_inplace_view`, `test_inplace_manyview`) to also test non-contiguous inputs. X-link: pytorch/pytorch#83176 Approved by: https://github.com/Chillee Reviewed By: seemethere Differential Revision: D38624204 Pulled By: zou3519 fbshipit-source-id: d88ad5085973a2b49bb0a8ac8ff11b9ba1dc0b49
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
Summary: PyTorch autograd turns view+inplace into some sequence of as_strided and a special CopySlices node. This PR: - adds a test for that (`test_inplace_on_view`) - modifies some other testing that also tests this behavior (`test_inplace_view`, `test_inplace_manyview`) to also test non-contiguous inputs. Pull Request resolved: #83176 Approved by: https://github.com/Chillee Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/fa54021a0c91258c781c5073b672cb542ea609b0 Test plan from GitHub: - wait for tests Reviewed By: seemethere Differential Revision: D38624204 Pulled By: zou3519 fbshipit-source-id: d88ad5085973a2b49bb0a8ac8ff11b9ba1dc0b49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
PyTorch autograd turns view+inplace into some sequence of as_strided and
a special CopySlices node. This PR:
test_inplace_on_view)(
test_inplace_view,test_inplace_manyview) to also testnon-contiguous inputs.
Test Plan: