Fix `tensor.stride()` type hint #84177

soof-golan · 2022-08-28T09:04:47Z

tensor.stride() now hints at tuple of variable length instead of tuple with constant length of 1

facebook-github-bot · 2022-08-28T09:04:52Z

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot · 2022-08-28T09:04:54Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84177
✖️ Python docs build was skipped
✖️ C++ docs build was skipped
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit 35f0bf6a53 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot · 2022-08-28T11:06:17Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Chillee

LGTM!

Chillee · 2022-09-16T21:35:00Z

@pytorchbot merge

pytorchmergebot · 2022-09-16T21:36:19Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot · 2022-09-16T21:36:20Z

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again.

Details for Dev Infra team

Raised by workflow job

Chillee · 2022-09-16T21:36:39Z

@pytorchbot rebase

Chillee · 2022-09-16T21:36:49Z

@pytorchbot merge -g

pytorchmergebot · 2022-09-16T21:38:23Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot · 2022-09-16T21:38:23Z

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again.

Details for Dev Infra team

Raised by workflow job

pytorchmergebot · 2022-09-16T21:38:48Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-09-16T21:38:55Z

Successfully rebased master onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout master && git pull --rebase)

pytorch-bot · 2022-09-16T21:39:00Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84177

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3d7bd8d:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Chillee · 2022-09-16T22:59:59Z

@pytorchbot merge -g

pytorchmergebot · 2022-09-16T23:03:06Z

Merge failed

Reason: The following mandatory check(s) are pending/not yet run (Rule superuser):

Facebook CLA Check

Dig deeper by viewing the pending checks on hud

Details for Dev Infra team

Raised by workflow job

facebook-github-bot · 2022-10-04T00:32:05Z

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

linux-foundation-easycla · 2022-10-04T00:32:08Z

The committers listed above are authorized under a signed CLA.

✅ login: soof-golan / name: Soof Golan (18841fe, b866ffd, b27c90c)

kit1980 · 2022-10-25T01:40:11Z

@pytorchbot rebase

pytorchmergebot · 2022-10-25T02:25:40Z

@pytorchbot successfully started a rebase job. Check the current status here

`tensor.stride()` now hints at tuple of variable length instead of tuple with constant length of 1

pytorchmergebot · 2022-10-25T02:25:44Z

Successfully rebased master onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout master && git pull --rebase)

kit1980 · 2022-10-25T02:30:40Z

@pytorchbot merge

pytorchmergebot · 2022-10-25T02:32:26Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

github-actions · 2022-10-25T04:43:44Z

Hey @soof-golan.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

`tensor.stride()` now hints at tuple of variable length instead of tuple with constant length of 1 Fixes pytorch#84176 Pull Request resolved: pytorch#84177 Approved by: https://github.com/Chillee

pytorchbot added the open source label Aug 28, 2022

facebook-github-bot added the cla signed label Aug 28, 2022

Chillee approved these changes Aug 29, 2022

View reviewed changes

soof-golan requested a review from Chillee September 2, 2022 10:40

Chillee approved these changes Sep 16, 2022

View reviewed changes

pytorchmergebot force-pushed the master branch from 35f0bf6 to b27c90c Compare September 16, 2022 21:38

soof-golan added 3 commits October 25, 2022 02:25

Fix tensor.stride() type hint

33600d4

`tensor.stride()` now hints at tuple of variable length instead of tuple with constant length of 1

Fix stride type hints in shape_props.py

d618aa3

Ignore assignment type

3d7bd8d

pytorchmergebot force-pushed the master branch from b27c90c to 3d7bd8d Compare October 25, 2022 02:25

pytorchmergebot added the Merged label Oct 25, 2022

pytorchmergebot closed this in 874a94c Oct 25, 2022

Fix tensor.stride() type hint #84177

Fix tensor.stride() type hint #84177

Uh oh!

Conversation

soof-golan commented Aug 28, 2022

Uh oh!

facebook-github-bot commented Aug 28, 2022

Action Required

Process

Uh oh!

facebook-github-bot commented Aug 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

✅ No Failures (0 Pending)

Uh oh!

facebook-github-bot commented Aug 28, 2022

Uh oh!

Chillee left a comment

Choose a reason for hiding this comment

Uh oh!

Chillee commented Sep 16, 2022

Uh oh!

pytorchmergebot commented Sep 16, 2022

Uh oh!

pytorchmergebot commented Sep 16, 2022

Merge failed

Uh oh!

Chillee commented Sep 16, 2022

Uh oh!

Chillee commented Sep 16, 2022

Uh oh!

pytorchmergebot commented Sep 16, 2022

Uh oh!

pytorchmergebot commented Sep 16, 2022

Merge failed

Uh oh!

pytorchmergebot commented Sep 16, 2022

Uh oh!

pytorchmergebot commented Sep 16, 2022

Uh oh!

pytorch-bot bot commented Sep 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84177

✅ No Failures

Uh oh!

Chillee commented Sep 16, 2022

Uh oh!

pytorchmergebot commented Sep 16, 2022

Merge failed

Uh oh!

facebook-github-bot commented Oct 4, 2022

Uh oh!

linux-foundation-easycla bot commented Oct 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kit1980 commented Oct 25, 2022

Uh oh!

pytorchmergebot commented Oct 25, 2022

Uh oh!

pytorchmergebot commented Oct 25, 2022

Uh oh!

kit1980 commented Oct 25, 2022

Uh oh!

pytorchmergebot commented Oct 25, 2022

Merge started

Uh oh!

github-actions bot commented Oct 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Fix `tensor.stride()` type hint #84177

Fix `tensor.stride()` type hint #84177

facebook-github-bot commented Aug 28, 2022 •

edited

Loading

pytorch-bot bot commented Sep 16, 2022 •

edited

Loading

linux-foundation-easycla bot commented Oct 4, 2022 •

edited

Loading