Skip to content

Fix tensor.stride() type hint #84177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix tensor.stride() type hint #84177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33600d4
Fix `tensor.stride()` type hint
soof-golan Aug 28, 2022
d618aa3
Fix stride type hints in shape_props.py
soof-golan Aug 29, 2022
3d7bd8d
Ignore assignment type
soof-golan Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/pyi/gen_pyi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ def gen_pyi(
"def size(self, dim: _int) -> _int: ...",
],
"stride": [
"def stride(self) -> Tuple[_int]: ...",
"def stride(self) -> Tuple[_int, ...]: ...",
"def stride(self, _int) -> _int: ...",
],
"new_ones": [
Expand Down
2 changes: 1 addition & 1 deletion torch/_prims/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1273,7 +1273,7 @@ def _collapse_view_helper(
strides = (1,)
else:
shape = a.shape # type: ignore[assignment]
strides = a.stride()
strides = a.stride() # type: ignore[assignment]

utils.validate_idx(len(shape), start)
utils.validate_exclusive_idx(len(shape), end)
Expand Down
2 changes: 1 addition & 1 deletion torch/fx/passes/shape_prop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class TensorMetadata(NamedTuple):
shape : torch.Size
dtype : torch.dtype
requires_grad : bool
stride : Tuple[int]
stride : Tuple[int, ...]
memory_format : Optional[torch.memory_format]

# Quantization metadata
Expand Down