Skip to content

Enable manual test config label selection on Windows #84669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Enable manual test config label selection on Windows #84669

wants to merge 2 commits into from

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Sep 7, 2022

After #83690, functorch team has started using the new label in some of their PRs. So this enabled the same feature on Windows.

Issues

#82367

@huydhn huydhn added the test-config/functorch Use this label to run only functorch tests label Sep 7, 2022
@huydhn huydhn requested a review from ZainRizvi September 7, 2022 22:34
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 7, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84669

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 335de21:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Sep 7, 2022
@huydhn huydhn added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Sep 7, 2022
@huydhn huydhn self-assigned this Sep 7, 2022
@huydhn huydhn marked this pull request as ready for review September 7, 2022 23:00
@huydhn huydhn requested a review from a team as a code owner September 7, 2022 23:00
ZainRizvi
ZainRizvi reviewed Sep 8, 2022
View reviewed changes
Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test this? Unless I'm misreading the data, looking at HUD it doesn't look like much was filtered out.

https://hud.pytorch.org/pr/84669

@huydhn
Copy link
Contributor Author

huydhn commented Sep 8, 2022 •
edited
Loading

How did you test this? Unless I'm misreading the data, looking at HUD it doesn't look like much was filtered out.

https://hud.pytorch.org/pr/84669

The CI run itself is the test. There are only functorch-related build and tests for Windows (and Linux) in HUD. You can also verify it using GitHub summary view https://github.com/pytorch/pytorch/actions/runs/3012171625 to see which tests are skipped and which are run. The latter is a bit easier IMO.

Windows build and test would still happen because it has functorch there. Only those Windows default test-config shards are filtered out, so may be that's the reason you still see almost the same steps on HUD

@huydhn huydhn requested a review from ZainRizvi September 8, 2022 17:24
@huydhn
Copy link
Contributor Author

huydhn commented Sep 8, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Hey @huydhn.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Sep 9, 2022
@huydhn @facebook-github-bot
Enable manual test config label selection on Windows (#84669) (#84669)
512d61a 
Summary:
After #83690, functorch team has started using the new label in some of their [PRs](https://github.com/pytorch/pytorch/labels/test-config%2Ffunctorch).  So this enabled the same feature on Windows.

### Issues
#82367

Pull Request resolved: #84669
Approved by: https://github.com/ZainRizvi

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/fe353e1413e2262993fb71dba7317f21bc6fc3bc

Reviewed By: izaitsevfb

Differential Revision: D39386410

Pulled By: izaitsevfb

fbshipit-source-id: d1eb0a751c140d7048998d6b7c59cae132cc9c7d
@huydhn huydhn deleted the manual-test-selection-windows branch September 12, 2022 22:17
@huydhn huydhn mentioned this pull request Sep 12, 2022
Closed
pytorchmergebot pushed a commit that referenced this pull request Sep 14, 2022
@huydhn @pytorchmergebot
Enable manual test config label selection on GHA macos (#84895)
7b64c88 
Following up with #83690 and #84669, functorch team has started using the new label in some of their [PRs](https://github.com/pytorch/pytorch/labels/test-config%2Ffunctorch).  This is to enable manual test config using label on GHA macos.

This also works with `ciflow/mps` as follows:

* If only `test-config/functorch` is present, no arm64 build is performed and mps test is skipped
* If only `ciflow/mps` is present, mps test is run in addition to all other tests
* If both `test-config/functorch` and `ciflow/mps` is present, both functorch and mps tests are run
* If none of the label is present, pull workflow is run as usual

### Issues
#82367

Pull Request resolved: #84895
Approved by: https://github.com/ZainRizvi
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@huydhn @mehtanirav
Enable manual test config label selection on GHA macos (#84895)
562065c 
Following up with #83690 and #84669, functorch team has started using the new label in some of their [PRs](https://github.com/pytorch/pytorch/labels/test-config%2Ffunctorch).  This is to enable manual test config using label on GHA macos.

This also works with `ciflow/mps` as follows:

* If only `test-config/functorch` is present, no arm64 build is performed and mps test is skipped
* If only `ciflow/mps` is present, mps test is run in addition to all other tests
* If both `test-config/functorch` and `ciflow/mps` is present, both functorch and mps tests are run
* If none of the label is present, pull workflow is run as usual

### Issues
#82367

Pull Request resolved: #84895
Approved by: https://github.com/ZainRizvi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZainRizvi ZainRizvi ZainRizvi approved these changes

Assignees

@huydhn huydhn

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged release notes: releng release notes category test-config/functorch Use this label to run only functorch tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@huydhn @pytorchmergebot @ZainRizvi @facebook-github-bot