Skip to content

Enable manual test config label selection on GHA macos #84895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Enable manual test config label selection on GHA macos #84895

wants to merge 5 commits into from

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Sep 12, 2022 •
edited
Loading

Following up with #83690 and #84669, functorch team has started using the new label in some of their PRs. This is to enable manual test config using label on GHA macos.

This also works with ciflow/mps as follows:

  • If only test-config/functorch is present, no arm64 build is performed and mps test is skipped
  • If only ciflow/mps is present, mps test is run in addition to all other tests
  • If both test-config/functorch and ciflow/mps is present, both functorch and mps tests are run
  • If none of the label is present, pull workflow is run as usual

Issues

#82367

@huydhn huydhn added ciflow/trunk Trigger trunk jobs on your pull request ciflow/mps Run MPS tests (subset of trunk) test-config/functorch Use this label to run only functorch tests labels Sep 12, 2022
@huydhn huydhn requested a review from ZainRizvi September 12, 2022 22:32
@huydhn huydhn self-assigned this Sep 12, 2022
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 12, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 12, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84895

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 1 Pending

As of commit 61cb0b1:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn huydhn marked this pull request as ready for review September 12, 2022 23:31
@huydhn huydhn requested a review from a team as a code owner September 12, 2022 23:31
ZainRizvi
ZainRizvi reviewed Sep 13, 2022
View reviewed changes
Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine generally. A few Q's I'd like to better understand first though before signing off

@huydhn huydhn requested a review from ZainRizvi September 13, 2022 20:39
@huydhn huydhn marked this pull request as draft September 14, 2022 18:21
@huydhn huydhn marked this pull request as ready for review September 14, 2022 21:40
ZainRizvi
ZainRizvi approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@ZainRizvi
Copy link
Contributor

Just one request: Could you clarify why this change was needed in the PR description?

The current wording doesn't explain why an MPS specific change was needed

@huydhn
Copy link
Contributor Author

huydhn commented Sep 14, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@huydhn huydhn deleted the manual-test-selection-mac branch September 26, 2022 21:58
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@huydhn @mehtanirav
Enable manual test config label selection on GHA macos (#84895)
562065c 
Following up with #83690 and #84669, functorch team has started using the new label in some of their [PRs](https://github.com/pytorch/pytorch/labels/test-config%2Ffunctorch).  This is to enable manual test config using label on GHA macos.

This also works with `ciflow/mps` as follows:

* If only `test-config/functorch` is present, no arm64 build is performed and mps test is skipped
* If only `ciflow/mps` is present, mps test is run in addition to all other tests
* If both `test-config/functorch` and `ciflow/mps` is present, both functorch and mps tests are run
* If none of the label is present, pull workflow is run as usual

### Issues
#82367

Pull Request resolved: #84895
Approved by: https://github.com/ZainRizvi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZainRizvi ZainRizvi ZainRizvi approved these changes

Assignees

@huydhn huydhn

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged test-config/functorch Use this label to run only functorch tests topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@huydhn @ZainRizvi @pytorchmergebot @facebook-github-bot