Skip to content

Fix: prefer .is_none() over .is(py::none()) for pybind11 #88051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix: prefer .is_none() over .is(py::none()) for pybind11 #88051

wants to merge 1 commit into from

Conversation

Skylion007
Copy link
Collaborator

Fixes minor perf regression I saw in #85688 and replaced throughout the code base. obj == Py_None is directly equivalent to is_none(). Constructing a temporary py::none() object needlessly incref/decref the refcount of py::none, this method avoids that and therefore is more efficient.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 30, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88051

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 3 Pending

As of commit 2a49fd5:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Oct 30, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 30, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Skylion007 / name: Aaron Gokaslan (2a49fd5)

albanD
albanD approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 31, 2022
@albanD
Copy link
Collaborator

albanD commented Oct 31, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

Hey @Skylion007.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@Skylion007 Skylion007 mentioned this pull request Nov 1, 2022
Closed
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@Skylion007 @kulinseth
Fix: prefer .is_none() over .is(py::none()) for pybind11 (pytorch#88051)
7fa8368 
Fixes minor perf regression I saw in pytorch#85688 and replaced throughout the code base. `obj == Py_None` is directly equivalent to is_none(). Constructing a temporary py::none() object needlessly incref/decref the refcount of py::none, this method avoids that and therefore is more efficient.
Pull Request resolved: pytorch#88051
Approved by: https://github.com/albanD
pytorchmergebot pushed a commit that referenced this pull request Nov 17, 2022
@Skylion007 @pytorchmergebot
Fix: prefer .is_none() over .is(py::none()) for pybind11 in caffe2 (#…
54fca6a 
…88199)

Follow up to #88051 . I noticed that I missed a few spots in the caffe2 folder. Prefer `.is_none()` over `.is(py::none())` as `.is_none()` is more efficient since it avoid reference counting increments and decrements.
Pull Request resolved: #88199
Approved by: https://github.com/albanD, https://github.com/kit1980
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@Skylion007 @kulinseth
Fix: prefer .is_none() over .is(py::none()) for pybind11 (pytorch#88051)
f25d72f 
Fixes minor perf regression I saw in pytorch#85688 and replaced throughout the code base. `obj == Py_None` is directly equivalent to is_none(). Constructing a temporary py::none() object needlessly incref/decref the refcount of py::none, this method avoids that and therefore is more efficient.
Pull Request resolved: pytorch#88051
Approved by: https://github.com/albanD
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@Skylion007 @kulinseth
Fix: prefer .is_none() over .is(py::none()) for pybind11 in caffe2 (p…
81930f6 
…ytorch#88199)

Follow up to pytorch#88051 . I noticed that I missed a few spots in the caffe2 folder. Prefer `.is_none()` over `.is(py::none())` as `.is_none()` is more efficient since it avoid reference counting increments and decrements.
Pull Request resolved: pytorch#88199
Approved by: https://github.com/albanD, https://github.com/kit1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@soulitzer soulitzer Awaiting requested review from soulitzer

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: jit release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Skylion007 @albanD @pytorchmergebot @pytorchbot