-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Update notification mechansim for label CI checks #92225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notification mechansim for label CI checks #92225
Conversation
CI check_labels won't fail but leaving a comment, fail merge attempt instead.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92225
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8b4d31e: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good! It just needs a couple more things:
- Could you please add unit tests in
.github/scripts/test_trymerge.py
- We'll also want to remove the check_labels.py and move the corresponding unit tests from
.github/workflows/check-labels.yml
totest_trymerge.py
- Remove the .github/workflows/check-labels.yml workflow
Your call on whether you'd like to do #2 & #3 as part of this PR or as a separate PR
Thanks @ZainRizvi for the prompt review and suggestions! The original issue description suggested to keep the |
Actually, thinking it over again I'd prefer the approach described in the ticket where the label message is still shared with devs earlier, but it doesn't turn into a red X failing the CI. Would you mind putting it back in that format? Apologies for the churn |
Ah that makes sense, sure thing, I will add the |
Fixes #88098 ### What Changed * Moved `check_label.py` logic into `trymerge.py` * Refactored relevant unittests * ~~Dropped~~ Refactored `check_label.py` ci job ### Tests `python .github/scripts/test_trymerge.py` `python .github/scripts/test_check_labels.py` `make lint & lintrunner -a` ### Notes to reviewers This PR replaces the [original PR](#92225) to workaround the sticky EasyCLA failure mark on its first commit. Pull Request resolved: #92309 Approved by: https://github.com/ZainRizvi
Fixes #88098
What Changed:
Check_labels
CI job no longer fails, but only adding a comment prompt if the required labels is not satisfied.