Skip to content

Report suppressed exception in minifier #93368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Report suppressed exception in minifier #93368

wants to merge 1 commit into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Jan 31, 2023 •
edited by pytorch-bot bot
Loading

Stack from ghstack (oldest at bottom):

Suppressing exceptions is bad! If you're debugging PyTorch itself
you want to see the exception so you can do something about it.

Signed-off-by: Edward Z. Yang ezyang@meta.com

cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire

@ezyang
Report suppressed exception in minifier
18706f5 
Suppressing exceptions is bad!  If you're debugging PyTorch itself
you want to see the exception so you can do something about it.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 31, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93368

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 18706f5:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Jan 31, 2023
@ezyang
Report suppressed exception in minifier
7d592ee 
Suppressing exceptions is bad!  If you're debugging PyTorch itself
you want to see the exception so you can do something about it.

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 667715b
Pull Request resolved: #93368
@ezyang ezyang added ciflow/trunk Trigger trunk jobs on your pull request topic: bug fixes topic category topic: developer feature release notes: dynamo labels Jan 31, 2023
@ezyang ezyang requested a review from bertmaher January 31, 2023 15:18
@ezyang
Copy link
Contributor Author

ezyang commented Jan 31, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@albanD albanD removed their request for review January 31, 2023 16:13
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cuda11.6-py3 / test (default, 3, 5, windows.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author

ezyang commented Jan 31, 2023

@pytorchbot merge -f "unrelated master problems"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1759/head branch June 8, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@mlazos mlazos mlazos approved these changes

@bdhirsh bdhirsh bdhirsh approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@Chillee Chillee Awaiting requested review from Chillee

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

@bertmaher bertmaher Awaiting requested review from bertmaher

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo release notes: dynamo topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ezyang @pytorchmergebot @Skylion007 @mlazos @bdhirsh