Skip to content

Conversation

@co63oc
Copy link
Contributor

@co63oc co63oc commented Mar 4, 2023

Fix a typo in Exceptions.cpp

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 4, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96031

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 93407c8:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Skylion007 Skylion007 added the topic: not user facing topic category label Mar 4, 2023
@co63oc
Copy link
Contributor Author

co63oc commented Mar 9, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 9, 2023
@kit1980
Copy link
Contributor

kit1980 commented Mar 13, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased patch-8 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout patch-8 && git pull --rebase)

@kit1980
Copy link
Contributor

kit1980 commented Mar 13, 2023

@co63oc thank you for fixing typos in this and other PRs.
I'm merging your PRs that wasn't merged 5 days ago because of an outage.

But in future, it would be better if you can combine fixes in several files into one PR.
Too many tiny simple PRs create unnecessary load for the CI infrastructure.

@kit1980
Copy link
Contributor

kit1980 commented Mar 13, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@co63oc
Copy link
Contributor Author

co63oc commented Mar 14, 2023

@co63oc thank you for fixing typos in this and other PRs. I'm merging your PRs that wasn't merged 5 days ago because of an outage.

But in future, it would be better if you can combine fixes in several files into one PR. Too many tiny simple PRs create unnecessary load for the CI infrastructure.

Thank you, then I know

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 23, 2023
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants