Retry download and install NDK when testing Android #97067
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97067
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 25fe1e3: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
approved these changes
Mar 21, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m 'Need to rework this a bit as sdkmanager does not correctly treat a failed download as failure (surprise) https://github.com/pytorch/pytorch/actions/runs/4495666042/jobs/7909537961' -c weird Looking at the error, I could check for the existence of |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@huydhn your PR has been successfully reverted. |
pytorchmergebot
added a commit
that referenced
this pull request
Mar 23, 2023
This reverts commit d9b289b. Reverted #97067 on behalf of https://github.com/huydhn due to Need to rework this a bit as sdkmanager does not correctly treat a failed download as failure (surprise) https://github.com/pytorch/pytorch/actions/runs/4495666042/jobs/7909537961
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 23, 2023
As this step uses network to download and install NDK, it could fail flakily, i.e. https://github.com/pytorch/pytorch/actions/runs/4452757793/jobs/7820701670. So I'm adding retrying to the workflow. I could try figure out a way to Dockerize this, but not sure yet how to handle the GitHub action `reactivecircus/android-emulator-runner@v2` in Docker. So let's opt for the easy fix of retrying. Pull Request resolved: pytorch/pytorch#97067 Approved by: https://github.com/malfet
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 23, 2023
This reverts commit d9b289b. Reverted pytorch/pytorch#97067 on behalf of https://github.com/huydhn due to Need to rework this a bit as sdkmanager does not correctly treat a failed download as failure (surprise) https://github.com/pytorch/pytorch/actions/runs/4495666042/jobs/7909537961
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 23, 2023
As this step uses network to download and install NDK, it could fail flakily, i.e. https://github.com/pytorch/pytorch/actions/runs/4452757793/jobs/7820701670. So I'm adding retrying to the workflow. I could try figure out a way to Dockerize this, but not sure yet how to handle the GitHub action `reactivecircus/android-emulator-runner@v2` in Docker. So let's opt for the easy fix of retrying. Pull Request resolved: pytorch/pytorch#97067 Approved by: https://github.com/malfet
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 27, 2023
As this step uses network to download and install NDK, it could fail flakily, i.e. https://github.com/pytorch/pytorch/actions/runs/4452757793/jobs/7820701670. So I'm adding retrying to the workflow. I could try figure out a way to Dockerize this, but not sure yet how to handle the GitHub action `reactivecircus/android-emulator-runner@v2` in Docker. So let's opt for the easy fix of retrying. Pull Request resolved: pytorch/pytorch#97067 Approved by: https://github.com/malfet
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 27, 2023
This reverts commit d9b289b. Reverted pytorch/pytorch#97067 on behalf of https://github.com/huydhn due to Need to rework this a bit as sdkmanager does not correctly treat a failed download as failure (surprise) https://github.com/pytorch/pytorch/actions/runs/4495666042/jobs/7909537961
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 27, 2023
As this step uses network to download and install NDK, it could fail flakily, i.e. https://github.com/pytorch/pytorch/actions/runs/4452757793/jobs/7820701670. So I'm adding retrying to the workflow. I could try figure out a way to Dockerize this, but not sure yet how to handle the GitHub action `reactivecircus/android-emulator-runner@v2` in Docker. So let's opt for the easy fix of retrying. Pull Request resolved: pytorch/pytorch#97067 Approved by: https://github.com/malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this step uses network to download and install NDK, it could fail flakily, i.e. https://github.com/pytorch/pytorch/actions/runs/4452757793/jobs/7820701670. So I'm adding retrying to the workflow.
I could try figure out a way to Dockerize this, but not sure yet how to handle the GitHub action
reactivecircus/android-emulator-runner@v2in Docker. So let's opt for the easy fix of retrying.