introduce TensorIterator::unsafe_replace_input() #98162
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)! [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98162
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 011c95a: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 2, 2023
TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Apr 2, 2023
Pull Request resolved: #98162 TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. ghstack-source-id: 184800801 Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)!
TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)! [ghstack-poisoned]
TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Apr 2, 2023
Pull Request resolved: #98162 TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. ghstack-source-id: 184801135 Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)!
TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Apr 5, 2023
Pull Request resolved: #98162 TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. ghstack-source-id: 184801135 Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)!
TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)! [ghstack-poisoned]
TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Apr 8, 2023
Pull Request resolved: #98162 TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. ghstack-source-id: 184801135 Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)!
TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)! [ghstack-poisoned]
This was referenced Apr 10, 2023
TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)! [ghstack-poisoned]
added 2 commits
April 10, 2023 05:22
TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)! [ghstack-poisoned]
TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)! [ghstack-poisoned]
This was referenced Apr 10, 2023
added 5 commits
April 11, 2023 09:22
TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)! [ghstack-poisoned]
TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)! [ghstack-poisoned]
TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)! [ghstack-poisoned]
TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)! [ghstack-poisoned]
TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Apr 12, 2023
Pull Request resolved: #98162 TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. ghstack-source-id: 185825396 Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)!
TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Apr 13, 2023
Pull Request resolved: #98162 TensorIterator::unsafe_replace_operand() generically supports replacing an input or an output. In the future, we want to be very cautious about distinguishing reads and writes, so we want our APIs to be equally expressive. ghstack-source-id: 185940125 Differential Revision: [D44611380](https://our.internmc.facebook.com/intern/diff/D44611380/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44611380/)!
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
TensorIterator::unsafe_replace_operand() generically supports
replacing an input or an output. In the future, we want to be very
cautious about distinguishing reads and writes, so we want our APIs to
be equally expressive.
Differential Revision: D44611380
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!