Skip to content

[BE] Update flake8-comprehensions and adapt to rule C418 #99178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[BE] Update flake8-comprehensions and adapt to rule C418 #99178

wants to merge 1 commit into from

Conversation

Skylion007
Copy link
Collaborator

Applies rule C418 and fixes all instances of it. Also updates flake8-comprehension

@Skylion007 Skylion007 requested a review from ezyang April 14, 2023 18:10
@pytorch-bot pytorch-bot bot added the release notes: dataloader release notes category label Apr 14, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 14, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99178

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c503618:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Skylion007 Skylion007 added topic: not user facing topic category better-engineering Relatively self-contained tasks for better engineering contributors and removed release notes: dataloader release notes category labels Apr 14, 2023
@Skylion007 Skylion007 marked this pull request as ready for review April 14, 2023 19:27
@Skylion007 Skylion007 changed the title [BE] Update flake8-comprehensions and conform to new rule [BE] Update flake8-comprehensions and adapt to rule C418 Apr 14, 2023
@Skylion007 Skylion007 added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 14, 2023
janeyx99
janeyx99 reviewed Apr 14, 2023
View reviewed changes
@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 14, 2023
@Skylion007
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janeyx99 janeyx99 janeyx99 left review comments

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged merging open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Skylion007 @pytorchmergebot @ezyang @janeyx99 @pytorchbot