Skip to content

[BugFix] Fix version parsing in extensions #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2024
Merged

[BugFix] Fix version parsing in extensions #2542

merged 1 commit into from
Nov 6, 2024

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Nov 6, 2024 •
edited
Loading

Update
3e0ba77 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 6, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2542

Note: Links to docs will display an error until the docs builds have been completed.

❌ 19 New Failures, 4 Unrelated Failures

As of commit 3e0ba77 with merge base 0a13cbd (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens pushed a commit that referenced this pull request Nov 6, 2024
[BugFix] Fix version parsing in extensions
71b95eb 
ghstack-source-id: 903f2b0
Pull Request resolved: #2542
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 6, 2024
@vmoens vmoens merged commit 3e0ba77 into gh/vmoens/35/base Nov 6, 2024
14 of 26 checks passed
@vmoens vmoens deleted the gh/vmoens/35/head branch November 6, 2024 10:51
@github-actions
Copy link

github-actions bot commented Nov 6, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 149. Improved: $\large\color{#35bf28}18$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_simple 0.7513s 0.7428s 1.3463 Ops/s 1.3301 Ops/s $\color{#35bf28}+1.22\%$
test_transformed 1.0691s 0.9890s 1.0112 Ops/s 1.0389 Ops/s $\color{#d91a1a}-2.67\%$
test_serial 2.1927s 2.1157s 0.4727 Ops/s 0.4791 Ops/s $\color{#d91a1a}-1.35\%$
test_parallel 1.9991s 1.9789s 0.5053 Ops/s 0.5029 Ops/s $\color{#35bf28}+0.49\%$
test_step_mdp_speed[True-True-True-True-True] 0.1707ms 34.7743μs 28.7569 KOps/s 29.2064 KOps/s $\color{#d91a1a}-1.54\%$
test_step_mdp_speed[True-True-True-True-False] 42.1310μs 19.7691μs 50.5840 KOps/s 50.3702 KOps/s $\color{#35bf28}+0.42\%$
test_step_mdp_speed[True-True-True-False-True] 47.2510μs 19.3077μs 51.7929 KOps/s 51.9697 KOps/s $\color{#d91a1a}-0.34\%$
test_step_mdp_speed[True-True-True-False-False] 52.1410μs 11.1107μs 90.0035 KOps/s 89.4052 KOps/s $\color{#35bf28}+0.67\%$
test_step_mdp_speed[True-True-False-True-True] 72.7610μs 37.0663μs 26.9787 KOps/s 27.1327 KOps/s $\color{#d91a1a}-0.57\%$
test_step_mdp_speed[True-True-False-True-False] 46.8610μs 21.4842μs 46.5458 KOps/s 46.1138 KOps/s $\color{#35bf28}+0.94\%$
test_step_mdp_speed[True-True-False-False-True] 64.4010μs 21.0750μs 47.4496 KOps/s 47.0926 KOps/s $\color{#35bf28}+0.76\%$
test_step_mdp_speed[True-True-False-False-False] 53.9010μs 13.0138μs 76.8417 KOps/s 77.1094 KOps/s $\color{#d91a1a}-0.35\%$
test_step_mdp_speed[True-False-True-True-True] 62.4110μs 38.7320μs 25.8185 KOps/s 25.9666 KOps/s $\color{#d91a1a}-0.57\%$
test_step_mdp_speed[True-False-True-True-False] 52.9810μs 23.8676μs 41.8978 KOps/s 41.6715 KOps/s $\color{#35bf28}+0.54\%$
test_step_mdp_speed[True-False-True-False-True] 54.8510μs 21.3596μs 46.8173 KOps/s 47.4512 KOps/s $\color{#d91a1a}-1.34\%$
test_step_mdp_speed[True-False-True-False-False] 38.7310μs 13.2106μs 75.6970 KOps/s 76.9287 KOps/s $\color{#d91a1a}-1.60\%$
test_step_mdp_speed[True-False-False-True-True] 0.1014ms 40.3930μs 24.7568 KOps/s 24.2533 KOps/s $\color{#35bf28}+2.08\%$
test_step_mdp_speed[True-False-False-True-False] 58.9910μs 25.6385μs 39.0038 KOps/s 39.2476 KOps/s $\color{#d91a1a}-0.62\%$
test_step_mdp_speed[True-False-False-False-True] 58.8010μs 22.5595μs 44.3272 KOps/s 43.1310 KOps/s $\color{#35bf28}+2.77\%$
test_step_mdp_speed[True-False-False-False-False] 45.1410μs 14.9164μs 67.0403 KOps/s 67.2472 KOps/s $\color{#d91a1a}-0.31\%$
test_step_mdp_speed[False-True-True-True-True] 64.7010μs 38.6744μs 25.8569 KOps/s 25.9670 KOps/s $\color{#d91a1a}-0.42\%$
test_step_mdp_speed[False-True-True-True-False] 57.7010μs 23.4753μs 42.5979 KOps/s 42.3535 KOps/s $\color{#35bf28}+0.58\%$
test_step_mdp_speed[False-True-True-False-True] 50.6410μs 24.8938μs 40.1706 KOps/s 40.8519 KOps/s $\color{#d91a1a}-1.67\%$
test_step_mdp_speed[False-True-True-False-False] 38.4910μs 14.9312μs 66.9738 KOps/s 67.1598 KOps/s $\color{#d91a1a}-0.28\%$
test_step_mdp_speed[False-True-False-True-True] 0.1081ms 40.2047μs 24.8727 KOps/s 24.4217 KOps/s $\color{#35bf28}+1.85\%$
test_step_mdp_speed[False-True-False-True-False] 61.4510μs 24.7637μs 40.3817 KOps/s 39.1421 KOps/s $\color{#35bf28}+3.17\%$
test_step_mdp_speed[False-True-False-False-True] 3.5270ms 26.6338μs 37.5463 KOps/s 37.4827 KOps/s $\color{#35bf28}+0.17\%$
test_step_mdp_speed[False-True-False-False-False] 53.0910μs 16.5624μs 60.3777 KOps/s 61.6750 KOps/s $\color{#d91a1a}-2.10\%$
test_step_mdp_speed[False-False-True-True-True] 75.4810μs 42.2737μs 23.6554 KOps/s 23.7238 KOps/s $\color{#d91a1a}-0.29\%$
test_step_mdp_speed[False-False-True-True-False] 53.2710μs 26.7469μs 37.3875 KOps/s 36.7865 KOps/s $\color{#35bf28}+1.63\%$
test_step_mdp_speed[False-False-True-False-True] 59.7710μs 26.2841μs 38.0458 KOps/s 38.7089 KOps/s $\color{#d91a1a}-1.71\%$
test_step_mdp_speed[False-False-True-False-False] 43.2410μs 16.3250μs 61.2556 KOps/s 61.9881 KOps/s $\color{#d91a1a}-1.18\%$
test_step_mdp_speed[False-False-False-True-True] 81.4520μs 43.1393μs 23.1807 KOps/s 22.5621 KOps/s $\color{#35bf28}+2.74\%$
test_step_mdp_speed[False-False-False-True-False] 60.6710μs 29.3133μs 34.1142 KOps/s 33.9599 KOps/s $\color{#35bf28}+0.45\%$
test_step_mdp_speed[False-False-False-False-True] 60.9610μs 27.8054μs 35.9642 KOps/s 36.1412 KOps/s $\color{#d91a1a}-0.49\%$
test_step_mdp_speed[False-False-False-False-False] 67.4310μs 17.9196μs 55.8050 KOps/s 57.1277 KOps/s $\color{#d91a1a}-2.32\%$
test_values[generalized_advantage_estimate-True-True] 25.0259ms 24.4400ms 40.9165 Ops/s 41.0210 Ops/s $\color{#d91a1a}-0.25\%$
test_values[vec_generalized_advantage_estimate-True-True] 0.1010s 2.9075ms 343.9366 Ops/s 314.1578 Ops/s $\textbf{\color{#35bf28}+9.48\%}$
test_values[td0_return_estimate-False-False] 87.3910μs 65.8082μs 15.1957 KOps/s 15.3513 KOps/s $\color{#d91a1a}-1.01\%$
test_values[td1_return_estimate-False-False] 54.6222ms 54.2900ms 18.4196 Ops/s 18.5103 Ops/s $\color{#d91a1a}-0.49\%$
test_values[vec_td1_return_estimate-False-False] 1.3655ms 1.0741ms 930.9840 Ops/s 930.4929 Ops/s $\color{#35bf28}+0.05\%$
test_values[td_lambda_return_estimate-True-False] 86.9376ms 86.5278ms 11.5570 Ops/s 11.6177 Ops/s $\color{#d91a1a}-0.52\%$
test_values[vec_td_lambda_return_estimate-True-False] 1.3757ms 1.0708ms 933.8614 Ops/s 935.6825 Ops/s $\color{#d91a1a}-0.19\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 24.5109ms 24.1628ms 41.3860 Ops/s 41.4933 Ops/s $\color{#d91a1a}-0.26\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.0142ms 0.7408ms 1.3499 KOps/s 1.3544 KOps/s $\color{#d91a1a}-0.33\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7656ms 0.6555ms 1.5256 KOps/s 1.5190 KOps/s $\color{#35bf28}+0.44\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5215ms 1.4696ms 680.4632 Ops/s 681.7695 Ops/s $\color{#d91a1a}-0.19\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.7105ms 0.6702ms 1.4922 KOps/s 1.4876 KOps/s $\color{#35bf28}+0.31\%$
test_dqn_speed[False-None] 7.3112ms 1.2867ms 777.1865 Ops/s 777.4293 Ops/s $\color{#d91a1a}-0.03\%$
test_dqn_speed[False-backward] 1.8582ms 1.7878ms 559.3384 Ops/s 559.0139 Ops/s $\color{#35bf28}+0.06\%$
test_dqn_speed[True-None] 1.4777ms 0.5476ms 1.8260 KOps/s 1.8407 KOps/s $\color{#d91a1a}-0.80\%$
test_dqn_speed[True-backward] 1.0136ms 0.9859ms 1.0143 KOps/s 826.5295 Ops/s $\textbf{\color{#35bf28}+22.71\%}$
test_dqn_speed[reduce-overhead-None] 0.8655ms 0.5350ms 1.8690 KOps/s 1.7501 KOps/s $\textbf{\color{#35bf28}+6.79\%}$
test_dqn_speed[reduce-overhead-backward] 1.0097ms 0.9816ms 1.0188 KOps/s 1.0055 KOps/s $\color{#35bf28}+1.32\%$
test_ddpg_speed[False-None] 3.1784ms 2.6590ms 376.0778 Ops/s 383.8483 Ops/s $\color{#d91a1a}-2.02\%$
test_ddpg_speed[False-backward] 4.0352ms 3.8452ms 260.0669 Ops/s 263.2363 Ops/s $\color{#d91a1a}-1.20\%$
test_ddpg_speed[True-None] 1.6062ms 1.1976ms 834.9987 Ops/s 795.2951 Ops/s $\color{#35bf28}+4.99\%$
test_ddpg_speed[True-backward] 2.3503ms 2.1698ms 460.8708 Ops/s 456.1148 Ops/s $\color{#35bf28}+1.04\%$
test_ddpg_speed[reduce-overhead-None] 1.3680ms 1.2104ms 826.1865 Ops/s 816.9007 Ops/s $\color{#35bf28}+1.14\%$
test_ddpg_speed[reduce-overhead-backward] 2.1889ms 2.1460ms 465.9806 Ops/s 459.6395 Ops/s $\color{#35bf28}+1.38\%$
test_sac_speed[False-None] 8.5464ms 7.3624ms 135.8255 Ops/s 137.1154 Ops/s $\color{#d91a1a}-0.94\%$
test_sac_speed[False-backward] 10.8797ms 10.5261ms 95.0019 Ops/s 95.4868 Ops/s $\color{#d91a1a}-0.51\%$
test_sac_speed[True-None] 2.3459ms 1.9359ms 516.5557 Ops/s 501.1000 Ops/s $\color{#35bf28}+3.08\%$
test_sac_speed[True-backward] 3.9412ms 3.8209ms 261.7164 Ops/s 243.7089 Ops/s $\textbf{\color{#35bf28}+7.39\%}$
test_sac_speed[reduce-overhead-None] 2.3055ms 1.9310ms 517.8568 Ops/s 507.5150 Ops/s $\color{#35bf28}+2.04\%$
test_sac_speed[reduce-overhead-backward] 3.9946ms 3.8359ms 260.6953 Ops/s 260.3163 Ops/s $\color{#35bf28}+0.15\%$
test_redq_speed[False-None] 14.9384ms 10.1841ms 98.1921 Ops/s 91.3586 Ops/s $\textbf{\color{#35bf28}+7.48\%}$
test_redq_speed[False-backward] 17.8262ms 16.8420ms 59.3754 Ops/s 60.6147 Ops/s $\color{#d91a1a}-2.04\%$
test_redq_speed[True-None] 3.5793ms 3.3291ms 300.3848 Ops/s 285.3859 Ops/s $\textbf{\color{#35bf28}+5.26\%}$
test_redq_speed[True-backward] 8.5798ms 8.2174ms 121.6937 Ops/s 112.4503 Ops/s $\textbf{\color{#35bf28}+8.22\%}$
test_redq_speed[reduce-overhead-None] 3.9822ms 3.4575ms 289.2272 Ops/s 288.1665 Ops/s $\color{#35bf28}+0.37\%$
test_redq_speed[reduce-overhead-backward] 8.6848ms 8.2351ms 121.4318 Ops/s 121.2759 Ops/s $\color{#35bf28}+0.13\%$
test_redq_deprec_speed[False-None] 10.7313ms 10.2917ms 97.1654 Ops/s 99.6147 Ops/s $\color{#d91a1a}-2.46\%$
test_redq_deprec_speed[False-backward] 15.5165ms 14.8461ms 67.3578 Ops/s 68.8180 Ops/s $\color{#d91a1a}-2.12\%$
test_redq_deprec_speed[True-None] 3.5319ms 3.1177ms 320.7464 Ops/s 324.9858 Ops/s $\color{#d91a1a}-1.30\%$
test_redq_deprec_speed[True-backward] 7.1019ms 6.8177ms 146.6771 Ops/s 152.4676 Ops/s $\color{#d91a1a}-3.80\%$
test_redq_deprec_speed[reduce-overhead-None] 3.5308ms 3.0905ms 323.5740 Ops/s 329.3351 Ops/s $\color{#d91a1a}-1.75\%$
test_redq_deprec_speed[reduce-overhead-backward] 7.1370ms 6.8956ms 145.0199 Ops/s 153.3412 Ops/s $\textbf{\color{#d91a1a}-5.43\%}$
test_td3_speed[False-None] 7.5236ms 7.3671ms 135.7388 Ops/s 136.4701 Ops/s $\color{#d91a1a}-0.54\%$
test_td3_speed[False-backward] 10.5952ms 10.1786ms 98.2451 Ops/s 98.1970 Ops/s $\color{#35bf28}+0.05\%$
test_td3_speed[True-None] 1.9858ms 1.8245ms 548.1075 Ops/s 533.1725 Ops/s $\color{#35bf28}+2.80\%$
test_td3_speed[True-backward] 3.6716ms 3.5620ms 280.7449 Ops/s 276.2784 Ops/s $\color{#35bf28}+1.62\%$
test_td3_speed[reduce-overhead-None] 1.8465ms 1.8087ms 552.8848 Ops/s 542.2130 Ops/s $\color{#35bf28}+1.97\%$
test_td3_speed[reduce-overhead-backward] 4.0364ms 3.6148ms 276.6441 Ops/s 275.9924 Ops/s $\color{#35bf28}+0.24\%$
test_cql_speed[False-None] 27.9838ms 24.7382ms 40.4233 Ops/s 40.7046 Ops/s $\color{#d91a1a}-0.69\%$
test_cql_speed[False-backward] 37.8633ms 33.8255ms 29.5635 Ops/s 30.2305 Ops/s $\color{#d91a1a}-2.21\%$
test_cql_speed[True-None] 10.8179ms 10.5208ms 95.0497 Ops/s 93.3145 Ops/s $\color{#35bf28}+1.86\%$
test_cql_speed[True-backward] 16.5504ms 16.1059ms 62.0892 Ops/s 61.8541 Ops/s $\color{#35bf28}+0.38\%$
test_cql_speed[reduce-overhead-None] 10.8280ms 10.5715ms 94.5943 Ops/s 94.3273 Ops/s $\color{#35bf28}+0.28\%$
test_cql_speed[reduce-overhead-backward] 16.6063ms 16.1887ms 61.7715 Ops/s 61.2484 Ops/s $\color{#35bf28}+0.85\%$
test_a2c_speed[False-None] 5.6269ms 5.2351ms 191.0167 Ops/s 190.8740 Ops/s $\color{#35bf28}+0.07\%$
test_a2c_speed[False-backward] 11.8502ms 11.3801ms 87.8724 Ops/s 86.5687 Ops/s $\color{#35bf28}+1.51\%$
test_a2c_speed[True-None] 3.2340ms 2.9409ms 340.0365 Ops/s 329.5848 Ops/s $\color{#35bf28}+3.17\%$
test_a2c_speed[True-backward] 8.5643ms 8.0612ms 124.0514 Ops/s 121.9026 Ops/s $\color{#35bf28}+1.76\%$
test_a2c_speed[reduce-overhead-None] 3.1228ms 2.9710ms 336.5899 Ops/s 329.0193 Ops/s $\color{#35bf28}+2.30\%$
test_a2c_speed[reduce-overhead-backward] 8.4594ms 8.1341ms 122.9395 Ops/s 123.0319 Ops/s $\color{#d91a1a}-0.08\%$
test_ppo_speed[False-None] 7.1477ms 5.5405ms 180.4882 Ops/s 180.1073 Ops/s $\color{#35bf28}+0.21\%$
test_ppo_speed[False-backward] 12.2474ms 12.0064ms 83.2887 Ops/s 84.0334 Ops/s $\color{#d91a1a}-0.89\%$
test_ppo_speed[True-None] 3.5531ms 3.3391ms 299.4809 Ops/s 289.0186 Ops/s $\color{#35bf28}+3.62\%$
test_ppo_speed[True-backward] 8.1332ms 7.9697ms 125.4755 Ops/s 125.5154 Ops/s $\color{#d91a1a}-0.03\%$
test_ppo_speed[reduce-overhead-None] 3.7356ms 3.3648ms 297.1960 Ops/s 300.6370 Ops/s $\color{#d91a1a}-1.14\%$
test_ppo_speed[reduce-overhead-backward] 8.1600ms 7.8945ms 126.6701 Ops/s 125.5926 Ops/s $\color{#35bf28}+0.86\%$
test_reinforce_speed[False-None] 4.9457ms 4.3687ms 228.9016 Ops/s 230.8650 Ops/s $\color{#d91a1a}-0.85\%$
test_reinforce_speed[False-backward] 7.3562ms 7.0951ms 140.9422 Ops/s 141.2754 Ops/s $\color{#d91a1a}-0.24\%$
test_reinforce_speed[True-None] 2.4611ms 2.1496ms 465.2103 Ops/s 461.2186 Ops/s $\color{#35bf28}+0.87\%$
test_reinforce_speed[True-backward] 8.2535ms 7.2105ms 138.6859 Ops/s 116.0051 Ops/s $\textbf{\color{#35bf28}+19.55\%}$
test_reinforce_speed[reduce-overhead-None] 2.5178ms 2.1496ms 465.2119 Ops/s 404.1252 Ops/s $\textbf{\color{#35bf28}+15.12\%}$
test_reinforce_speed[reduce-overhead-backward] 6.9923ms 6.7955ms 147.1571 Ops/s 143.8084 Ops/s $\color{#35bf28}+2.33\%$
test_iql_speed[False-None] 19.0981ms 18.6478ms 53.6257 Ops/s 51.9768 Ops/s $\color{#35bf28}+3.17\%$
test_iql_speed[False-backward] 30.2064ms 28.7883ms 34.7363 Ops/s 33.7811 Ops/s $\color{#35bf28}+2.83\%$
test_iql_speed[True-None] 6.8393ms 6.4975ms 153.9043 Ops/s 148.9246 Ops/s $\color{#35bf28}+3.34\%$
test_iql_speed[True-backward] 15.3307ms 14.8595ms 67.2969 Ops/s 64.3500 Ops/s $\color{#35bf28}+4.58\%$
test_iql_speed[reduce-overhead-None] 6.9215ms 6.5036ms 153.7606 Ops/s 152.5344 Ops/s $\color{#35bf28}+0.80\%$
test_iql_speed[reduce-overhead-backward] 15.2447ms 14.9739ms 66.7827 Ops/s 66.4261 Ops/s $\color{#35bf28}+0.54\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.8436ms 6.0397ms 165.5717 Ops/s 163.3387 Ops/s $\color{#35bf28}+1.37\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.5561ms 0.3199ms 3.1265 KOps/s 3.1647 KOps/s $\color{#d91a1a}-1.21\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6312ms 0.2880ms 3.4719 KOps/s 3.2794 KOps/s $\textbf{\color{#35bf28}+5.87\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.0299ms 5.7952ms 172.5570 Ops/s 170.8847 Ops/s $\color{#35bf28}+0.98\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.8396ms 0.3090ms 3.2366 KOps/s 3.7665 KOps/s $\textbf{\color{#d91a1a}-14.07\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5018ms 0.2265ms 4.4150 KOps/s 3.7589 KOps/s $\textbf{\color{#35bf28}+17.45\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.6779ms 1.4096ms 709.4323 Ops/s 784.6174 Ops/s $\textbf{\color{#d91a1a}-9.58\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6252ms 1.3807ms 724.2455 Ops/s 802.0169 Ops/s $\textbf{\color{#d91a1a}-9.70\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.0837ms 5.9554ms 167.9134 Ops/s 165.6787 Ops/s $\color{#35bf28}+1.35\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1563ms 0.4465ms 2.2398 KOps/s 2.2687 KOps/s $\color{#d91a1a}-1.28\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7540ms 0.4094ms 2.4427 KOps/s 2.4818 KOps/s $\color{#d91a1a}-1.57\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.9764ms 5.8476ms 171.0110 Ops/s 169.7757 Ops/s $\color{#35bf28}+0.73\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6871ms 0.2624ms 3.8115 KOps/s 3.3087 KOps/s $\textbf{\color{#35bf28}+15.20\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.4308ms 0.2401ms 4.1647 KOps/s 3.7317 KOps/s $\textbf{\color{#35bf28}+11.60\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.1403ms 5.8461ms 171.0552 Ops/s 172.1903 Ops/s $\color{#d91a1a}-0.66\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8064ms 0.2522ms 3.9658 KOps/s 4.0032 KOps/s $\color{#d91a1a}-0.93\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.4474ms 0.2275ms 4.3947 KOps/s 4.2445 KOps/s $\color{#35bf28}+3.54\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.1453ms 5.9962ms 166.7714 Ops/s 165.1424 Ops/s $\color{#35bf28}+0.99\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.4668ms 0.3976ms 2.5153 KOps/s 1.9926 KOps/s $\textbf{\color{#35bf28}+26.23\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.5930ms 0.3769ms 2.6535 KOps/s 2.0876 KOps/s $\textbf{\color{#35bf28}+27.11\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.4277s 13.6684ms 73.1616 Ops/s 191.7961 Ops/s $\textbf{\color{#d91a1a}-61.85\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 3.7620ms 1.5648ms 639.0503 Ops/s 456.4806 Ops/s $\textbf{\color{#35bf28}+40.00\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 11.1600ms 1.2711ms 786.7140 Ops/s 886.5086 Ops/s $\textbf{\color{#d91a1a}-11.26\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 7.6589ms 5.2699ms 189.7556 Ops/s 33.8251 Ops/s $\textbf{\color{#35bf28}+460.99\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 8.3077ms 2.0054ms 498.6424 Ops/s 484.1594 Ops/s $\color{#35bf28}+2.99\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 7.4165ms 1.2091ms 827.0486 Ops/s 849.4660 Ops/s $\color{#d91a1a}-2.64\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.3769s 12.9070ms 77.4774 Ops/s 177.0552 Ops/s $\textbf{\color{#d91a1a}-56.24\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 10.5955ms 2.0551ms 486.5948 Ops/s 466.7578 Ops/s $\color{#35bf28}+4.25\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 7.2549ms 1.3221ms 756.3597 Ops/s 701.9013 Ops/s $\textbf{\color{#35bf28}+7.76\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 13.3496ms 12.2304ms 81.7636 Ops/s 79.8107 Ops/s $\color{#35bf28}+2.45\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 17.0970ms 16.2524ms 61.5295 Ops/s 60.9575 Ops/s $\color{#35bf28}+0.94\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 17.3129ms 17.0255ms 58.7356 Ops/s 57.7242 Ops/s $\color{#35bf28}+1.75\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 17.8829ms 16.7040ms 59.8659 Ops/s 59.0801 Ops/s $\color{#35bf28}+1.33\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 17.2882ms 16.7810ms 59.5910 Ops/s 58.6340 Ops/s $\color{#35bf28}+1.63\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 19.4471ms 17.8401ms 56.0536 Ops/s 55.4069 Ops/s $\color{#35bf28}+1.17\%$

vmoens pushed a commit that referenced this pull request Nov 14, 2024
[BugFix] Fix version parsing in extensions
815abad 
ghstack-source-id: 903f2b0
Pull Request resolved: #2542

(cherry picked from commit 997d90e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vmoens @facebook-github-bot