Skip to content

[BugFix] Fix version parsing in extensions #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024
Merged

[BugFix] Fix version parsing in extensions #2542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion torchrl/_extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@
import warnings

from packaging.version import parse
from torchrl import __version__

try:
from .version import __version__
except ImportError:
__version__ = None


def is_module_available(*modules: str) -> bool:
Expand All @@ -28,6 +32,8 @@ def _init_extension():


def _is_nightly(version):
if version is None:
return True
parsed_version = parse(version)
return parsed_version.local is not None

Expand Down
Loading