Skip to content

[BugFix,Test,Refactor] Refactor tests #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2025
Merged

[BugFix,Test,Refactor] Refactor tests #3232

merged 3 commits into from
Nov 6, 2025

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Nov 6, 2025 •
edited
Loading

@vmoens
Update
14eeb4a 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3232

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 6, 2025
This was referenced Nov 6, 2025
Merged
Merged
Merged
Merged
@vmoens
Update
7fd8d0e 
[ghstack-poisoned]
@github-actions
Copy link

github-actions bot commented Nov 6, 2025 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 154. Improved: $\large\color{#35bf28}23$. Worsened: $\large\color{#d91a1a}1$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_tensor_to_bytestream_speed[pickle] 83.1816μs 82.4615μs 12.1269 KOps/s 11.8832 KOps/s $\color{#35bf28}+2.05\%$
test_tensor_to_bytestream_speed[torch.save] 0.1439ms 0.1431ms 6.9859 KOps/s 6.9505 KOps/s $\color{#35bf28}+0.51\%$
test_tensor_to_bytestream_speed[untyped_storage] 0.1255s 0.1244s 8.0405 Ops/s 8.1797 Ops/s $\color{#d91a1a}-1.70\%$
test_tensor_to_bytestream_speed[numpy] 2.9036μs 2.8796μs 347.2721 KOps/s 341.6612 KOps/s $\color{#35bf28}+1.64\%$
test_tensor_to_bytestream_speed[safetensors] 41.8251μs 41.4211μs 24.1423 KOps/s 23.6491 KOps/s $\color{#35bf28}+2.09\%$
test_simple 0.6657s 0.5743s 1.7411 Ops/s 1.7316 Ops/s $\color{#35bf28}+0.55\%$
test_transformed 1.2324s 1.1438s 0.8743 Ops/s 0.8741 Ops/s $\color{#35bf28}+0.02\%$
test_serial 1.7006s 1.6867s 0.5929 Ops/s 0.5915 Ops/s $\color{#35bf28}+0.23\%$
test_parallel 1.0886s 1.0668s 0.9374 Ops/s 0.9118 Ops/s $\color{#35bf28}+2.81\%$
test_step_mdp_speed[True-True-True-True-True] 0.1502ms 44.1308μs 22.6599 KOps/s 22.2988 KOps/s $\color{#35bf28}+1.62\%$
test_step_mdp_speed[True-True-True-True-False] 0.1083ms 24.8485μs 40.2438 KOps/s 39.6702 KOps/s $\color{#35bf28}+1.45\%$
test_step_mdp_speed[True-True-True-False-True] 66.4210μs 24.5432μs 40.7445 KOps/s 39.4163 KOps/s $\color{#35bf28}+3.37\%$
test_step_mdp_speed[True-True-True-False-False] 59.8810μs 13.6475μs 73.2736 KOps/s 72.0392 KOps/s $\color{#35bf28}+1.71\%$
test_step_mdp_speed[True-True-False-True-True] 98.0620μs 47.5368μs 21.0363 KOps/s 20.6025 KOps/s $\color{#35bf28}+2.11\%$
test_step_mdp_speed[True-True-False-True-False] 60.9010μs 27.7651μs 36.0164 KOps/s 35.1483 KOps/s $\color{#35bf28}+2.47\%$
test_step_mdp_speed[True-True-False-False-True] 99.0220μs 27.8572μs 35.8973 KOps/s 35.1771 KOps/s $\color{#35bf28}+2.05\%$
test_step_mdp_speed[True-True-False-False-False] 45.8510μs 16.6068μs 60.2162 KOps/s 60.4166 KOps/s $\color{#d91a1a}-0.33\%$
test_step_mdp_speed[True-False-True-True-True] 95.9320μs 51.4578μs 19.4334 KOps/s 19.3864 KOps/s $\color{#35bf28}+0.24\%$
test_step_mdp_speed[True-False-True-True-False] 64.7220μs 30.5870μs 32.6936 KOps/s 32.9237 KOps/s $\color{#d91a1a}-0.70\%$
test_step_mdp_speed[True-False-True-False-True] 61.8710μs 27.5835μs 36.2535 KOps/s 35.9736 KOps/s $\color{#35bf28}+0.78\%$
test_step_mdp_speed[True-False-True-False-False] 49.3110μs 16.4831μs 60.6683 KOps/s 60.0579 KOps/s $\color{#35bf28}+1.02\%$
test_step_mdp_speed[True-False-False-True-True] 0.1014ms 52.9224μs 18.8956 KOps/s 18.6879 KOps/s $\color{#35bf28}+1.11\%$
test_step_mdp_speed[True-False-False-True-False] 0.1140ms 33.5564μs 29.8005 KOps/s 29.3399 KOps/s $\color{#35bf28}+1.57\%$
test_step_mdp_speed[True-False-False-False-True] 63.8120μs 30.0660μs 33.2601 KOps/s 32.5530 KOps/s $\color{#35bf28}+2.17\%$
test_step_mdp_speed[True-False-False-False-False] 49.8210μs 19.2834μs 51.8581 KOps/s 51.1238 KOps/s $\color{#35bf28}+1.44\%$
test_step_mdp_speed[False-True-True-True-True] 0.1247ms 50.8860μs 19.6518 KOps/s 19.4936 KOps/s $\color{#35bf28}+0.81\%$
test_step_mdp_speed[False-True-True-True-False] 61.5310μs 30.4932μs 32.7942 KOps/s 32.6060 KOps/s $\color{#35bf28}+0.58\%$
test_step_mdp_speed[False-True-True-False-True] 2.4803ms 31.8188μs 31.4279 KOps/s 31.2120 KOps/s $\color{#35bf28}+0.69\%$
test_step_mdp_speed[False-True-True-False-False] 49.9810μs 18.4452μs 54.2146 KOps/s 54.3962 KOps/s $\color{#d91a1a}-0.33\%$
test_step_mdp_speed[False-True-False-True-True] 92.6620μs 52.6386μs 18.9975 KOps/s 18.6702 KOps/s $\color{#35bf28}+1.75\%$
test_step_mdp_speed[False-True-False-True-False] 72.1010μs 33.3271μs 30.0057 KOps/s 29.6128 KOps/s $\color{#35bf28}+1.33\%$
test_step_mdp_speed[False-True-False-False-True] 76.3610μs 34.1230μs 29.3058 KOps/s 28.7016 KOps/s $\color{#35bf28}+2.11\%$
test_step_mdp_speed[False-True-False-False-False] 50.7910μs 21.0519μs 47.5017 KOps/s 47.6787 KOps/s $\color{#d91a1a}-0.37\%$
test_step_mdp_speed[False-False-True-True-True] 0.1011ms 56.5321μs 17.6891 KOps/s 17.5776 KOps/s $\color{#35bf28}+0.63\%$
test_step_mdp_speed[False-False-True-True-False] 67.9610μs 35.8985μs 27.8563 KOps/s 27.3011 KOps/s $\color{#35bf28}+2.03\%$
test_step_mdp_speed[False-False-True-False-True] 64.6310μs 33.9641μs 29.4429 KOps/s 28.5627 KOps/s $\color{#35bf28}+3.08\%$
test_step_mdp_speed[False-False-True-False-False] 50.0610μs 21.3466μs 46.8460 KOps/s 47.7166 KOps/s $\color{#d91a1a}-1.82\%$
test_step_mdp_speed[False-False-False-True-True] 0.1122ms 58.1800μs 17.1880 KOps/s 17.3357 KOps/s $\color{#d91a1a}-0.85\%$
test_step_mdp_speed[False-False-False-True-False] 93.0620μs 38.6901μs 25.8464 KOps/s 26.0751 KOps/s $\color{#d91a1a}-0.88\%$
test_step_mdp_speed[False-False-False-False-True] 87.1520μs 36.1918μs 27.6306 KOps/s 27.2378 KOps/s $\color{#35bf28}+1.44\%$
test_step_mdp_speed[False-False-False-False-False] 52.2010μs 23.5565μs 42.4512 KOps/s 43.0221 KOps/s $\color{#d91a1a}-1.33\%$
test_values[generalized_advantage_estimate-True-True] 10.1493ms 9.9448ms 100.5551 Ops/s 100.3736 Ops/s $\color{#35bf28}+0.18\%$
test_values[vec_generalized_advantage_estimate-True-True] 19.9992ms 17.8397ms 56.0547 Ops/s 56.2889 Ops/s $\color{#d91a1a}-0.42\%$
test_values[td0_return_estimate-False-False] 0.2035ms 0.1229ms 8.1347 KOps/s 7.7703 KOps/s $\color{#35bf28}+4.69\%$
test_values[td1_return_estimate-False-False] 27.9030ms 27.5496ms 36.2982 Ops/s 35.9586 Ops/s $\color{#35bf28}+0.94\%$
test_values[vec_td1_return_estimate-False-False] 18.4222ms 17.9689ms 55.6517 Ops/s 56.5130 Ops/s $\color{#d91a1a}-1.52\%$
test_values[td_lambda_return_estimate-True-False] 42.1831ms 41.2232ms 24.2582 Ops/s 24.0721 Ops/s $\color{#35bf28}+0.77\%$
test_values[vec_td_lambda_return_estimate-True-False] 18.7477ms 17.9368ms 55.7514 Ops/s 56.4143 Ops/s $\color{#d91a1a}-1.18\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.8893ms 8.7339ms 114.4958 Ops/s 114.9579 Ops/s $\color{#d91a1a}-0.40\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.7373ms 1.5508ms 644.8491 Ops/s 672.2125 Ops/s $\color{#d91a1a}-4.07\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4785ms 0.4176ms 2.3945 KOps/s 2.4225 KOps/s $\color{#d91a1a}-1.16\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 35.5238ms 34.9891ms 28.5803 Ops/s 28.8579 Ops/s $\color{#d91a1a}-0.96\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 1.9119ms 1.7381ms 575.3473 Ops/s 574.9137 Ops/s $\color{#35bf28}+0.08\%$
test_dqn_speed[False-None] 6.5582ms 1.4316ms 698.5201 Ops/s 691.9629 Ops/s $\color{#35bf28}+0.95\%$
test_dqn_speed[False-backward] 2.0277ms 1.9308ms 517.9247 Ops/s 508.4238 Ops/s $\color{#35bf28}+1.87\%$
test_dqn_speed[True-None] 0.7127ms 0.5185ms 1.9287 KOps/s 1.8756 KOps/s $\color{#35bf28}+2.83\%$
test_dqn_speed[True-backward] 1.0226ms 0.9708ms 1.0301 KOps/s 921.4458 Ops/s $\textbf{\color{#35bf28}+11.79\%}$
test_dqn_speed[reduce-overhead-None] 0.5975ms 0.5187ms 1.9278 KOps/s 1.9084 KOps/s $\color{#35bf28}+1.02\%$
test_dqn_speed[reduce-overhead-backward] 0.9942ms 0.9533ms 1.0490 KOps/s 1.0261 KOps/s $\color{#35bf28}+2.23\%$
test_ddpg_speed[False-None] 3.2279ms 2.9053ms 344.1995 Ops/s 342.4536 Ops/s $\color{#35bf28}+0.51\%$
test_ddpg_speed[False-backward] 4.2644ms 4.1012ms 243.8297 Ops/s 238.5946 Ops/s $\color{#35bf28}+2.19\%$
test_ddpg_speed[True-None] 1.5815ms 1.3847ms 722.1718 Ops/s 700.9556 Ops/s $\color{#35bf28}+3.03\%$
test_ddpg_speed[True-backward] 2.4143ms 2.3568ms 424.3023 Ops/s 410.5577 Ops/s $\color{#35bf28}+3.35\%$
test_ddpg_speed[reduce-overhead-None] 1.6338ms 1.3870ms 720.9717 Ops/s 713.7148 Ops/s $\color{#35bf28}+1.02\%$
test_ddpg_speed[reduce-overhead-backward] 2.4555ms 2.3793ms 420.2908 Ops/s 400.7254 Ops/s $\color{#35bf28}+4.88\%$
test_sac_speed[False-None] 8.3210ms 7.9149ms 126.3441 Ops/s 125.4568 Ops/s $\color{#35bf28}+0.71\%$
test_sac_speed[False-backward] 11.7236ms 11.2549ms 88.8506 Ops/s 88.7676 Ops/s $\color{#35bf28}+0.09\%$
test_sac_speed[True-None] 2.2193ms 2.0810ms 480.5319 Ops/s 466.0792 Ops/s $\color{#35bf28}+3.10\%$
test_sac_speed[True-backward] 4.2603ms 4.0575ms 246.4591 Ops/s 247.1027 Ops/s $\color{#d91a1a}-0.26\%$
test_sac_speed[reduce-overhead-None] 2.4641ms 2.0809ms 480.5634 Ops/s 456.9869 Ops/s $\textbf{\color{#35bf28}+5.16\%}$
test_sac_speed[reduce-overhead-backward] 4.1711ms 4.0274ms 248.3003 Ops/s 245.9196 Ops/s $\color{#35bf28}+0.97\%$
test_redq_speed[False-None] 10.7368ms 10.2087ms 97.9553 Ops/s 92.3450 Ops/s $\textbf{\color{#35bf28}+6.08\%}$
test_redq_speed[False-backward] 22.9636ms 18.1082ms 55.2235 Ops/s 55.0222 Ops/s $\color{#35bf28}+0.37\%$
test_redq_speed[True-None] 4.6652ms 4.3516ms 229.8020 Ops/s 214.3652 Ops/s $\textbf{\color{#35bf28}+7.20\%}$
test_redq_speed[True-backward] 13.0850ms 9.8883ms 101.1301 Ops/s 105.2295 Ops/s $\color{#d91a1a}-3.90\%$
test_redq_speed[reduce-overhead-None] 4.8885ms 4.3191ms 231.5310 Ops/s 227.8810 Ops/s $\color{#35bf28}+1.60\%$
test_redq_speed[reduce-overhead-backward] 9.9992ms 9.7825ms 102.2235 Ops/s 95.3378 Ops/s $\textbf{\color{#35bf28}+7.22\%}$
test_redq_deprec_speed[False-None] 11.5709ms 11.0930ms 90.1469 Ops/s 88.2886 Ops/s $\color{#35bf28}+2.10\%$
test_redq_deprec_speed[False-backward] 16.4086ms 15.9799ms 62.5786 Ops/s 61.1070 Ops/s $\color{#35bf28}+2.41\%$
test_redq_deprec_speed[True-None] 4.0522ms 3.6031ms 277.5354 Ops/s 272.3547 Ops/s $\color{#35bf28}+1.90\%$
test_redq_deprec_speed[True-backward] 7.7900ms 7.4987ms 133.3562 Ops/s 126.7070 Ops/s $\textbf{\color{#35bf28}+5.25\%}$
test_redq_deprec_speed[reduce-overhead-None] 4.1305ms 3.5385ms 282.6041 Ops/s 282.0031 Ops/s $\color{#35bf28}+0.21\%$
test_redq_deprec_speed[reduce-overhead-backward] 7.9343ms 7.4809ms 133.6731 Ops/s 132.7320 Ops/s $\color{#35bf28}+0.71\%$
test_td3_speed[False-None] 8.0307ms 7.9338ms 126.0428 Ops/s 124.3037 Ops/s $\color{#35bf28}+1.40\%$
test_td3_speed[False-backward] 11.4972ms 10.9169ms 91.6007 Ops/s 91.2205 Ops/s $\color{#35bf28}+0.42\%$
test_td3_speed[True-None] 1.9016ms 1.7676ms 565.7246 Ops/s 554.7073 Ops/s $\color{#35bf28}+1.99\%$
test_td3_speed[True-backward] 3.7128ms 3.5641ms 280.5778 Ops/s 276.5661 Ops/s $\color{#35bf28}+1.45\%$
test_td3_speed[reduce-overhead-None] 1.7903ms 1.7487ms 571.8550 Ops/s 561.7055 Ops/s $\color{#35bf28}+1.81\%$
test_td3_speed[reduce-overhead-backward] 3.7723ms 3.6159ms 276.5570 Ops/s 273.0866 Ops/s $\color{#35bf28}+1.27\%$
test_cql_speed[False-None] 26.4460ms 25.7237ms 38.8747 Ops/s 38.3068 Ops/s $\color{#35bf28}+1.48\%$
test_cql_speed[False-backward] 39.7719ms 35.5351ms 28.1412 Ops/s 27.7206 Ops/s $\color{#35bf28}+1.52\%$
test_cql_speed[True-None] 12.7589ms 12.2980ms 81.3139 Ops/s 78.6932 Ops/s $\color{#35bf28}+3.33\%$
test_cql_speed[True-backward] 18.9367ms 17.9582ms 55.6847 Ops/s 52.8438 Ops/s $\textbf{\color{#35bf28}+5.38\%}$
test_cql_speed[reduce-overhead-None] 12.6514ms 12.3837ms 80.7515 Ops/s 78.7438 Ops/s $\color{#35bf28}+2.55\%$
test_cql_speed[reduce-overhead-backward] 18.3781ms 17.9042ms 55.8528 Ops/s 55.8252 Ops/s $\color{#35bf28}+0.05\%$
test_a2c_speed[False-None] 5.6324ms 5.3723ms 186.1416 Ops/s 181.2619 Ops/s $\color{#35bf28}+2.69\%$
test_a2c_speed[False-backward] 12.2857ms 11.9114ms 83.9529 Ops/s 83.7720 Ops/s $\color{#35bf28}+0.22\%$
test_a2c_speed[True-None] 4.0115ms 3.7042ms 269.9623 Ops/s 262.6498 Ops/s $\color{#35bf28}+2.78\%$
test_a2c_speed[True-backward] 9.3305ms 8.7827ms 113.8596 Ops/s 104.4285 Ops/s $\textbf{\color{#35bf28}+9.03\%}$
test_a2c_speed[reduce-overhead-None] 4.0504ms 3.7090ms 269.6132 Ops/s 268.9863 Ops/s $\color{#35bf28}+0.23\%$
test_a2c_speed[reduce-overhead-backward] 9.1094ms 8.8615ms 112.8472 Ops/s 108.0807 Ops/s $\color{#35bf28}+4.41\%$
test_ppo_speed[False-None] 6.8072ms 5.9969ms 166.7515 Ops/s 171.4808 Ops/s $\color{#d91a1a}-2.76\%$
test_ppo_speed[False-backward] 13.1450ms 12.6646ms 78.9600 Ops/s 81.1404 Ops/s $\color{#d91a1a}-2.69\%$
test_ppo_speed[True-None] 3.9563ms 3.6662ms 272.7634 Ops/s 268.7022 Ops/s $\color{#35bf28}+1.51\%$
test_ppo_speed[True-backward] 8.8640ms 8.4646ms 118.1389 Ops/s 113.1866 Ops/s $\color{#35bf28}+4.38\%$
test_ppo_speed[reduce-overhead-None] 4.2632ms 3.6536ms 273.7009 Ops/s 271.2084 Ops/s $\color{#35bf28}+0.92\%$
test_ppo_speed[reduce-overhead-backward] 9.1714ms 8.7735ms 113.9801 Ops/s 110.4287 Ops/s $\color{#35bf28}+3.22\%$
test_reinforce_speed[False-None] 5.0605ms 4.6303ms 215.9695 Ops/s 216.5800 Ops/s $\color{#d91a1a}-0.28\%$
test_reinforce_speed[False-backward] 7.8159ms 7.4253ms 134.6755 Ops/s 133.0323 Ops/s $\color{#35bf28}+1.24\%$
test_reinforce_speed[True-None] 3.2085ms 2.8717ms 348.2240 Ops/s 330.8708 Ops/s $\textbf{\color{#35bf28}+5.24\%}$
test_reinforce_speed[True-backward] 8.5334ms 7.8178ms 127.9130 Ops/s 120.2452 Ops/s $\textbf{\color{#35bf28}+6.38\%}$
test_reinforce_speed[reduce-overhead-None] 3.3674ms 2.8548ms 350.2860 Ops/s 350.3301 Ops/s $\color{#d91a1a}-0.01\%$
test_reinforce_speed[reduce-overhead-backward] 8.2531ms 7.9982ms 125.0281 Ops/s 119.3340 Ops/s $\color{#35bf28}+4.77\%$
test_iql_speed[False-None] 25.5463ms 20.3329ms 49.1813 Ops/s 50.3621 Ops/s $\color{#d91a1a}-2.34\%$
test_iql_speed[False-backward] 36.2623ms 30.6435ms 32.6334 Ops/s 32.6526 Ops/s $\color{#d91a1a}-0.06\%$
test_iql_speed[True-None] 8.9839ms 8.5358ms 117.1532 Ops/s 113.7273 Ops/s $\color{#35bf28}+3.01\%$
test_iql_speed[True-backward] 17.8099ms 16.7467ms 59.7133 Ops/s 59.4791 Ops/s $\color{#35bf28}+0.39\%$
test_iql_speed[reduce-overhead-None] 9.0785ms 8.5513ms 116.9419 Ops/s 112.4305 Ops/s $\color{#35bf28}+4.01\%$
test_iql_speed[reduce-overhead-backward] 17.5440ms 17.1582ms 58.2812 Ops/s 57.0695 Ops/s $\color{#35bf28}+2.12\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.4650ms 6.0050ms 166.5280 Ops/s 165.7381 Ops/s $\color{#35bf28}+0.48\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6690ms 0.3320ms 3.0120 KOps/s 2.6550 KOps/s $\textbf{\color{#35bf28}+13.45\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6640ms 0.3194ms 3.1313 KOps/s 2.8211 KOps/s $\textbf{\color{#35bf28}+11.00\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.0357ms 5.7682ms 173.3648 Ops/s 172.2492 Ops/s $\color{#35bf28}+0.65\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.0809ms 0.2795ms 3.5783 KOps/s 3.0176 KOps/s $\textbf{\color{#35bf28}+18.58\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.4793ms 0.2570ms 3.8914 KOps/s 3.1889 KOps/s $\textbf{\color{#35bf28}+22.03\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.4985ms 1.2646ms 790.7690 Ops/s 697.7428 Ops/s $\textbf{\color{#35bf28}+13.33\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.5083ms 1.1762ms 850.2163 Ops/s 740.4495 Ops/s $\textbf{\color{#35bf28}+14.82\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.0888ms 5.8942ms 169.6576 Ops/s 166.4373 Ops/s $\color{#35bf28}+1.93\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.9424ms 0.4345ms 2.3017 KOps/s 2.0180 KOps/s $\textbf{\color{#35bf28}+14.06\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.6447ms 0.4092ms 2.4436 KOps/s 2.1520 KOps/s $\textbf{\color{#35bf28}+13.55\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.9252ms 5.7605ms 173.5960 Ops/s 172.0527 Ops/s $\color{#35bf28}+0.90\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.7386ms 0.2842ms 3.5189 KOps/s 3.5065 KOps/s $\color{#35bf28}+0.35\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.4329ms 0.2612ms 3.8279 KOps/s 3.7850 KOps/s $\color{#35bf28}+1.13\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.0342ms 5.7249ms 174.6747 Ops/s 173.7409 Ops/s $\color{#35bf28}+0.54\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6697ms 0.3235ms 3.0912 KOps/s 2.9053 KOps/s $\textbf{\color{#35bf28}+6.40\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5544ms 0.3337ms 2.9965 KOps/s 2.8338 KOps/s $\textbf{\color{#35bf28}+5.74\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 9.8763ms 6.0403ms 165.5556 Ops/s 167.4996 Ops/s $\color{#d91a1a}-1.16\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7336ms 0.4354ms 2.2966 KOps/s 2.0442 KOps/s $\textbf{\color{#35bf28}+12.35\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7239ms 0.4702ms 2.1268 KOps/s 2.2035 KOps/s $\color{#d91a1a}-3.48\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.4973s 14.9740ms 66.7824 Ops/s 192.3082 Ops/s $\textbf{\color{#d91a1a}-65.27\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 9.9920ms 2.0609ms 485.2156 Ops/s 482.4527 Ops/s $\color{#35bf28}+0.57\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 7.1010ms 1.1784ms 848.6184 Ops/s 826.7912 Ops/s $\color{#35bf28}+2.64\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 6.7184ms 5.1225ms 195.2185 Ops/s 190.8004 Ops/s $\color{#35bf28}+2.32\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 10.4111ms 2.0548ms 486.6647 Ops/s 485.0653 Ops/s $\color{#35bf28}+0.33\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 3.4059ms 1.0901ms 917.3292 Ops/s 826.3613 Ops/s $\textbf{\color{#35bf28}+11.01\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.4461s 14.1807ms 70.5183 Ops/s 57.3138 Ops/s $\textbf{\color{#35bf28}+23.04\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 3.9793ms 1.8082ms 553.0353 Ops/s 560.9173 Ops/s $\color{#d91a1a}-1.41\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 11.2800ms 1.4010ms 713.7727 Ops/s 733.5182 Ops/s $\color{#d91a1a}-2.69\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 35.8354ms 33.1639ms 30.1532 Ops/s 29.9034 Ops/s $\color{#35bf28}+0.84\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 19.6748ms 17.8862ms 55.9091 Ops/s 55.7376 Ops/s $\color{#35bf28}+0.31\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 36.0812ms 33.9308ms 29.4717 Ops/s 28.1293 Ops/s $\color{#35bf28}+4.77\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 19.5025ms 17.8496ms 56.0236 Ops/s 55.1685 Ops/s $\color{#35bf28}+1.55\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 43.3617ms 36.5284ms 27.3760 Ops/s 27.1154 Ops/s $\color{#35bf28}+0.96\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 20.8655ms 19.2627ms 51.9139 Ops/s 52.4909 Ops/s $\color{#d91a1a}-1.10\%$

@vmoens
Update
7522579 
[ghstack-poisoned]
@vmoens vmoens added bug Something isn't working Tests Incomplete or broken unit tests Refactoring Refactoring of an existing feature labels Nov 6, 2025
vmoens added a commit that referenced this pull request Nov 6, 2025
@vmoens
[BugFix,Test,Refactor] Refactor tests
eb8a885 
ghstack-source-id: 24c338b
Pull-Request: #3232
@vmoens vmoens merged commit 7522579 into gh/vmoens/174/base Nov 6, 2025
50 of 61 checks passed
@vmoens vmoens deleted the gh/vmoens/174/head branch November 6, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Refactoring Refactoring of an existing feature Tests Incomplete or broken unit tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmoens