Skip to content

[Test] Ensure collector shutdown with try/finally #3276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vmoens merged 2 commits into from
Dec 31, 2025
Merged

[Test] Ensure collector shutdown with try/finally #3276

vmoens merged 2 commits into from
Dec 31, 2025

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Dec 31, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@vmoens
Update
b3d3d40 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 31, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3276

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens added a commit that referenced this pull request Dec 31, 2025
@vmoens
[Test] Ensure collector shutdown with try/finally
89df46c 
ghstack-source-id: 8bbc7cb
Pull-Request: #3276
This was referenced Dec 31, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 31, 2025
@vmoens
Update
71e043b 
[ghstack-poisoned]
This was referenced Dec 31, 2025
Merged
Merged
Merged
vmoens added a commit that referenced this pull request Dec 31, 2025
@vmoens
[Test] Ensure collector shutdown with try/finally
aa2b031 
ghstack-source-id: 454705e
Pull-Request: #3276
@vmoens vmoens merged commit 71e043b into gh/vmoens/176/base Dec 31, 2025
78 of 93 checks passed
@vmoens vmoens deleted the gh/vmoens/176/head branch December 31, 2025 09:17
@github-actions
Copy link

github-actions bot commented Dec 31, 2025

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 164. Improved: $\large\color{#35bf28}14$. Worsened: $\large\color{#d91a1a}15$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_tensor_to_bytestream_speed[pickle] 83.6944μs 81.5815μs 12.2577 KOps/s 12.7095 KOps/s $\color{#d91a1a}-3.55\%$
test_tensor_to_bytestream_speed[torch.save] 0.1435ms 0.1431ms 6.9901 KOps/s 7.3274 KOps/s $\color{#d91a1a}-4.60\%$
test_tensor_to_bytestream_speed[untyped_storage] 0.1242s 0.1238s 8.0773 Ops/s 8.7412 Ops/s $\textbf{\color{#d91a1a}-7.59\%}$
test_tensor_to_bytestream_speed[numpy] 2.6463μs 2.6442μs 378.1793 KOps/s 376.0264 KOps/s $\color{#35bf28}+0.57\%$
test_tensor_to_bytestream_speed[safetensors] 38.8241μs 38.4479μs 26.0093 KOps/s 27.0269 KOps/s $\color{#d91a1a}-3.77\%$
test_simple 0.5414s 0.5407s 1.8495 Ops/s 1.7737 Ops/s $\color{#35bf28}+4.27\%$
test_transformed 1.1089s 1.1060s 0.9041 Ops/s 0.8900 Ops/s $\color{#35bf28}+1.59\%$
test_serial 1.6408s 1.6390s 0.6101 Ops/s 0.6045 Ops/s $\color{#35bf28}+0.93\%$
test_parallel 1.3330s 1.1687s 0.8557 Ops/s 0.8252 Ops/s $\color{#35bf28}+3.70\%$
test_step_mdp_speed[True-True-True-True-True] 0.3513ms 43.6918μs 22.8876 KOps/s 22.7282 KOps/s $\color{#35bf28}+0.70\%$
test_step_mdp_speed[True-True-True-True-False] 52.1200μs 24.2024μs 41.3182 KOps/s 40.6000 KOps/s $\color{#35bf28}+1.77\%$
test_step_mdp_speed[True-True-True-False-True] 59.5610μs 24.6246μs 40.6098 KOps/s 40.8346 KOps/s $\color{#d91a1a}-0.55\%$
test_step_mdp_speed[True-True-True-False-False] 47.2210μs 13.3385μs 74.9707 KOps/s 73.6279 KOps/s $\color{#35bf28}+1.82\%$
test_step_mdp_speed[True-True-False-True-True] 83.9820μs 46.1355μs 21.6753 KOps/s 21.3433 KOps/s $\color{#35bf28}+1.56\%$
test_step_mdp_speed[True-True-False-True-False] 56.2910μs 27.2222μs 36.7347 KOps/s 37.3741 KOps/s $\color{#d91a1a}-1.71\%$
test_step_mdp_speed[True-True-False-False-True] 70.3910μs 27.3001μs 36.6299 KOps/s 36.5696 KOps/s $\color{#35bf28}+0.16\%$
test_step_mdp_speed[True-True-False-False-False] 45.3110μs 16.1237μs 62.0206 KOps/s 62.0576 KOps/s $\color{#d91a1a}-0.06\%$
test_step_mdp_speed[True-False-True-True-True] 96.2320μs 49.3399μs 20.2676 KOps/s 20.0324 KOps/s $\color{#35bf28}+1.17\%$
test_step_mdp_speed[True-False-True-True-False] 63.6410μs 29.7264μs 33.6401 KOps/s 33.8107 KOps/s $\color{#d91a1a}-0.50\%$
test_step_mdp_speed[True-False-True-False-True] 61.2710μs 26.6082μs 37.5824 KOps/s 36.7103 KOps/s $\color{#35bf28}+2.38\%$
test_step_mdp_speed[True-False-True-False-False] 50.0210μs 15.9554μs 62.6746 KOps/s 62.1666 KOps/s $\color{#35bf28}+0.82\%$
test_step_mdp_speed[True-False-False-True-True] 0.1469ms 50.0442μs 19.9824 KOps/s 19.2510 KOps/s $\color{#35bf28}+3.80\%$
test_step_mdp_speed[True-False-False-True-False] 65.2410μs 31.9008μs 31.3472 KOps/s 30.6863 KOps/s $\color{#35bf28}+2.15\%$
test_step_mdp_speed[True-False-False-False-True] 59.3210μs 29.6912μs 33.6800 KOps/s 33.5516 KOps/s $\color{#35bf28}+0.38\%$
test_step_mdp_speed[True-False-False-False-False] 59.3010μs 18.4803μs 54.1117 KOps/s 54.8174 KOps/s $\color{#d91a1a}-1.29\%$
test_step_mdp_speed[False-True-True-True-True] 78.1020μs 48.3085μs 20.7003 KOps/s 20.3604 KOps/s $\color{#35bf28}+1.67\%$
test_step_mdp_speed[False-True-True-True-False] 60.0310μs 29.8359μs 33.5167 KOps/s 33.5445 KOps/s $\color{#d91a1a}-0.08\%$
test_step_mdp_speed[False-True-True-False-True] 2.4210ms 30.9740μs 32.2852 KOps/s 32.0846 KOps/s $\color{#35bf28}+0.62\%$
test_step_mdp_speed[False-True-True-False-False] 45.8910μs 17.7786μs 56.2475 KOps/s 56.2879 KOps/s $\color{#d91a1a}-0.07\%$
test_step_mdp_speed[False-True-False-True-True] 80.8810μs 51.7465μs 19.3250 KOps/s 19.2057 KOps/s $\color{#35bf28}+0.62\%$
test_step_mdp_speed[False-True-False-True-False] 60.9610μs 31.8429μs 31.4042 KOps/s 30.6891 KOps/s $\color{#35bf28}+2.33\%$
test_step_mdp_speed[False-True-False-False-True] 68.6910μs 33.2954μs 30.0342 KOps/s 30.1135 KOps/s $\color{#d91a1a}-0.26\%$
test_step_mdp_speed[False-True-False-False-False] 49.3310μs 20.6198μs 48.4972 KOps/s 48.8361 KOps/s $\color{#d91a1a}-0.69\%$
test_step_mdp_speed[False-False-True-True-True] 98.7720μs 54.9995μs 18.1820 KOps/s 18.0284 KOps/s $\color{#35bf28}+0.85\%$
test_step_mdp_speed[False-False-True-True-False] 64.7610μs 35.3270μs 28.3070 KOps/s 28.4344 KOps/s $\color{#d91a1a}-0.45\%$
test_step_mdp_speed[False-False-True-False-True] 68.8710μs 33.4021μs 29.9382 KOps/s 30.2207 KOps/s $\color{#d91a1a}-0.93\%$
test_step_mdp_speed[False-False-True-False-False] 61.7810μs 20.2026μs 49.4986 KOps/s 49.6829 KOps/s $\color{#d91a1a}-0.37\%$
test_step_mdp_speed[False-False-False-True-True] 97.5320μs 56.3162μs 17.7569 KOps/s 17.6526 KOps/s $\color{#35bf28}+0.59\%$
test_step_mdp_speed[False-False-False-True-False] 69.1010μs 36.8381μs 27.1458 KOps/s 26.9864 KOps/s $\color{#35bf28}+0.59\%$
test_step_mdp_speed[False-False-False-False-True] 79.4310μs 34.9753μs 28.5916 KOps/s 28.2106 KOps/s $\color{#35bf28}+1.35\%$
test_step_mdp_speed[False-False-False-False-False] 57.6510μs 22.2536μs 44.9365 KOps/s 43.6099 KOps/s $\color{#35bf28}+3.04\%$
test_non_tensor_env_rollout_speed[1000-single-True] 0.8670s 0.7643s 1.3084 Ops/s 1.3125 Ops/s $\color{#d91a1a}-0.31\%$
test_non_tensor_env_rollout_speed[1000-single-False] 0.7263s 0.6271s 1.5946 Ops/s 1.5934 Ops/s $\color{#35bf28}+0.08\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-True] 1.7463s 1.6665s 0.6001 Ops/s 0.6019 Ops/s $\color{#d91a1a}-0.30\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-False] 1.5246s 1.4489s 0.6902 Ops/s 0.6939 Ops/s $\color{#d91a1a}-0.54\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-True] 1.9893s 1.9104s 0.5234 Ops/s 0.5276 Ops/s $\color{#d91a1a}-0.80\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-False] 1.7628s 1.6856s 0.5933 Ops/s 0.5963 Ops/s $\color{#d91a1a}-0.51\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-True] 4.8896s 4.6438s 0.2153 Ops/s 0.2194 Ops/s $\color{#d91a1a}-1.86\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-False] 4.6120s 4.4811s 0.2232 Ops/s 0.2260 Ops/s $\color{#d91a1a}-1.25\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-True] 2.0467s 1.9365s 0.5164 Ops/s 0.5084 Ops/s $\color{#35bf28}+1.57\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-False] 1.7379s 1.6558s 0.6039 Ops/s 0.6036 Ops/s $\color{#35bf28}+0.05\%$
test_values[generalized_advantage_estimate-True-True] 10.5838ms 10.1819ms 98.2134 Ops/s 103.3457 Ops/s $\color{#d91a1a}-4.97\%$
test_values[vec_generalized_advantage_estimate-True-True] 14.0053ms 11.5447ms 86.6197 Ops/s 57.0470 Ops/s $\textbf{\color{#35bf28}+51.84\%}$
test_values[td0_return_estimate-False-False] 0.2464ms 0.1289ms 7.7609 KOps/s 7.8277 KOps/s $\color{#d91a1a}-0.85\%$
test_values[td1_return_estimate-False-False] 27.8493ms 27.4928ms 36.3731 Ops/s 38.5114 Ops/s $\textbf{\color{#d91a1a}-5.55\%}$
test_values[vec_td1_return_estimate-False-False] 12.3510ms 11.3942ms 87.7642 Ops/s 56.1691 Ops/s $\textbf{\color{#35bf28}+56.25\%}$
test_values[td_lambda_return_estimate-True-False] 41.1180ms 40.7019ms 24.5689 Ops/s 26.2228 Ops/s $\textbf{\color{#d91a1a}-6.31\%}$
test_values[vec_td_lambda_return_estimate-True-False] 12.2002ms 11.2250ms 89.0868 Ops/s 57.2367 Ops/s $\textbf{\color{#35bf28}+55.65\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 9.1101ms 9.0004ms 111.1061 Ops/s 116.7734 Ops/s $\color{#d91a1a}-4.85\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.9719ms 1.5442ms 647.5805 Ops/s 659.7707 Ops/s $\color{#d91a1a}-1.85\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5126ms 0.4087ms 2.4465 KOps/s 2.5359 KOps/s $\color{#d91a1a}-3.52\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 29.7930ms 29.2565ms 34.1805 Ops/s 28.7110 Ops/s $\textbf{\color{#35bf28}+19.05\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 2.2645ms 1.8137ms 551.3585 Ops/s 563.1243 Ops/s $\color{#d91a1a}-2.09\%$
test_dqn_speed[False-None] 1.8898ms 1.3643ms 732.9832 Ops/s 739.0679 Ops/s $\color{#d91a1a}-0.82\%$
test_dqn_speed[False-backward] 1.9624ms 1.8883ms 529.5837 Ops/s 543.5272 Ops/s $\color{#d91a1a}-2.57\%$
test_dqn_speed[True-None] 0.7216ms 0.5262ms 1.9005 KOps/s 1.9270 KOps/s $\color{#d91a1a}-1.38\%$
test_dqn_speed[True-backward] 1.0172ms 0.9627ms 1.0388 KOps/s 911.0309 Ops/s $\textbf{\color{#35bf28}+14.02\%}$
test_dqn_speed[reduce-overhead-None] 0.7763ms 0.5305ms 1.8849 KOps/s 1.9434 KOps/s $\color{#d91a1a}-3.01\%$
test_dqn_speed[reduce-overhead-backward] 0.9906ms 0.9487ms 1.0541 KOps/s 1.0468 KOps/s $\color{#35bf28}+0.69\%$
test_ddpg_speed[False-None] 3.1266ms 2.7841ms 359.1785 Ops/s 360.2716 Ops/s $\color{#d91a1a}-0.30\%$
test_ddpg_speed[False-backward] 4.0342ms 3.9445ms 253.5185 Ops/s 252.8422 Ops/s $\color{#35bf28}+0.27\%$
test_ddpg_speed[True-None] 1.7470ms 1.3606ms 734.9620 Ops/s 729.3404 Ops/s $\color{#35bf28}+0.77\%$
test_ddpg_speed[True-backward] 2.4191ms 2.3414ms 427.1017 Ops/s 393.6838 Ops/s $\textbf{\color{#35bf28}+8.49\%}$
test_ddpg_speed[reduce-overhead-None] 1.6178ms 1.3632ms 733.5792 Ops/s 718.3041 Ops/s $\color{#35bf28}+2.13\%$
test_ddpg_speed[reduce-overhead-backward] 2.4057ms 2.3143ms 432.0937 Ops/s 433.6627 Ops/s $\color{#d91a1a}-0.36\%$
test_sac_speed[False-None] 8.2051ms 7.7514ms 129.0084 Ops/s 128.3028 Ops/s $\color{#35bf28}+0.55\%$
test_sac_speed[False-backward] 11.2494ms 10.9102ms 91.6570 Ops/s 92.4874 Ops/s $\color{#d91a1a}-0.90\%$
test_sac_speed[True-None] 2.4685ms 2.0935ms 477.6734 Ops/s 470.8439 Ops/s $\color{#35bf28}+1.45\%$
test_sac_speed[True-backward] 4.0355ms 3.9277ms 254.6022 Ops/s 232.1088 Ops/s $\textbf{\color{#35bf28}+9.69\%}$
test_sac_speed[reduce-overhead-None] 2.4406ms 2.0747ms 481.9960 Ops/s 468.9359 Ops/s $\color{#35bf28}+2.79\%$
test_sac_speed[reduce-overhead-backward] 4.0738ms 3.9599ms 252.5337 Ops/s 231.8494 Ops/s $\textbf{\color{#35bf28}+8.92\%}$
test_redq_speed[False-None] 10.6956ms 10.2069ms 97.9732 Ops/s 97.0043 Ops/s $\color{#35bf28}+1.00\%$
test_redq_speed[False-backward] 18.1007ms 17.5155ms 57.0923 Ops/s 56.1427 Ops/s $\color{#35bf28}+1.69\%$
test_redq_speed[True-None] 4.6058ms 4.3929ms 227.6400 Ops/s 227.6062 Ops/s $\color{#35bf28}+0.01\%$
test_redq_speed[True-backward] 10.0904ms 9.6613ms 103.5052 Ops/s 102.1828 Ops/s $\color{#35bf28}+1.29\%$
test_redq_speed[reduce-overhead-None] 4.5165ms 4.2724ms 234.0608 Ops/s 225.7622 Ops/s $\color{#35bf28}+3.68\%$
test_redq_speed[reduce-overhead-backward] 9.9949ms 9.7018ms 103.0737 Ops/s 102.3886 Ops/s $\color{#35bf28}+0.67\%$
test_redq_deprec_speed[False-None] 11.1305ms 10.7092ms 93.3776 Ops/s 93.2446 Ops/s $\color{#35bf28}+0.14\%$
test_redq_deprec_speed[False-backward] 15.9109ms 15.3361ms 65.2057 Ops/s 65.1450 Ops/s $\color{#35bf28}+0.09\%$
test_redq_deprec_speed[True-None] 3.8103ms 3.6106ms 276.9652 Ops/s 269.1879 Ops/s $\color{#35bf28}+2.89\%$
test_redq_deprec_speed[True-backward] 7.6572ms 7.3848ms 135.4133 Ops/s 131.1661 Ops/s $\color{#35bf28}+3.24\%$
test_redq_deprec_speed[reduce-overhead-None] 3.9328ms 3.5629ms 280.6705 Ops/s 280.9562 Ops/s $\color{#d91a1a}-0.10\%$
test_redq_deprec_speed[reduce-overhead-backward] 7.9226ms 7.4842ms 133.6156 Ops/s 132.0781 Ops/s $\color{#35bf28}+1.16\%$
test_td3_speed[False-None] 8.1755ms 8.0212ms 124.6698 Ops/s 128.4795 Ops/s $\color{#d91a1a}-2.97\%$
test_td3_speed[False-backward] 11.1063ms 10.7150ms 93.3272 Ops/s 95.1288 Ops/s $\color{#d91a1a}-1.89\%$
test_td3_speed[True-None] 1.8054ms 1.7617ms 567.6180 Ops/s 559.3498 Ops/s $\color{#35bf28}+1.48\%$
test_td3_speed[True-backward] 3.9560ms 3.6128ms 276.7918 Ops/s 252.0929 Ops/s $\textbf{\color{#35bf28}+9.80\%}$
test_td3_speed[reduce-overhead-None] 1.7986ms 1.7560ms 569.4693 Ops/s 563.3304 Ops/s $\color{#35bf28}+1.09\%$
test_td3_speed[reduce-overhead-backward] 3.7026ms 3.5981ms 277.9212 Ops/s 279.3355 Ops/s $\color{#d91a1a}-0.51\%$
test_cql_speed[False-None] 28.5843ms 25.6811ms 38.9392 Ops/s 39.5488 Ops/s $\color{#d91a1a}-1.54\%$
test_cql_speed[False-backward] 35.1308ms 34.5158ms 28.9722 Ops/s 29.1708 Ops/s $\color{#d91a1a}-0.68\%$
test_cql_speed[True-None] 12.7782ms 12.3318ms 81.0909 Ops/s 80.2432 Ops/s $\color{#35bf28}+1.06\%$
test_cql_speed[True-backward] 18.8800ms 18.4534ms 54.1906 Ops/s 57.6711 Ops/s $\textbf{\color{#d91a1a}-6.04\%}$
test_cql_speed[reduce-overhead-None] 12.9432ms 12.4712ms 80.1845 Ops/s 79.9593 Ops/s $\color{#35bf28}+0.28\%$
test_cql_speed[reduce-overhead-backward] 19.2637ms 18.4115ms 54.3138 Ops/s 56.6453 Ops/s $\color{#d91a1a}-4.12\%$
test_a2c_speed[False-None] 5.8871ms 5.3693ms 186.2435 Ops/s 184.2483 Ops/s $\color{#35bf28}+1.08\%$
test_a2c_speed[False-backward] 12.1393ms 11.7107ms 85.3922 Ops/s 85.5210 Ops/s $\color{#d91a1a}-0.15\%$
test_a2c_speed[True-None] 4.0552ms 3.6320ms 275.3341 Ops/s 266.8050 Ops/s $\color{#35bf28}+3.20\%$
test_a2c_speed[True-backward] 8.7567ms 8.5452ms 117.0254 Ops/s 111.4175 Ops/s $\textbf{\color{#35bf28}+5.03\%}$
test_a2c_speed[reduce-overhead-None] 3.9991ms 3.6712ms 272.3881 Ops/s 273.7001 Ops/s $\color{#d91a1a}-0.48\%$
test_a2c_speed[reduce-overhead-backward] 8.7765ms 8.6051ms 116.2100 Ops/s 111.2276 Ops/s $\color{#35bf28}+4.48\%$
test_ppo_speed[False-None] 5.9594ms 5.6692ms 176.3928 Ops/s 175.9207 Ops/s $\color{#35bf28}+0.27\%$
test_ppo_speed[False-backward] 12.6561ms 12.1830ms 82.0813 Ops/s 82.9732 Ops/s $\color{#d91a1a}-1.07\%$
test_ppo_speed[True-None] 3.8775ms 3.5986ms 277.8843 Ops/s 272.9413 Ops/s $\color{#35bf28}+1.81\%$
test_ppo_speed[True-backward] 8.5738ms 8.4076ms 118.9396 Ops/s 115.4690 Ops/s $\color{#35bf28}+3.01\%$
test_ppo_speed[reduce-overhead-None] 3.7328ms 3.5408ms 282.4258 Ops/s 273.5252 Ops/s $\color{#35bf28}+3.25\%$
test_ppo_speed[reduce-overhead-backward] 8.8596ms 8.6357ms 115.7986 Ops/s 113.6463 Ops/s $\color{#35bf28}+1.89\%$
test_reinforce_speed[False-None] 4.8369ms 4.5099ms 221.7367 Ops/s 218.4556 Ops/s $\color{#35bf28}+1.50\%$
test_reinforce_speed[False-backward] 7.6114ms 7.2997ms 136.9920 Ops/s 136.5583 Ops/s $\color{#35bf28}+0.32\%$
test_reinforce_speed[True-None] 3.2903ms 2.8536ms 350.4302 Ops/s 336.9647 Ops/s $\color{#35bf28}+4.00\%$
test_reinforce_speed[True-backward] 8.0207ms 7.5811ms 131.9076 Ops/s 129.6621 Ops/s $\color{#35bf28}+1.73\%$
test_reinforce_speed[reduce-overhead-None] 3.2096ms 2.8243ms 354.0756 Ops/s 348.4403 Ops/s $\color{#35bf28}+1.62\%$
test_reinforce_speed[reduce-overhead-backward] 8.1702ms 7.8871ms 126.7898 Ops/s 126.7146 Ops/s $\color{#35bf28}+0.06\%$
test_iql_speed[False-None] 20.4731ms 19.7594ms 50.6088 Ops/s 50.8213 Ops/s $\color{#d91a1a}-0.42\%$
test_iql_speed[False-backward] 30.9079ms 30.0763ms 33.2488 Ops/s 33.3724 Ops/s $\color{#d91a1a}-0.37\%$
test_iql_speed[True-None] 11.3605ms 8.4653ms 118.1296 Ops/s 114.1683 Ops/s $\color{#35bf28}+3.47\%$
test_iql_speed[True-backward] 17.0328ms 16.6465ms 60.0727 Ops/s 60.1261 Ops/s $\color{#d91a1a}-0.09\%$
test_iql_speed[reduce-overhead-None] 9.0053ms 8.4495ms 118.3497 Ops/s 115.6450 Ops/s $\color{#35bf28}+2.34\%$
test_iql_speed[reduce-overhead-backward] 17.6617ms 17.2066ms 58.1173 Ops/s 58.8848 Ops/s $\color{#d91a1a}-1.30\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.8878ms 5.9387ms 168.3877 Ops/s 170.7673 Ops/s $\color{#d91a1a}-1.39\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.5535ms 0.2930ms 3.4129 KOps/s 3.5898 KOps/s $\color{#d91a1a}-4.93\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7585ms 0.3390ms 2.9501 KOps/s 3.6521 KOps/s $\textbf{\color{#d91a1a}-19.22\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.8953ms 5.6677ms 176.4386 Ops/s 179.2124 Ops/s $\color{#d91a1a}-1.55\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.1127ms 0.2889ms 3.4613 KOps/s 1.2612 KOps/s $\textbf{\color{#35bf28}+174.45\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5651ms 0.3224ms 3.1020 KOps/s 3.4195 KOps/s $\textbf{\color{#d91a1a}-9.29\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.5796ms 1.2819ms 780.0637 Ops/s 828.4796 Ops/s $\textbf{\color{#d91a1a}-5.84\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.5583ms 1.2079ms 827.8884 Ops/s 837.2712 Ops/s $\color{#d91a1a}-1.12\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 9.5464ms 5.9240ms 168.8049 Ops/s 172.7184 Ops/s $\color{#d91a1a}-2.27\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.2458ms 0.4820ms 2.0747 KOps/s 2.1760 KOps/s $\color{#d91a1a}-4.66\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.6940ms 0.4493ms 2.2256 KOps/s 2.2085 KOps/s $\color{#35bf28}+0.77\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.7543ms 5.6361ms 177.4292 Ops/s 175.9327 Ops/s $\color{#35bf28}+0.85\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0444ms 0.3184ms 3.1404 KOps/s 3.4668 KOps/s $\textbf{\color{#d91a1a}-9.42\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.4925ms 0.2694ms 3.7113 KOps/s 3.9061 KOps/s $\color{#d91a1a}-4.99\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.9810ms 5.5893ms 178.9130 Ops/s 178.5834 Ops/s $\color{#35bf28}+0.18\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9653ms 0.3516ms 2.8438 KOps/s 3.6908 KOps/s $\textbf{\color{#d91a1a}-22.95\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5565ms 0.3619ms 2.7631 KOps/s 3.5031 KOps/s $\textbf{\color{#d91a1a}-21.12\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.8797ms 5.8004ms 172.4020 Ops/s 172.4460 Ops/s $\color{#d91a1a}-0.03\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.4003ms 0.4638ms 2.1559 KOps/s 2.3707 KOps/s $\textbf{\color{#d91a1a}-9.06\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.5844ms 0.4081ms 2.4504 KOps/s 2.4929 KOps/s $\color{#d91a1a}-1.71\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 6.2597ms 4.8419ms 206.5291 Ops/s 199.5643 Ops/s $\color{#35bf28}+3.49\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 6.3673ms 2.3261ms 429.8989 Ops/s 426.6224 Ops/s $\color{#35bf28}+0.77\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 9.1061ms 1.2274ms 814.7587 Ops/s 68.0833 Ops/s $\textbf{\color{#35bf28}+1096.71\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 7.5392ms 4.9765ms 200.9428 Ops/s 199.5462 Ops/s $\color{#35bf28}+0.70\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 8.1218ms 2.3433ms 426.7532 Ops/s 474.0037 Ops/s $\textbf{\color{#d91a1a}-9.97\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 7.8178ms 1.2229ms 817.7502 Ops/s 932.7827 Ops/s $\textbf{\color{#d91a1a}-12.33\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.6142s 17.3693ms 57.5727 Ops/s 192.9030 Ops/s $\textbf{\color{#d91a1a}-70.15\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 4.0934ms 1.8978ms 526.9282 Ops/s 461.5688 Ops/s $\textbf{\color{#35bf28}+14.16\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 8.1087ms 1.3640ms 733.1232 Ops/s 955.0053 Ops/s $\textbf{\color{#d91a1a}-23.23\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 36.9155ms 34.7230ms 28.7993 Ops/s 29.6884 Ops/s $\color{#d91a1a}-2.99\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 19.4898ms 17.5625ms 56.9394 Ops/s 58.1497 Ops/s $\color{#d91a1a}-2.08\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 38.2608ms 35.6241ms 28.0709 Ops/s 28.2675 Ops/s $\color{#d91a1a}-0.70\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 20.0134ms 18.1813ms 55.0017 Ops/s 33.1188 Ops/s $\textbf{\color{#35bf28}+66.07\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 39.4658ms 37.2106ms 26.8741 Ops/s 26.8782 Ops/s $\color{#d91a1a}-0.02\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 21.3435ms 19.5477ms 51.1570 Ops/s 51.1285 Ops/s $\color{#35bf28}+0.06\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmoens