Skip to content

[Environment] Fix envpool wrapper #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vmoens merged 3 commits into from
Jan 17, 2026
Merged

[Environment] Fix envpool wrapper #3339

vmoens merged 3 commits into from
Jan 17, 2026

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Jan 17, 2026

No description provided.

@vmoens vmoens added the Environments Adds or modifies an environment wrapper label Jan 17, 2026
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 17, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3339

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2026
@vmoens vmoens merged commit 2358bda into main Jan 17, 2026
33 of 37 checks passed
@vmoens vmoens deleted the fix-envpool2 branch January 17, 2026 03:55
@github-actions
Copy link

github-actions bot commented Jan 17, 2026

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 164. Improved: $\large\color{#35bf28}20$. Worsened: $\large\color{#d91a1a}12$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_tensor_to_bytestream_speed[pickle] 82.9160μs 81.2897μs 12.3017 KOps/s 12.1069 KOps/s $\color{#35bf28}+1.61\%$
test_tensor_to_bytestream_speed[torch.save] 0.1429ms 0.1418ms 7.0544 KOps/s 7.0633 KOps/s $\color{#d91a1a}-0.13\%$
test_tensor_to_bytestream_speed[untyped_storage] 0.1288s 0.1284s 7.7858 Ops/s 7.6832 Ops/s $\color{#35bf28}+1.33\%$
test_tensor_to_bytestream_speed[numpy] 2.7611μs 2.7527μs 363.2779 KOps/s 367.2190 KOps/s $\color{#d91a1a}-1.07\%$
test_tensor_to_bytestream_speed[safetensors] 41.4397μs 41.0896μs 24.3371 KOps/s 25.7881 KOps/s $\textbf{\color{#d91a1a}-5.63\%}$
test_simple 0.5562s 0.5522s 1.8109 Ops/s 1.7343 Ops/s $\color{#35bf28}+4.42\%$
test_transformed 1.1315s 1.1308s 0.8844 Ops/s 0.8651 Ops/s $\color{#35bf28}+2.22\%$
test_serial 1.6890s 1.6848s 0.5935 Ops/s 0.5857 Ops/s $\color{#35bf28}+1.34\%$
test_parallel 1.2284s 1.1335s 0.8822 Ops/s 0.8618 Ops/s $\color{#35bf28}+2.37\%$
test_step_mdp_speed[True-True-True-True-True] 0.3422ms 45.1259μs 22.1602 KOps/s 22.5561 KOps/s $\color{#d91a1a}-1.76\%$
test_step_mdp_speed[True-True-True-True-False] 57.9640μs 25.4058μs 39.3611 KOps/s 39.6378 KOps/s $\color{#d91a1a}-0.70\%$
test_step_mdp_speed[True-True-True-False-True] 57.4540μs 25.1256μs 39.8000 KOps/s 39.4640 KOps/s $\color{#35bf28}+0.85\%$
test_step_mdp_speed[True-True-True-False-False] 44.2430μs 14.0254μs 71.2992 KOps/s 71.6184 KOps/s $\color{#d91a1a}-0.45\%$
test_step_mdp_speed[True-True-False-True-True] 84.6050μs 48.5141μs 20.6126 KOps/s 20.7104 KOps/s $\color{#d91a1a}-0.47\%$
test_step_mdp_speed[True-True-False-True-False] 87.9160μs 28.0968μs 35.5912 KOps/s 35.6616 KOps/s $\color{#d91a1a}-0.20\%$
test_step_mdp_speed[True-True-False-False-True] 55.7740μs 28.3641μs 35.2558 KOps/s 35.8883 KOps/s $\color{#d91a1a}-1.76\%$
test_step_mdp_speed[True-True-False-False-False] 49.2140μs 17.0283μs 58.7256 KOps/s 59.3522 KOps/s $\color{#d91a1a}-1.06\%$
test_step_mdp_speed[True-False-True-True-True] 83.5860μs 51.7340μs 19.3296 KOps/s 19.6160 KOps/s $\color{#d91a1a}-1.46\%$
test_step_mdp_speed[True-False-True-True-False] 63.1550μs 30.7369μs 32.5342 KOps/s 31.9351 KOps/s $\color{#35bf28}+1.88\%$
test_step_mdp_speed[True-False-True-False-True] 53.7540μs 28.2591μs 35.3869 KOps/s 35.4595 KOps/s $\color{#d91a1a}-0.20\%$
test_step_mdp_speed[True-False-True-False-False] 44.9330μs 16.8588μs 59.3162 KOps/s 59.4529 KOps/s $\color{#d91a1a}-0.23\%$
test_step_mdp_speed[True-False-False-True-True] 0.1203ms 53.5742μs 18.6657 KOps/s 18.6944 KOps/s $\color{#d91a1a}-0.15\%$
test_step_mdp_speed[True-False-False-True-False] 63.4540μs 33.6041μs 29.7583 KOps/s 29.4613 KOps/s $\color{#35bf28}+1.01\%$
test_step_mdp_speed[True-False-False-False-True] 62.3840μs 30.5777μs 32.7036 KOps/s 32.6711 KOps/s $\color{#35bf28}+0.10\%$
test_step_mdp_speed[True-False-False-False-False] 85.4350μs 19.4387μs 51.4438 KOps/s 51.2865 KOps/s $\color{#35bf28}+0.31\%$
test_step_mdp_speed[False-True-True-True-True] 83.7450μs 51.3046μs 19.4914 KOps/s 19.3820 KOps/s $\color{#35bf28}+0.56\%$
test_step_mdp_speed[False-True-True-True-False] 67.4450μs 30.6020μs 32.6776 KOps/s 32.2137 KOps/s $\color{#35bf28}+1.44\%$
test_step_mdp_speed[False-True-True-False-True] 2.3410ms 31.9922μs 31.2576 KOps/s 31.3957 KOps/s $\color{#d91a1a}-0.44\%$
test_step_mdp_speed[False-True-True-False-False] 56.8640μs 18.4891μs 54.0858 KOps/s 53.2933 KOps/s $\color{#35bf28}+1.49\%$
test_step_mdp_speed[False-True-False-True-True] 89.3860μs 53.9828μs 18.5244 KOps/s 18.5894 KOps/s $\color{#d91a1a}-0.35\%$
test_step_mdp_speed[False-True-False-True-False] 67.7140μs 33.6098μs 29.7532 KOps/s 29.2517 KOps/s $\color{#35bf28}+1.71\%$
test_step_mdp_speed[False-True-False-False-True] 66.5940μs 34.4213μs 29.0518 KOps/s 28.9839 KOps/s $\color{#35bf28}+0.23\%$
test_step_mdp_speed[False-True-False-False-False] 56.4040μs 21.0937μs 47.4075 KOps/s 46.4109 KOps/s $\color{#35bf28}+2.15\%$
test_step_mdp_speed[False-False-True-True-True] 97.0970μs 56.6676μs 17.6468 KOps/s 17.6733 KOps/s $\color{#d91a1a}-0.15\%$
test_step_mdp_speed[False-False-True-True-False] 67.7750μs 36.1833μs 27.6371 KOps/s 27.0712 KOps/s $\color{#35bf28}+2.09\%$
test_step_mdp_speed[False-False-True-False-True] 74.7750μs 34.1553μs 29.2780 KOps/s 28.8689 KOps/s $\color{#35bf28}+1.42\%$
test_step_mdp_speed[False-False-True-False-False] 51.6240μs 21.1320μs 47.3216 KOps/s 47.4376 KOps/s $\color{#d91a1a}-0.24\%$
test_step_mdp_speed[False-False-False-True-True] 93.2860μs 57.3355μs 17.4412 KOps/s 17.1486 KOps/s $\color{#35bf28}+1.71\%$
test_step_mdp_speed[False-False-False-True-False] 74.3750μs 38.2261μs 26.1601 KOps/s 25.5878 KOps/s $\color{#35bf28}+2.24\%$
test_step_mdp_speed[False-False-False-False-True] 72.4850μs 36.6329μs 27.2979 KOps/s 27.3593 KOps/s $\color{#d91a1a}-0.22\%$
test_step_mdp_speed[False-False-False-False-False] 60.5640μs 23.5736μs 42.4204 KOps/s 42.2089 KOps/s $\color{#35bf28}+0.50\%$
test_non_tensor_env_rollout_speed[1000-single-True] 0.8743s 0.7731s 1.2934 Ops/s 1.2950 Ops/s $\color{#d91a1a}-0.12\%$
test_non_tensor_env_rollout_speed[1000-single-False] 0.7336s 0.6346s 1.5759 Ops/s 1.5682 Ops/s $\color{#35bf28}+0.49\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-True] 1.7745s 1.6916s 0.5912 Ops/s 0.5913 Ops/s $\color{#d91a1a}-0.02\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-False] 1.5449s 1.4660s 0.6821 Ops/s 0.6816 Ops/s $\color{#35bf28}+0.08\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-True] 2.0196s 1.9351s 0.5168 Ops/s 0.5137 Ops/s $\color{#35bf28}+0.59\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-False] 1.7925s 1.7139s 0.5835 Ops/s 0.5806 Ops/s $\color{#35bf28}+0.50\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-True] 4.8964s 4.7207s 0.2118 Ops/s 0.2112 Ops/s $\color{#35bf28}+0.31\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-False] 4.5753s 4.5296s 0.2208 Ops/s 0.2232 Ops/s $\color{#d91a1a}-1.07\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-True] 2.0805s 2.0074s 0.4982 Ops/s 0.5071 Ops/s $\color{#d91a1a}-1.76\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-False] 1.7620s 1.6836s 0.5940 Ops/s 0.5902 Ops/s $\color{#35bf28}+0.64\%$
test_values[generalized_advantage_estimate-True-True] 11.0995ms 10.7064ms 93.4021 Ops/s 94.7148 Ops/s $\color{#d91a1a}-1.39\%$
test_values[vec_generalized_advantage_estimate-True-True] 15.4614ms 11.1153ms 89.9657 Ops/s 90.0449 Ops/s $\color{#d91a1a}-0.09\%$
test_values[td0_return_estimate-False-False] 0.2259ms 0.1308ms 7.6431 KOps/s 7.9593 KOps/s $\color{#d91a1a}-3.97\%$
test_values[td1_return_estimate-False-False] 29.5923ms 28.9892ms 34.4956 Ops/s 35.1945 Ops/s $\color{#d91a1a}-1.99\%$
test_values[vec_td1_return_estimate-False-False] 11.3744ms 11.1591ms 89.6132 Ops/s 89.4527 Ops/s $\color{#35bf28}+0.18\%$
test_values[td_lambda_return_estimate-True-False] 44.5014ms 43.5116ms 22.9824 Ops/s 23.7987 Ops/s $\color{#d91a1a}-3.43\%$
test_values[vec_td_lambda_return_estimate-True-False] 11.3663ms 11.1429ms 89.7435 Ops/s 90.5513 Ops/s $\color{#d91a1a}-0.89\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 9.5999ms 9.3914ms 106.4808 Ops/s 107.6375 Ops/s $\color{#d91a1a}-1.07\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.7562ms 1.5755ms 634.7174 Ops/s 656.4689 Ops/s $\color{#d91a1a}-3.31\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7991ms 0.4368ms 2.2892 KOps/s 2.3596 KOps/s $\color{#d91a1a}-2.98\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 30.1741ms 28.6846ms 34.8620 Ops/s 43.4376 Ops/s $\textbf{\color{#d91a1a}-19.74\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 2.1185ms 1.7271ms 579.0097 Ops/s 579.9398 Ops/s $\color{#d91a1a}-0.16\%$
test_dqn_speed[False-None] 1.8038ms 1.4604ms 684.7579 Ops/s 712.0507 Ops/s $\color{#d91a1a}-3.83\%$
test_dqn_speed[False-backward] 2.0383ms 2.0001ms 499.9648 Ops/s 519.1368 Ops/s $\color{#d91a1a}-3.69\%$
test_dqn_speed[True-None] 0.9358ms 0.5418ms 1.8457 KOps/s 1.8398 KOps/s $\color{#35bf28}+0.32\%$
test_dqn_speed[True-backward] 1.0688ms 1.0035ms 996.4700 Ops/s 1.0016 KOps/s $\color{#d91a1a}-0.51\%$
test_dqn_speed[reduce-overhead-None] 0.9220ms 0.5320ms 1.8797 KOps/s 1.8804 KOps/s $\color{#d91a1a}-0.04\%$
test_dqn_speed[reduce-overhead-backward] 1.0392ms 0.9839ms 1.0164 KOps/s 995.5861 Ops/s $\color{#35bf28}+2.09\%$
test_ddpg_speed[False-None] 3.2081ms 2.8862ms 346.4714 Ops/s 341.7318 Ops/s $\color{#35bf28}+1.39\%$
test_ddpg_speed[False-backward] 4.2701ms 4.1059ms 243.5541 Ops/s 242.3031 Ops/s $\color{#35bf28}+0.52\%$
test_ddpg_speed[True-None] 1.6239ms 1.4161ms 706.1598 Ops/s 709.3809 Ops/s $\color{#d91a1a}-0.45\%$
test_ddpg_speed[True-backward] 2.5002ms 2.4043ms 415.9229 Ops/s 368.3674 Ops/s $\textbf{\color{#35bf28}+12.91\%}$
test_ddpg_speed[reduce-overhead-None] 2.4845ms 1.5186ms 658.4852 Ops/s 693.5846 Ops/s $\textbf{\color{#d91a1a}-5.06\%}$
test_ddpg_speed[reduce-overhead-backward] 2.4501ms 2.3902ms 418.3716 Ops/s 379.6581 Ops/s $\textbf{\color{#35bf28}+10.20\%}$
test_sac_speed[False-None] 8.6065ms 8.1072ms 123.3473 Ops/s 123.6530 Ops/s $\color{#d91a1a}-0.25\%$
test_sac_speed[False-backward] 11.8463ms 11.3936ms 87.7683 Ops/s 87.6509 Ops/s $\color{#35bf28}+0.13\%$
test_sac_speed[True-None] 2.5175ms 2.1451ms 466.1786 Ops/s 467.2289 Ops/s $\color{#d91a1a}-0.22\%$
test_sac_speed[True-backward] 4.1005ms 4.0295ms 248.1694 Ops/s 248.2745 Ops/s $\color{#d91a1a}-0.04\%$
test_sac_speed[reduce-overhead-None] 2.3691ms 2.1376ms 467.8157 Ops/s 454.0727 Ops/s $\color{#35bf28}+3.03\%$
test_sac_speed[reduce-overhead-backward] 4.2268ms 4.0409ms 247.4720 Ops/s 221.0574 Ops/s $\textbf{\color{#35bf28}+11.95\%}$
test_redq_speed[False-None] 10.9272ms 10.3494ms 96.6235 Ops/s 96.2485 Ops/s $\color{#35bf28}+0.39\%$
test_redq_speed[False-backward] 18.5035ms 17.6304ms 56.7201 Ops/s 57.6896 Ops/s $\color{#d91a1a}-1.68\%$
test_redq_speed[True-None] 4.6445ms 4.3682ms 228.9251 Ops/s 221.8280 Ops/s $\color{#35bf28}+3.20\%$
test_redq_speed[True-backward] 10.0380ms 9.7933ms 102.1104 Ops/s 106.6523 Ops/s $\color{#d91a1a}-4.26\%$
test_redq_speed[reduce-overhead-None] 4.5980ms 4.3810ms 228.2573 Ops/s 225.0776 Ops/s $\color{#35bf28}+1.41\%$
test_redq_speed[reduce-overhead-backward] 10.1570ms 9.8624ms 101.3951 Ops/s 105.2621 Ops/s $\color{#d91a1a}-3.67\%$
test_redq_deprec_speed[False-None] 11.6109ms 11.1973ms 89.3076 Ops/s 88.9642 Ops/s $\color{#35bf28}+0.39\%$
test_redq_deprec_speed[False-backward] 16.4486ms 16.0296ms 62.3845 Ops/s 62.2139 Ops/s $\color{#35bf28}+0.27\%$
test_redq_deprec_speed[True-None] 3.9584ms 3.6808ms 271.6828 Ops/s 274.5556 Ops/s $\color{#d91a1a}-1.05\%$
test_redq_deprec_speed[True-backward] 8.1094ms 7.6167ms 131.2904 Ops/s 133.8930 Ops/s $\color{#d91a1a}-1.94\%$
test_redq_deprec_speed[reduce-overhead-None] 4.0036ms 3.6212ms 276.1481 Ops/s 267.8645 Ops/s $\color{#35bf28}+3.09\%$
test_redq_deprec_speed[reduce-overhead-backward] 8.1645ms 7.6108ms 131.3922 Ops/s 134.3554 Ops/s $\color{#d91a1a}-2.21\%$
test_td3_speed[False-None] 8.3471ms 8.1303ms 122.9974 Ops/s 121.7647 Ops/s $\color{#35bf28}+1.01\%$
test_td3_speed[False-backward] 11.5384ms 11.0646ms 90.3786 Ops/s 90.8257 Ops/s $\color{#d91a1a}-0.49\%$
test_td3_speed[True-None] 1.8736ms 1.8213ms 549.0631 Ops/s 562.4289 Ops/s $\color{#d91a1a}-2.38\%$
test_td3_speed[True-backward] 3.9743ms 3.6371ms 274.9464 Ops/s 285.5024 Ops/s $\color{#d91a1a}-3.70\%$
test_td3_speed[reduce-overhead-None] 1.8261ms 1.7768ms 562.7989 Ops/s 572.9986 Ops/s $\color{#d91a1a}-1.78\%$
test_td3_speed[reduce-overhead-backward] 3.7337ms 3.6319ms 275.3370 Ops/s 283.9612 Ops/s $\color{#d91a1a}-3.04\%$
test_cql_speed[False-None] 28.9057ms 26.2322ms 38.1211 Ops/s 39.0334 Ops/s $\color{#d91a1a}-2.34\%$
test_cql_speed[False-backward] 38.9601ms 35.7348ms 27.9839 Ops/s 28.6488 Ops/s $\color{#d91a1a}-2.32\%$
test_cql_speed[True-None] 12.8852ms 12.3452ms 81.0034 Ops/s 82.0468 Ops/s $\color{#d91a1a}-1.27\%$
test_cql_speed[True-backward] 19.1628ms 18.4291ms 54.2619 Ops/s 55.4750 Ops/s $\color{#d91a1a}-2.19\%$
test_cql_speed[reduce-overhead-None] 13.1829ms 12.5284ms 79.8189 Ops/s 81.4022 Ops/s $\color{#d91a1a}-1.95\%$
test_cql_speed[reduce-overhead-backward] 19.0227ms 18.4121ms 54.3121 Ops/s 56.3152 Ops/s $\color{#d91a1a}-3.56\%$
test_a2c_speed[False-None] 6.1990ms 5.4690ms 182.8492 Ops/s 180.1176 Ops/s $\color{#35bf28}+1.52\%$
test_a2c_speed[False-backward] 12.4321ms 12.1105ms 82.5729 Ops/s 83.8885 Ops/s $\color{#d91a1a}-1.57\%$
test_a2c_speed[True-None] 3.9148ms 3.7444ms 267.0658 Ops/s 283.9014 Ops/s $\textbf{\color{#d91a1a}-5.93\%}$
test_a2c_speed[True-backward] 8.9737ms 8.7415ms 114.3963 Ops/s 110.2700 Ops/s $\color{#35bf28}+3.74\%$
test_a2c_speed[reduce-overhead-None] 3.8346ms 3.7330ms 267.8800 Ops/s 290.1958 Ops/s $\textbf{\color{#d91a1a}-7.69\%}$
test_a2c_speed[reduce-overhead-backward] 8.8887ms 8.7098ms 114.8133 Ops/s 119.7760 Ops/s $\color{#d91a1a}-4.14\%$
test_ppo_speed[False-None] 6.3137ms 5.9771ms 167.3041 Ops/s 178.2393 Ops/s $\textbf{\color{#d91a1a}-6.14\%}$
test_ppo_speed[False-backward] 12.8876ms 12.6184ms 79.2494 Ops/s 80.8553 Ops/s $\color{#d91a1a}-1.99\%$
test_ppo_speed[True-None] 4.2671ms 3.6499ms 273.9779 Ops/s 297.6832 Ops/s $\textbf{\color{#d91a1a}-7.96\%}$
test_ppo_speed[True-backward] 8.7133ms 8.4489ms 118.3593 Ops/s 122.4850 Ops/s $\color{#d91a1a}-3.37\%$
test_ppo_speed[reduce-overhead-None] 3.7705ms 3.6249ms 275.8709 Ops/s 297.5796 Ops/s $\textbf{\color{#d91a1a}-7.30\%}$
test_ppo_speed[reduce-overhead-backward] 8.9160ms 8.7435ms 114.3712 Ops/s 107.6019 Ops/s $\textbf{\color{#35bf28}+6.29\%}$
test_reinforce_speed[False-None] 4.8133ms 4.6023ms 217.2805 Ops/s 215.4389 Ops/s $\color{#35bf28}+0.85\%$
test_reinforce_speed[False-backward] 7.6536ms 7.4634ms 133.9865 Ops/s 133.6804 Ops/s $\color{#35bf28}+0.23\%$
test_reinforce_speed[True-None] 3.1932ms 2.9117ms 343.4464 Ops/s 344.6334 Ops/s $\color{#d91a1a}-0.34\%$
test_reinforce_speed[True-backward] 8.2608ms 7.8389ms 127.5684 Ops/s 122.1783 Ops/s $\color{#35bf28}+4.41\%$
test_reinforce_speed[reduce-overhead-None] 3.3358ms 2.8898ms 346.0410 Ops/s 339.1153 Ops/s $\color{#35bf28}+2.04\%$
test_reinforce_speed[reduce-overhead-backward] 8.4132ms 7.9707ms 125.4597 Ops/s 121.0646 Ops/s $\color{#35bf28}+3.63\%$
test_iql_speed[False-None] 24.7369ms 20.2679ms 49.3390 Ops/s 49.1182 Ops/s $\color{#35bf28}+0.45\%$
test_iql_speed[False-backward] 31.2800ms 30.5759ms 32.7055 Ops/s 32.7464 Ops/s $\color{#d91a1a}-0.12\%$
test_iql_speed[True-None] 9.3134ms 8.5060ms 117.5645 Ops/s 116.7818 Ops/s $\color{#35bf28}+0.67\%$
test_iql_speed[True-backward] 17.1962ms 16.8651ms 59.2940 Ops/s 59.3773 Ops/s $\color{#d91a1a}-0.14\%$
test_iql_speed[reduce-overhead-None] 8.9257ms 8.5830ms 116.5097 Ops/s 113.7166 Ops/s $\color{#35bf28}+2.46\%$
test_iql_speed[reduce-overhead-backward] 17.8346ms 17.3766ms 57.5487 Ops/s 58.0021 Ops/s $\color{#d91a1a}-0.78\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 8.4422ms 6.2214ms 160.7346 Ops/s 162.9265 Ops/s $\color{#d91a1a}-1.35\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.5534ms 0.3077ms 3.2495 KOps/s 2.6152 KOps/s $\textbf{\color{#35bf28}+24.25\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6091ms 0.2966ms 3.3715 KOps/s 2.7220 KOps/s $\textbf{\color{#35bf28}+23.86\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.1209ms 5.8984ms 169.5387 Ops/s 170.7654 Ops/s $\color{#d91a1a}-0.72\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.0530ms 0.3023ms 3.3082 KOps/s 2.4321 KOps/s $\textbf{\color{#35bf28}+36.02\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6665ms 0.3191ms 3.1334 KOps/s 2.5165 KOps/s $\textbf{\color{#35bf28}+24.52\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.6606ms 1.3823ms 723.4125 Ops/s 655.3709 Ops/s $\textbf{\color{#35bf28}+10.38\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.5614ms 1.3385ms 747.0834 Ops/s 686.9414 Ops/s $\textbf{\color{#35bf28}+8.76\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 10.0087ms 6.1140ms 163.5600 Ops/s 165.4985 Ops/s $\color{#d91a1a}-1.17\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.7225ms 0.4357ms 2.2949 KOps/s 1.7810 KOps/s $\textbf{\color{#35bf28}+28.85\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7938ms 0.4166ms 2.4003 KOps/s 1.8422 KOps/s $\textbf{\color{#35bf28}+30.29\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.9115ms 5.8235ms 171.7169 Ops/s 169.1901 Ops/s $\color{#35bf28}+1.49\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.3286ms 0.2880ms 3.4720 KOps/s 2.3960 KOps/s $\textbf{\color{#35bf28}+44.90\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5601ms 0.3126ms 3.1988 KOps/s 2.4708 KOps/s $\textbf{\color{#35bf28}+29.46\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.0505ms 5.8027ms 172.3346 Ops/s 171.7866 Ops/s $\color{#35bf28}+0.32\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9196s 1.9453ms 514.0663 Ops/s 2.8973 KOps/s $\textbf{\color{#d91a1a}-82.26\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.4607ms 0.2677ms 3.7358 KOps/s 2.8268 KOps/s $\textbf{\color{#35bf28}+32.16\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.2040ms 6.0105ms 166.3767 Ops/s 166.5827 Ops/s $\color{#d91a1a}-0.12\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8118ms 0.4700ms 2.1275 KOps/s 1.8682 KOps/s $\textbf{\color{#35bf28}+13.88\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8223ms 0.4492ms 2.2263 KOps/s 2.1106 KOps/s $\textbf{\color{#35bf28}+5.48\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 6.4874ms 5.0073ms 199.7097 Ops/s 51.3786 Ops/s $\textbf{\color{#35bf28}+288.70\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 12.9911ms 1.9446ms 514.2511 Ops/s 508.0945 Ops/s $\color{#35bf28}+1.21\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.9291ms 1.1168ms 895.4492 Ops/s 895.2060 Ops/s $\color{#35bf28}+0.03\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 9.7531ms 5.1223ms 195.2250 Ops/s 192.6304 Ops/s $\color{#35bf28}+1.35\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 6.2713ms 1.7972ms 556.4237 Ops/s 592.1738 Ops/s $\textbf{\color{#d91a1a}-6.04\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 12.7338ms 1.3139ms 761.0731 Ops/s 775.8574 Ops/s $\color{#d91a1a}-1.91\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.6190s 17.5769ms 56.8927 Ops/s 188.1570 Ops/s $\textbf{\color{#d91a1a}-69.76\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 4.1002ms 1.9499ms 512.8421 Ops/s 483.7903 Ops/s $\textbf{\color{#35bf28}+6.01\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 10.5260ms 1.4232ms 702.6191 Ops/s 932.9646 Ops/s $\textbf{\color{#d91a1a}-24.69\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 37.7966ms 34.6714ms 28.8422 Ops/s 28.5858 Ops/s $\color{#35bf28}+0.90\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 19.5601ms 17.8692ms 55.9623 Ops/s 55.8901 Ops/s $\color{#35bf28}+0.13\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 37.4838ms 35.4001ms 28.2485 Ops/s 27.9321 Ops/s $\color{#35bf28}+1.13\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 19.7276ms 18.1105ms 55.2166 Ops/s 32.5076 Ops/s $\textbf{\color{#35bf28}+69.86\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 38.8560ms 37.2756ms 26.8272 Ops/s 26.3775 Ops/s $\color{#35bf28}+1.70\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 21.0065ms 19.5067ms 51.2645 Ops/s 51.1370 Ops/s $\color{#35bf28}+0.25\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Environments Adds or modifies an environment wrapper

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmoens