[Performance] Streamline collector inner loop carrier update#3564
Open
vmoens wants to merge 1 commit intogh/vmoens/245/basefrom
Open
[Performance] Streamline collector inner loop carrier update#3564vmoens wants to merge 1 commit intogh/vmoens/245/basefrom
vmoens wants to merge 1 commit intogh/vmoens/245/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3564
Note: Links to docs will display an error until the docs builds have been completed. ❌ 9 New Failures, 3 Cancelled JobsAs of commit 2487bcb with merge base 0a1aea6 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 23, 2026
This was referenced Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Pre-computes _env_returns_carrier flag to avoid per-step identity check.
Skips collector data .copy() when update_traj_ids is False (no mutation
risk). Uses internal _get_str/_set_str for collector data transfer to
bypass public API validation overhead.
Made-with: Cursor