[Feature] timeit.mark_start/mark_end for non-context-manager timing#3756
Closed
vmoens wants to merge 1 commit into
Closed
[Feature] timeit.mark_start/mark_end for non-context-manager timing#3756vmoens wants to merge 1 commit into
vmoens wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3756
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 4 New Failures, 14 PendingAs of commit 457d247 with merge base 0a01ee8 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced May 15, 2026
vmoens
commented
May 15, 2026
Comment on lines
+322
to
+325
| @classmethod | ||
| def mark_env(cls, name: str) -> None: | ||
| """Alias for :meth:`mark_end`.""" | ||
| cls.mark_end(name) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The collector worker loop needs to time spans that begin in one branch
of a control-flow path and end in another — picking up the next
continuecommand, then ending after the env step.with timeit(...)can't bridge that.
Refactor
__exit__through a new_record(name, elapsed)classmethodso the recording side is callable independently. Add
timeit.mark_start/
timeit.mark_end(andmark_envalias) on top: they push and popinto a class-level
_MARKSdict and feed_recordon end. Thecontext-manager path is unchanged.
Unit tests cover: round-trip into
_REG, mark cleanup on end, aliasidentity for
mark_env, and thatwith timeit(...)still records.