-
Notifications
You must be signed in to change notification settings - Fork 418
[BugFix] Model maker functions for A2C and PPO fail for discrete action space envs #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #717 +/- ##
==========================================
+ Coverage 88.66% 88.73% +0.07%
==========================================
Files 120 120
Lines 20186 20220 +34
==========================================
+ Hits 17898 17943 +45
+ Misses 2288 2277 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vmoens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for this
Description
For make_ppo_model and make_a2c_model helper functions, using an environment with a discrete action space raised the following error:
In this PR I suggest a fix to the problem. Also extended the help_helpers.py script to test discrete environments for both PPO and A2C.
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!