Issues/fix docker dependencies #2340
Conversation
|
@lxning The original code was not installing common.txt in case of CPU too. Please suggest if the suggested code is a better approach |
| if [ "$CUDA_VERSION" ]; then \ | ||
| python -m pip install --no-cache-dir torch==$TORCH_VER+$CUDA_VERSION torchvision==$TORCH_VISION_VER+$CUDA_VERSION -f https://download.pytorch.org/whl/torch_stable.html; \ | ||
| # Install the binary with the latest CUDA version support | ||
| python ./ts_scripts/install_dependencies.py --cuda $CUDA_VERSION; \ |
There was a problem hiding this comment.
To solve common_gpu.txt installation, you only need ref
https://github.com/pytorch/serve/blob/master/docker/Dockerfile#L75
There was a problem hiding this comment.
@lxning There is a problem with the CPU image too. It doesn't have pynvml , torchaudio, torchtext
| # Install the CPU binary | ||
| else \ | ||
| python -m pip install --no-cache-dir torch==$TORCH_VER+cpu torchvision==$TORCH_VISION_VER+cpu -f https://download.pytorch.org/whl/torch_stable.html; \ | ||
| python ./ts_scripts/install_dependencies.py; \ |
msaroufim
left a comment
msaroufim
left a comment
There was a problem hiding this comment.
LGTM just a minor nit on the cloned repo
msaroufim
left a comment
msaroufim
left a comment
There was a problem hiding this comment.
LGTM just a minor nit on the cloned repo
Codecov Report
@@ Coverage Diff @@
## master #2340 +/- ##
=======================================
Coverage 69.39% 69.39%
=======================================
Files 77 77
Lines 3441 3441
Branches 57 57
=======================================
Hits 2388 2388
Misses 1050 1050
Partials 3 3 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Description
GPU docker was missing nvgpu
Also, noticed that CPU docker image has some missing dependencies: pynvml , wrong version of Pillow
Also, the code to get the TORCH_VERSION gets the latest version and not the version we want.
Fixes #(issue)
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B
Checklist: