Skip to content

[BugFix] Cloning empty tensordicts #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vmoens merged 1 commit into from
Dec 2, 2024
Merged

[BugFix] Cloning empty tensordicts #1119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tensordict/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8679,7 +8679,7 @@ def _clone_recurse(self) -> TensorDictBase: # noqa: D417
nested_keys=True,
is_leaf=_NESTED_TENSORS_AS_LISTS,
propagate_lock=False,
filter_empty=True,
filter_empty=False,
default=None,
)
if items:
Expand Down
11 changes: 11 additions & 0 deletions test/test_tensordict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,17 @@ def test_cat_from_tensordict(self):
assert (tensor[:, :4] == 0).all()
assert (tensor[:, 4:] == 1).all()

@pytest.mark.parametrize("recurse", [True, False])
def test_clone_empty(self, recurse):
td = TensorDict()
assert td.clone(recurse=recurse) is not None
td = TensorDict(device="cpu")
assert td.clone(recurse=recurse) is not None
td = TensorDict(batch_size=[2])
assert td.clone(recurse=recurse) is not None
td = TensorDict(device="cpu", batch_size=[2])
assert td.clone(recurse=recurse) is not None

@pytest.mark.filterwarnings("error")
@pytest.mark.parametrize("device", [None, *get_available_devices()])
@pytest.mark.parametrize("num_threads", [0, 1, 2])
Expand Down
Loading