[Feature] Add init value option to AddStateIndependentNormalScale #1259
Conversation
|
Hi @lin-erica! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
| if make_param: | ||
| self.state_independent_scale = torch.nn.Parameter( | ||
| torch.zeros(scale_shape, device=device) | ||
| torch.ones(scale_shape, device=device) * init_value |
There was a problem hiding this comment.
| torch.ones(scale_shape, device=device) * init_value | |
| torch.full(scale_shape, init_value, dtype=torch.get_default_dtype(), device=device) |
| else: | ||
| self.state_independent_scale = torch.nn.Buffer( | ||
| torch.zeros(scale_shape, device=device) | ||
| torch.ones(scale_shape, device=device) * init_value |
There was a problem hiding this comment.
| torch.ones(scale_shape, device=device) * init_value | |
| torch.full(scale_shape, init_value, dtype=torch.get_default_dtype(), device=device) |
lin-erica
force-pushed
the
elin/init_scale
branch
from
c8c1df8 to
9cebefe
Compare
|
Seems like the CI is kinda broken - let me investigate |
4 participants
Description
When using AddStateIndependentNormalScale (in our case specifically with scale_mapping relu) we'd like the option of initializing the scale to any value based on our configurations. I added the option of taking in an initial value. Since it's set to 0.0 for default, it should be the same as initializing to torch.zeros.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!