Skip to content

[CI] Fix windows wheels versioning #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

[CI] Fix windows wheels versioning #1436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions .github/scripts/version_script.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ if "%GITHUB_REF_TYPE%"=="branch" (
if not errorlevel 1 (
echo Setting static version for release branch: %GITHUB_REF_NAME%
set TENSORDICT_BUILD_VERSION=%BASE_VERSION%
set SETUPTOOLS_SCM_PRETEND_VERSION=%TENSORDICT_BUILD_VERSION%
set SETUPTOOLS_SCM_PRETEND_VERSION=%BASE_VERSION%
goto setup_build
)
)
Expand All @@ -19,7 +19,7 @@ if "%GITHUB_REF_TYPE%"=="tag" (
if not errorlevel 1 (
echo Setting static version for release candidate tag: %GITHUB_REF_NAME%
set TENSORDICT_BUILD_VERSION=%BASE_VERSION%
set SETUPTOOLS_SCM_PRETEND_VERSION=%TENSORDICT_BUILD_VERSION%
set SETUPTOOLS_SCM_PRETEND_VERSION=%BASE_VERSION%
goto setup_build
)
)
Expand Down Expand Up @@ -61,6 +61,11 @@ set TENSORDICT_BUILD_VERSION=%DEV_VERSION%

:setup_build
echo TENSORDICT_BUILD_VERSION is set to %TENSORDICT_BUILD_VERSION%
echo SETUPTOOLS_SCM_PRETEND_VERSION is set to %SETUPTOOLS_SCM_PRETEND_VERSION%
echo DEBUG: About to run build command with version environment
echo DEBUG: BASE_VERSION = %BASE_VERSION%
echo DEBUG: Environment variable check...
set | findstr SETUPTOOLS_SCM

if "%CONDA_RUN%"=="" (
echo CONDA_RUN is not set. Please activate your conda environment or set CONDA_RUN.
Expand Down Expand Up @@ -101,6 +106,7 @@ if "%CU_VERSION%" == "xpu" call "C:\Program Files (x86)\Intel\oneAPI\setvars.bat

set DISTUTILS_USE_SDK=1

REM Capture all arguments passed to this script
set args=%1
shift
:start
Expand All @@ -110,9 +116,6 @@ shift
goto start

:done
if "%args%" == "" (
echo Usage: vc_env_helper.bat [command] [args]
echo e.g. vc_env_helper.bat cl /c test.cpp
)

REM Execute the build command with environment variables set
echo Executing build command: %args%
%args% || exit /b 1
1 change: 1 addition & 0 deletions .github/workflows/build-wheels-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,4 @@ jobs:
package-name: ${{ matrix.package-name }}
smoke-test-script: ${{ matrix.smoke-test-script }}
trigger-event: ${{ github.event_name }}
build-platform: python-build-package
Loading