Skip to content

Conversation

@DanilBaibak
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Nov 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
torchci ⬜️ Ignored (Inspect) Nov 14, 2022 at 10:19AM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 11, 2022
@DanilBaibak DanilBaibak added the WIP Work in progress. Do not merge. label Nov 11, 2022
@DanilBaibak DanilBaibak marked this pull request as draft November 11, 2022 15:16
@osalpekar
Copy link
Member

Awesome - thanks @DanilBaibak! Looks like it just worked smoothly :) Fwiw, it looks like their builds actually don't use CUDA, so we can add this to the test_..._without_cuda.yml. And we can engage with their POC on next steps like smoke tests and implementing the caller in their repo.

Copy link

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Came across on this PR. Thank you for the effort to enable TD binaries. I left a note below about TorchData package.

matrix:
include:
- repository: pytorch/text
- repository: pytorch/data
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note from TorchData side, we do have a flag called BUILD_S3=1 to enable compilation of our C++ code for binary releases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for such details @ejguan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. WIP Work in progress. Do not merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants