ci: Add action to export matrix variables #1201
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
facebook-github-bot
added
the
CLA Signed
Adds the ability for the workflow to export matrix variables as
environment variables for our generic workflows. All environment
variables will be reference like so:
MATRIX_${var_name}
Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
seemethere
force-pushed
the
seemethere/export_matrix
branch
from
76c34a9 to
d503c27
Compare
Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
Member
Author
|
Assigning to @atalman since I don't have enough bandwidth to finish this |
atalman
added a commit
that referenced
this pull request
Dec 28, 2022
Its based on @seemethere work here: #1201 Adds the ability for the workflow to export matrix variables as environment variables for our generic workflows. All environment variables will be reference like so: ``` MATRIX_${var_name} ``` With this we can remove all the environment initialization in the validation workflows, here is an example: https://github.com/pytorch/builder/blob/main/.github/workflows/validate-linux-binaries.yml#L54 Signed-off-by: Eli Uriegas <eliuriegas@meta.com> Co-authored-by: Eli Uriegas <eliuriegas@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for the workflow to export matrix variables as environment variables for our generic workflows. All environment variables will be reference like so:
Signed-off-by: Eli Uriegas eliuriegas@meta.com