This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Nayef211/update vectors#853
Merged
Nayef211 merged 31 commits intopytorch:masterfrom Jun 25, 2020
Merged
Conversation
…211/text into nayef211/benchmark_vectors
Codecov Report
@@ Coverage Diff @@
## master #853 +/- ##
==========================================
- Coverage 76.91% 76.86% -0.05%
==========================================
Files 42 42
Lines 2946 2944 -2
==========================================
- Hits 2266 2263 -3
- Misses 680 681 +1
Continue to review full report at Codecov.
|
| a,1 0 0 | ||
| b,0 1 0 No newline at end of file | ||
| a 1 0 0 | ||
| b 0 1 0 No newline at end of file |
Contributor
There was a problem hiding this comment.
why do we remove comma from csv file?
zhangguanheng66
approved these changes
Jun 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_load_token_and_vectors_from_filemethod for the underlying implementation ofvectors_from_file_objectfor consistency. Raise error when there is a duplicate token present in the csv file.dup_tokensGloVe