This repository was archived by the owner on Nov 1, 2024. It is now read-only.
Improve icolumn.py cc 4/4 test_string_column #410
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D37492649 fbshipit-source-id: 2d71c5002a002fa478359bb551e66a97a7365e52
Differential Revision: D37492647 fbshipit-source-id: a875d5fdd7499566541e2623a9581f7ed1812974
Summary: Improves test coverage for icolumn.py through test_string_column. icolumn.py has ~55% code coverage currently and this diff brings it to 78.3. Differential Revision: D37289878 fbshipit-source-id: 11958d7708c90878a6cfa6ca2a812774cc1dd6c5
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37289878 |
andrewaikens87
added a commit
to andrewaikens87/torcharrow
that referenced
this pull request
Jun 29, 2022
Summary: Pull Request resolved: pytorch#410 Improves test coverage for icolumn.py through test_string_column. icolumn.py has ~55% code coverage currently and this diff brings it to 78.3. Differential Revision: D37289878 fbshipit-source-id: ad6e74c5d23b0ca30c39168740533cc169dd0bd2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Improves test coverage for icolumn.py through test_string_column.
icolumn.py has ~55% code coverage currently and this diff brings it to 78.3.
Differential Revision: D37289878