This repository was archived by the owner on Nov 1, 2024. It is now read-only.
Update compatibility matrix in README #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
update the nightly versions compatibility
ejguan
reviewed
Jul 13, 2022
| | `torch` | `torcharrow` | `python` | | ||
| | ------------------ | ------------------ | ----------------- | | ||
| | `main` / `nightly` | `main` / `nightly` | `>=3.7`, `<=3.10` | | ||
| | `1.12.0` / `1.13.0`| `0.1.0` / `0.2.0` | `>=3.7`, `<=3.10` | |
Contributor
There was a problem hiding this comment.
Does the version after / refer to nightly?
If it refers to two different official releases, you should split it into two rows.
Contributor
Author
There was a problem hiding this comment.
yeah that's how I understood it. 0.1.0 is the official release, and 0.2.0 is the next version (nightly, not official yet).
Contributor
There was a problem hiding this comment.
Technically, the line 33 refers to nightly release.
Contributor
Author
There was a problem hiding this comment.
I see ... then do you need to have the matrix for official release at all? Or just the main / nightly?
bearzx
added a commit
that referenced
this pull request
Jul 13, 2022
misunderstood the matrix definition in #440 , need to give more tweaks to it.
Merged
bearzx
added a commit
that referenced
this pull request
Jul 13, 2022
misunderstood the matrix definition in #440 , need to give more tweaks to it.
Contributor
|
Perhaps just squash into one commits before merge :) |
wenleix
pushed a commit
that referenced
this pull request
Jul 16, 2022
misunderstood the matrix definition in #440 , need to give more tweaks to it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsia