This repository was archived by the owner on Nov 1, 2024. It is now read-only.
Use rootMemoryPool to construct execContext #480
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: It originally use `memory::getDefaultScopedMemoryPool()` since `ExecCtx` constructor expects `unique_ptr<MemoryPool>`. Since facebookincubator/velox@15eeddb, `ExecCtx` now expects `MemoryPool*`, so we can use `&velox::memory::getProcessDefaultMemoryManager().getRoot()` returned by `TorchArrowGlobalStatic::rootMemoryPool`. This makes TorchArrow always use this process default root memory pool. Differential Revision: D39010989 fbshipit-source-id: ef9aa702d5649a73bbcd5d9cce910a2573e4195f
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39010989 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 25, 2022
Summary: Pull Request resolved: #480 It originally use `memory::getDefaultScopedMemoryPool()` since `ExecCtx` constructor expects `unique_ptr<MemoryPool>`. Since facebookincubator/velox@15eeddb, `ExecCtx` now expects `MemoryPool*`, so we can use `&velox::memory::getProcessDefaultMemoryManager().getRoot()` returned by `TorchArrowGlobalStatic::rootMemoryPool`. This makes TorchArrow always use this process default root memory pool. Reviewed By: dracifer, vancexu Differential Revision: D39010989 fbshipit-source-id: 3a383b01163e9866500a6fc8b091080b70684c6e
wenleix
added a commit
that referenced
this pull request
Aug 27, 2022
Summary: Pull Request resolved: #480 It originally use `memory::getDefaultScopedMemoryPool()` since `ExecCtx` constructor expects `unique_ptr<MemoryPool>`. Since facebookincubator/velox@15eeddb, `ExecCtx` now expects `MemoryPool*`, so we can use `&velox::memory::getProcessDefaultMemoryManager().getRoot()` returned by `TorchArrowGlobalStatic::rootMemoryPool`. This makes TorchArrow always use this process default root memory pool. Reviewed By: dracifer, vancexu Differential Revision: D39010989 fbshipit-source-id: 3a383b01163e9866500a6fc8b091080b70684c6e
wenleix
added a commit
that referenced
this pull request
Aug 27, 2022
Summary: Pull Request resolved: #480 It originally use `memory::getDefaultScopedMemoryPool()` since `ExecCtx` constructor expects `unique_ptr<MemoryPool>`. Since facebookincubator/velox@15eeddb, `ExecCtx` now expects `MemoryPool*`, so we can use `&velox::memory::getProcessDefaultMemoryManager().getRoot()` returned by `TorchArrowGlobalStatic::rootMemoryPool`. This makes TorchArrow always use this process default root memory pool. Reviewed By: dracifer, vancexu Differential Revision: D39010989 fbshipit-source-id: 3a383b01163e9866500a6fc8b091080b70684c6e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It originally use
memory::getDefaultScopedMemoryPool()sinceExecCtxconstructor expects
unique_ptr<MemoryPool>.Since facebookincubator/velox@15eeddb,
ExecCtxnow expectsMemoryPool*, so we can use&velox::memory::getProcessDefaultMemoryManager().getRoot()returned byTorchArrowGlobalStatic::rootMemoryPool.This makes TorchArrow always use this process default root memory pool.
Differential Revision: D39010989