This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Fix GeneratorArgs to avoid unsafely accessing prompt and num_samples #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1007
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2ee35fb with merge base f0b2df7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
Force land to fix branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompt and num_samples were restricted from suppressed arg (always accepted as CLI arg even when not used by subcommand) to being restricted to
generatein #987.But this PR missed a call site. This updates the callsite that was missed to not access the field without checking for existence
Tested that both these commands no longer crash with accessing unavailable fields:
Fixes: #1003