This repository was archived by the owner on Sep 10, 2025. It is now read-only.
[Hackability Refactor] Collapse quant_ops into calling sites #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1062
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 611b449 with merge base d0d1105 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Jack-Khuu
changed the title
Jack-Khuu
changed the title
Jack-Khuu
changed the title
Jack-Khuu
requested review from
Gasoonjia,
byjlw,
jerryzh168,
larryliu0820,
metascroy and
vmpuri
jerryzh168
approved these changes
Aug 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the overall refactoring work to make the repo more accessible, this PR moves quant related files into their respective call sites, flattening the qops file.
Specifically
qops.py=>gguf_loader.py(int4)quantize.py(int8 + Embedding)A separate PR will move this file to torchchat/torchchat/utils (Not done in this PR to avoid merge conflicts)
This results in the
quantize.pyfile growing in size, but this file itself will be slimmed via migration to torchao apis