This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Wrap unused lm_eval in try-catch: Unblock dist_run #1228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1228
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 83090cd with merge base 8278aa2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kwen2501
approved these changes
Sep 28, 2024
Contributor
kwen2501
left a comment
kwen2501
left a comment
There was a problem hiding this comment.
Thanks much for fixing this!!
Contributor
|
Resolves #1220 ? |
Contributor
Author
That's what I'm hoping for haha |
Jack-Khuu
changed the title
Jack-Khuu
changed the title
metascroy
pushed a commit
that referenced
this pull request
Sep 30, 2024
* Fix Evaluate to a version * clean comments * Adding MPS Support for LLama3.2 11B Multimodal; Bump torchtune 9.28.24 * Lock onto a pre BC breaking version of datasets * Bump lm_eval import before torchtune * Minimize changes * Minimize changes * Test local import * Just Try Catch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code results in an unhealthy import environment when executing from a distributed setting i.e.
dist_run.py. This is continuation of the fix from ec7b510The try-catch is a temporary patch to unbreak dist_run.py, while we investigate. Bug: #1220
Test:
python dist_run.py --model_nameno longer fails ion import (see bug issue for details)