This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Flag misnomer: GeneratorArgs.is_torchtune_model #1274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1274
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 67de1b3 with merge base d0993b3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
byjlw
reviewed
Oct 7, 2024
| ( | ||
| text_transformer_args.block_size | ||
| if text_transformer_args is not None | ||
| else 2048 |
There was a problem hiding this comment.
discrete numbers and strings should be constants or at the very least have comments explaining why that number.
byjlw
approved these changes
Oct 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flagging
GeneratorArgs.is_torchtune_modelas a misnomer since it doesn't capture all torchtune models (i.e. Flamingo)This PR also reverts the commenting out of a snippet of code in d0993b3 which was done to unblock Flamingo support, but affected non-torchtune behavior
Tests (Server + CLI)
Llama 3.2 11B with image input
Verified
python torchchat.py generate llama3.2-11B --prompt "What's in this image?" --image-prompt assets/dog.jpgLlama 3.2 11B with no image input
Verified
python torchchat.py generate llama3.2-11BLlama 3.2 1B
Verified
python torchchat.py generate llama3.2-1B